Github messages for voidlinux
 help / color / mirror / Atom feed
From: lane-brain <lane-brain@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: New package: libgccjit-10.2.1_pre1
Date: Tue, 16 Feb 2021 18:39:53 +0100	[thread overview]
Message-ID: <20210216173953.QxPmyle3-JFJRsUeC_HPdczNybg_i9qVua9FAeXEsDE@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-28785@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1959 bytes --]

New comment by lane-brain on void-packages repository

https://github.com/void-linux/void-packages/pull/28785#issuecomment-780002696

Comment:
@ericonr I have some good news! I've been able to rewrite the template to resolve a lot of the issues. I resolved nearly all of the errors from xlint, the only one is the license issue but afaik I am supposed to include the runtime exception license. I've included a version of the patch you specified, symlinked the directories, and symlinked the individual patches in files/ because I needed to include the musl patch. Additionally I've been able to get successful cross builds for x86_64-musl and armv7l, and I am crossing my fingers for other archs. Runtime tests on emacs-nativecomp confirm that we get working elc compilation. 

I apologize for the bad commit @50c7abf, I made a mistake with the relative symlinks.

A crucial change for working cross builds consisted in removing the -devel packages and going to the original distfiles defs that unpacked the source packages directly to the build dir. For whatever reason, the {gmp,mpf,*}-devel packages failed citing an unresolvable shlib at libc.so on cross builds. I worry that this may increase the build times, and am generally curious why this error would occur.

Without these devel packages, the build failed citing an error with these subpackages needing to be compiled with -fPIC. Adding this to the compiler flags made for a working build.

I needed to retain the _triplets var defined in the original gcc package, because XBPS_TARGET_TRIPLET is empty at the do_install phase and it needs to be defined at that stage to set the correct header install paths.

One last thing, the soname needs to be added to shlibs. I was unsure whether it was appropriate to include this modification in the commit or whether this change was to be made by the void team, so let me know what is best. Build tests are in progress, let's see how it pans out.

  parent reply	other threads:[~2021-02-16 17:39 UTC|newest]

Thread overview: 165+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-16  1:36 [PR PATCH] " lane-brain
2021-02-16  1:40 ` ericonr
2021-02-16  1:50 ` [PR REVIEW] " ericonr
2021-02-16  1:50 ` ericonr
2021-02-16  1:50 ` ericonr
2021-02-16  1:50 ` ericonr
2021-02-16  1:50 ` ericonr
2021-02-16  1:50 ` ericonr
2021-02-16  1:50 ` ericonr
2021-02-16  1:50 ` ericonr
2021-02-16  1:50 ` ericonr
2021-02-16  1:50 ` ericonr
2021-02-16  1:50 ` ericonr
2021-02-16  1:50 ` ericonr
2021-02-16  1:50 ` ericonr
2021-02-16  1:50 ` ericonr
2021-02-16  1:50 ` ericonr
2021-02-16  1:50 ` ericonr
2021-02-16  6:00 ` lane-brain
2021-02-16  6:00 ` lane-brain
2021-02-16  6:01 ` lane-brain
2021-02-16  6:02 ` lane-brain
2021-02-16  6:05 ` lane-brain
2021-02-16  6:23 ` lane-brain
2021-02-16  6:23 ` lane-brain
2021-02-16  6:28 ` lane-brain
2021-02-16  6:32 ` lane-brain
2021-02-16  6:33 ` lane-brain
2021-02-16  6:33 ` lane-brain
2021-02-16  6:34 ` lane-brain
2021-02-16  6:35 ` lane-brain
2021-02-16  6:35 ` lane-brain
2021-02-16  6:44 ` lane-brain
2021-02-16  6:48 ` ericonr
2021-02-16 10:03 ` [PR REVIEW] " fosslinux
2021-02-16 17:19 ` [PR PATCH] [Updated] " lane-brain
2021-02-16 17:25 ` lane-brain
2021-02-16 17:39 ` lane-brain [this message]
2021-02-16 17:54 ` [PR REVIEW] " lane-brain
2021-02-16 17:54 ` lane-brain
2021-02-16 17:55 ` lane-brain
2021-02-16 17:57 ` lane-brain
2021-02-16 17:58 ` lane-brain
2021-02-16 17:59 ` lane-brain
2021-02-16 17:59 ` lane-brain
2021-02-16 18:01 ` lane-brain
2021-02-16 18:04 ` FollieHiyuki
2021-02-16 18:07 ` [PR REVIEW] " ericonr
2021-02-16 18:07 ` ericonr
2021-02-16 18:07 ` ericonr
2021-02-16 18:07 ` ericonr
2021-02-16 18:07 ` ericonr
2021-02-16 18:10 ` ericonr
2021-02-16 18:12 ` [PR REVIEW] " lane-brain
2021-02-16 18:13 ` lane-brain
2021-02-16 18:13 ` ericonr
2021-02-16 18:13 ` ericonr
2021-02-16 18:14 ` lane-brain
2021-02-16 18:15 ` lane-brain
2021-02-16 18:16 ` ericonr
2021-02-16 18:17 ` lane-brain
2021-02-16 18:34 ` ericonr
2021-02-16 20:05 ` lane-brain
2021-02-16 20:06 ` lane-brain
2021-02-16 20:24 ` lane-brain
2021-02-17  0:43 ` [PR PATCH] [Updated] " lane-brain
2021-02-17 18:07 ` lane-brain
2021-02-18  4:03 ` lane-brain
2021-02-18  4:04 ` lane-brain
2021-02-18 18:48 ` [PR PATCH] [Updated] " lane-brain
2021-02-18 18:56 ` lane-brain
2021-02-18 18:57 ` lane-brain
2021-02-18 19:26 ` ericonr
2021-02-18 19:26 ` ericonr
2021-02-19  3:31 ` [PR PATCH] [Updated] " lane-brain
2021-02-19  5:13 ` lane-brain
2021-02-19 18:21 ` lane-brain
2021-02-19 18:44 ` lane-brain
2021-02-25  0:13 ` lane-brain
2021-02-25 14:52 ` ericonr
2021-02-25 20:24 ` lane-brain
2021-02-27  0:13 ` xianwenchen
2021-03-15  8:41 ` ramos
2021-03-18  8:28 ` xianwenchen
2021-03-18 23:22 ` lane-brain
2021-03-19 13:31 ` xianwenchen
2021-03-21  0:37 ` lane-brain
2021-03-24 10:09 ` xianwenchen
2021-03-30 22:39 ` floyza
2021-04-10  9:07 ` xianwenchen
2021-04-10 14:20 ` ericonr
2021-04-10 21:33 ` xianwenchen
2021-04-11  1:41 ` floyza
2021-04-12 23:18 ` xianwenchen
2021-04-14 22:48 ` lane-brain
2021-05-14  6:28 ` Sparkenstein
2021-07-29 10:16 ` brihadeesh
2021-07-29 12:20 ` FollieHiyuki
2021-07-29 12:21 ` FollieHiyuki
2021-07-29 16:36 ` brihadeesh
2021-08-27 17:34 ` ericonr
2021-08-31  6:00 ` lane-brain
2021-12-25 13:13 ` soanvig
2022-01-04 19:57 ` lane-brain
2022-01-17 21:31 ` michaelmrose
2022-01-17 22:16 ` lane-brain
2022-01-18  7:30 ` michaelmrose
2022-01-18 18:38 ` lane-brain
2022-03-03  7:47 ` brihadeesh
2022-03-03  8:11 ` brihadeesh
2022-03-11 19:52 ` KJ002
2022-03-12 16:47 ` lane-brain
2022-03-12 19:04 ` KJ002
2022-03-12 19:05 ` KJ002
2022-03-13  6:51 ` brihadeesh
2022-03-14 19:49 ` [PR PATCH] [Updated] " lane-brain
2022-03-14 19:56 ` lane-brain
2022-03-14 19:57 ` lane-brain
2022-03-14 19:58 ` lane-brain
2022-03-14 20:02 ` lane-brain
2022-03-14 20:02 ` lane-brain
2022-03-14 21:04 ` KJ002
2022-03-14 22:04 ` KJ002
2022-03-14 22:05 ` KJ002
2022-03-17 19:23 ` jbenden
2022-03-17 19:25 ` jbenden
2022-03-25 15:39 ` mustaqimM
2022-04-04 16:05 ` leahneukirchen
2022-04-04 16:09 ` [PR REVIEW] " leahneukirchen
2022-04-04 16:09 ` leahneukirchen
2022-04-04 16:11 ` leahneukirchen
2022-04-04 16:21 ` [PR REVIEW] " leahneukirchen
2022-04-14  2:29 ` lane-brain
2022-04-14  2:29 ` lane-brain
2022-04-14  2:31 ` lane-brain
2022-04-14  2:45 ` lane-brain
2022-04-14  3:03 ` [PR PATCH] [Updated] " lane-brain
2022-04-14  3:04 ` [PR REVIEW] " lane-brain
2022-04-14 11:30 ` leahneukirchen
2022-04-14 13:52 ` leahneukirchen
2022-04-14 15:38 ` sofeepokhrel
2022-04-14 18:11 ` lane-brain
2022-04-14 18:12 ` lane-brain
2022-04-14 18:15 ` lane-brain
2022-04-14 18:20 ` lane-brain
2022-04-14 18:21 ` lane-brain
2022-04-14 18:38 ` leahneukirchen
2022-04-14 18:40 ` leahneukirchen
2022-04-14 20:03 ` [PR PATCH] [Updated] " lane-brain
2022-04-14 20:07 ` lane-brain
2022-04-14 20:15 ` [PR REVIEW] " paper42
2022-04-14 20:15 ` paper42
2022-04-14 20:15 ` paper42
2022-04-14 20:19 ` paper42
2022-04-14 20:19 ` paper42
2022-04-14 20:19 ` paper42
2022-04-14 20:19 ` paper42
2022-04-14 20:19 ` paper42
2022-04-14 20:23 ` leahneukirchen
2022-04-14 20:25 ` leahneukirchen
2022-04-14 20:25 ` leahneukirchen
2022-04-15 15:27 ` [PR PATCH] [Updated] " leahneukirchen
2022-04-15 15:32 ` [PR REVIEW] " leahneukirchen
2022-04-16 11:48 ` [PR PATCH] [Merged]: " leahneukirchen
2022-07-02  1:39 ` [PR REVIEW] " acomeofficial

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210216173953.QxPmyle3-JFJRsUeC_HPdczNybg_i9qVua9FAeXEsDE@z \
    --to=lane-brain@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).