From: CMB <CMB@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: Package `xen' creates service that spams dmesg when no hypervisor is running
Date: Tue, 16 Feb 2021 22:40:46 +0100 [thread overview]
Message-ID: <20210216214046.l_aH0gzjpac13hqzYMdmtYZdfLZipeVbnQeeXjZrtVE@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-18676@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1132 bytes --]
New comment by CMB on void-packages repository
https://github.com/void-linux/void-packages/issues/18676#issuecomment-780135145
Comment:
Looks reasonable on the face of it, but a couple points:
* In the no-op softfail condition, I'd do something like an `exec pause` or `exec chpst ... pause`. Otherwise runsv will just keep looping trying to start it.
* The command `xl list` pulls data from xenstored. I'm not sure that it will return 0 before xenstored is up, so it's a chicken and egg problem. I need to test that. If `xl list` doesn't work, I know of other ways to test whether something is running in a Xen dom0.
Another thing I want to do with the xenstored service is have a configurable executable name. There are two xenstored implementations shipped by Xen: the original C implementation (xenstored) and the newer ocaml implementation (oxenstored). oxenstored is recommended by upstream and -- in my experience -- less buggy. So xenstored/run should allow overriding the executable name in ./conf.
I'll send a well-tested PR for all of this. It may be a day or two; I'm recovering from a 3-day power outage.
next prev parent reply other threads:[~2021-02-16 21:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-31 6:09 [ISSUE] " voidlinux-github
2020-08-08 11:55 ` ashpooljh
2021-02-15 6:06 ` ericonr
2021-02-16 21:40 ` CMB [this message]
2021-02-16 21:52 ` ericonr
2022-04-15 2:13 ` github-actions
2022-04-29 2:13 ` [ISSUE] [CLOSED] " github-actions
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210216214046.l_aH0gzjpac13hqzYMdmtYZdfLZipeVbnQeeXjZrtVE@z \
--to=cmb@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).