From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] volctl: update to 0.8.2.
Date: Thu, 18 Feb 2021 05:54:17 +0100 [thread overview]
Message-ID: <20210218045417.Nlb8v20BMr4gpZKqrgGmjkPjNk4v22OmYh7NzyhcYeM@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-28806@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 297 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/28806#discussion_r578131618
Comment:
If the warning doesn't affect the build, I'd prefer to leave this out. Might be nice to ask upstream to fix on their side, though (or send them a PR).
next prev parent reply other threads:[~2021-02-18 4:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 23:50 [PR PATCH] " teldra
2021-02-17 14:04 ` ericonr
2021-02-17 14:21 ` [PR PATCH] [Updated] " teldra
2021-02-17 14:37 ` teldra
2021-02-17 14:49 ` teldra
2021-02-17 14:54 ` teldra
2021-02-17 14:58 ` teldra
2021-02-18 4:54 ` [PR REVIEW] " ericonr
2021-02-18 4:54 ` ericonr
2021-02-18 4:54 ` ericonr [this message]
2021-02-19 9:17 ` [PR PATCH] [Updated] " teldra
2021-02-19 9:24 ` teldra
2021-02-19 10:33 ` teldra
2021-02-22 19:10 ` teldra
2021-02-22 19:16 ` [PR REVIEW] " teldra
2021-02-22 19:16 ` teldra
2021-02-22 19:21 ` [PR PATCH] [Merged]: " ericonr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210218045417.Nlb8v20BMr4gpZKqrgGmjkPjNk4v22OmYh7NzyhcYeM@z \
--to=ericonr@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).