Re: [PR PATCH] [Updated] chromium: update to 88.0.4324.182.

[pbui <pbui@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 1828 bytes --]

There is an updated pull request by pbui against master on the void-packages repository

https://github.com/pbui/void-packages chromium
https://github.com/void-linux/void-packages/pull/28827

chromium: update to 88.0.4324.182.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

[ci skip]

- Built for x86_64, x86_64-musl, i686.
- Tested on x86_64.

- Related blog post: https://chromereleases.googleblog.com/2021/02/stable-channel-update-for-desktop_16.html
- Pre-built packages: https://h4x0r.space

A patch file from https://github.com/void-linux/void-packages/pull/28827.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-chromium-28827.patch --]
[-- Type: text/x-diff, Size: 3460 bytes --]

From f5aebed027046db93203494034602aed8f5c0c12 Mon Sep 17 00:00:00 2001
From: Peter Bui <pbui@github.bx612.space>
Date: Wed, 17 Feb 2021 11:32:10 -0500
Subject: [PATCH 1/2] chromium: update to 88.0.4324.182.

- Built for x86_64, x86_64-musl, i686.
- Tested on x86_64.

- Remove/update deprecated build options: is_desktop_linux,
  closure_compile, binutils_path, linux_use_bundled_binutils.
---
 srcpkgs/chromium/template | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/chromium/template b/srcpkgs/chromium/template
index b543051ccf7..098cb904da9 100644
--- a/srcpkgs/chromium/template
+++ b/srcpkgs/chromium/template
@@ -1,7 +1,7 @@
 # Template file for 'chromium'
 pkgname=chromium
 # See http://www.chromium.org/developers/calendar for the latest version
-version=88.0.4324.150
+version=88.0.4324.182
 revision=1
 archs="i686* x86_64* aarch64* armv7l* ppc64le*"
 short_desc="Google's attempt at creating a safer, faster, and more stable browser"
@@ -9,7 +9,7 @@ maintainer="Enno Boland <gottox@voidlinux.org>"
 license="BSD-3-Clause"
 homepage="https://www.chromium.org/"
 distfiles="https://commondatastorage.googleapis.com/chromium-browser-official/${pkgname}-${version}.tar.xz"
-checksum=ae12e94392986c6b8ea4413356a49bae0a19356ffe2ea95495303cf2decb38c3
+checksum=30411fc3ec2d33df4c5cad41f21affa3823c80f7dbd394f6d68f9a1e81015b81
 nocross=yes
 
 lib32disabled=yes
@@ -182,15 +182,15 @@ do_configure() {
 		'use_system_harfbuzz=true'
 		'enable_widevine=true'
 		'enable_hangout_services_extension=true'
-		'is_desktop_linux=true'
 	)
 
 	conf+=(
 		"use_vaapi=$(vopt_if vaapi true false)"
 	)
 
+	# https://chromium.googlesource.com/chromium/src/+/master/docs/closure_compilation.md
 	conf+=(
-		"closure_compile=$(vopt_if js_optimize true false)"
+		"enable_js_type_check=$(vopt_if js_optimize true false)"
 	)
 
 	conf+=(
@@ -216,9 +216,7 @@ do_configure() {
 
 	# Never use bundled binutils/gold binary.
 	conf+=(
-		"binutils_path=\"${XBPS_CROSS_BASE}/usr/bin\""
 		"gold_path=\"${XBPS_CROSS_BASE}/usr/bin/ld.gold\""
-		'linux_use_bundled_binutils=false'
 		'use_custom_libcxx=false'
 		'use_lld=false'
 	)

From cabf893ca11e2b5680fd4f6dad48eef7d0c720c6 Mon Sep 17 00:00:00 2001
From: Peter Bui <pbui@github.bx612.space>
Date: Wed, 17 Feb 2021 14:17:50 -0500
Subject: [PATCH 2/2] chromium-widevine: update to 88.0.4324.182.

---
 srcpkgs/chromium-widevine/INSTALL  | 2 +-
 srcpkgs/chromium-widevine/template | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/chromium-widevine/INSTALL b/srcpkgs/chromium-widevine/INSTALL
index 703be9f5101..4c9600e6eca 100644
--- a/srcpkgs/chromium-widevine/INSTALL
+++ b/srcpkgs/chromium-widevine/INSTALL
@@ -1,6 +1,6 @@
 # INSTALL
 
-checksum=404f13af1288a824898674e83c42bcdffba098178ff96d266525cd7e2fdcd077
+checksum=ab00e9412f5f20e30c7db5dc987473248f4adf9ebf2c3f928ef62e1ffb104fe6
 _baseUrl="https://dl.google.com/linux/chrome/deb/pool/main/g/google-chrome-stable"
 _filename="google-chrome-stable_${VERSION%_*}-1_amd64.deb"
 DISTFILE="${_baseUrl}/${_filename}"
diff --git a/srcpkgs/chromium-widevine/template b/srcpkgs/chromium-widevine/template
index b54e4b56f39..d7a0587caf5 100644
--- a/srcpkgs/chromium-widevine/template
+++ b/srcpkgs/chromium-widevine/template
@@ -6,7 +6,7 @@ _chromeVersion="current"
 _channel="stable"
 
 pkgname=chromium-widevine
-version=88.0.4324.150
+version=88.0.4324.182
 revision=1
 archs="x86_64"
 create_wrksrc=yes