* Re: [PR REVIEW] New package: droidcam-1.7.1
2021-02-22 12:52 [PR PATCH] New package: droidcam-1.7.1 ibrokemypie
@ 2021-02-22 16:06 ` ericonr
2021-02-22 16:06 ` ericonr
` (14 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: ericonr @ 2021-02-22 16:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 180 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/28972#discussion_r580368972
Comment:
Please break this at ~80 columns.
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PR REVIEW] New package: droidcam-1.7.1
2021-02-22 12:52 [PR PATCH] New package: droidcam-1.7.1 ibrokemypie
2021-02-22 16:06 ` [PR REVIEW] " ericonr
@ 2021-02-22 16:06 ` ericonr
2021-02-22 16:06 ` ericonr
` (13 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: ericonr @ 2021-02-22 16:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 255 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/28972#discussion_r580368797
Comment:
They have a file, use `vsed -e "s/Icon=.*/Icon=droidcam/" -i droidcam.desktop` to fix it up in `post_build`.
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PR REVIEW] New package: droidcam-1.7.1
2021-02-22 12:52 [PR PATCH] New package: droidcam-1.7.1 ibrokemypie
2021-02-22 16:06 ` [PR REVIEW] " ericonr
2021-02-22 16:06 ` ericonr
@ 2021-02-22 16:06 ` ericonr
2021-02-22 16:06 ` ericonr
` (12 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: ericonr @ 2021-02-22 16:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 162 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/28972#discussion_r580369571
Comment:
`JPEG="$(...)"`
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PR REVIEW] New package: droidcam-1.7.1
2021-02-22 12:52 [PR PATCH] New package: droidcam-1.7.1 ibrokemypie
` (2 preceding siblings ...)
2021-02-22 16:06 ` ericonr
@ 2021-02-22 16:06 ` ericonr
2021-02-22 16:06 ` ericonr
` (11 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: ericonr @ 2021-02-22 16:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 167 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/28972#discussion_r580369222
Comment:
Use `droidcam` here.
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PR REVIEW] New package: droidcam-1.7.1
2021-02-22 12:52 [PR PATCH] New package: droidcam-1.7.1 ibrokemypie
` (3 preceding siblings ...)
2021-02-22 16:06 ` ericonr
@ 2021-02-22 16:06 ` ericonr
2021-02-22 16:06 ` ericonr
` (10 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: ericonr @ 2021-02-22 16:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 401 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/28972#discussion_r580372372
Comment:
If possible, it would be nicer to use `make_build_args` instead of `do_build`. You'd need to append to `make_build_args` in `pre_build`, though, since `pkg-config` won't be available before that.
Btw, `JPEG_DIR=""` and `JPEG_DIR=` do the same thing :)
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PR REVIEW] New package: droidcam-1.7.1
2021-02-22 12:52 [PR PATCH] New package: droidcam-1.7.1 ibrokemypie
` (4 preceding siblings ...)
2021-02-22 16:06 ` ericonr
@ 2021-02-22 16:06 ` ericonr
2021-02-22 17:20 ` ericonr
` (9 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: ericonr @ 2021-02-22 16:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 390 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/28972#discussion_r580370182
Comment:
This shouldn't touch `/opt`... I don't see anything that would even use the file. And if it really goes in `/opt`, it should be inside its own directory.
And in this case you can use `droidcam` (preferred) or `${pkgname}`, not `${PKGNAME}`.
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: New package: droidcam-1.7.1
2021-02-22 12:52 [PR PATCH] New package: droidcam-1.7.1 ibrokemypie
` (5 preceding siblings ...)
2021-02-22 16:06 ` ericonr
@ 2021-02-22 17:20 ` ericonr
2021-02-22 17:45 ` [PR REVIEW] " ericonr
` (8 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: ericonr @ 2021-02-22 17:20 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 225 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/28972#issuecomment-783534111
Comment:
For the record, their makefile is very messy. I will try to fix it up with upstream.
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PR REVIEW] New package: droidcam-1.7.1
2021-02-22 12:52 [PR PATCH] New package: droidcam-1.7.1 ibrokemypie
` (6 preceding siblings ...)
2021-02-22 17:20 ` ericonr
@ 2021-02-22 17:45 ` ericonr
2021-02-23 5:38 ` [PR PATCH] [Updated] " ibrokemypie
` (7 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: ericonr @ 2021-02-22 17:45 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 287 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/28972#discussion_r580453244
Comment:
You don't need to define all of those, since only `JPEG` is used in the final commands and you override it by setting it in the commandline.
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PR PATCH] [Updated] New package: droidcam-1.7.1
2021-02-22 12:52 [PR PATCH] New package: droidcam-1.7.1 ibrokemypie
` (7 preceding siblings ...)
2021-02-22 17:45 ` [PR REVIEW] " ericonr
@ 2021-02-23 5:38 ` ibrokemypie
2021-02-23 5:38 ` ibrokemypie
` (6 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: ibrokemypie @ 2021-02-23 5:38 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1645 bytes --]
There is an updated pull request by ibrokemypie against master on the void-packages repository
https://github.com/ibrokemypie/void-packages add_droidcam
https://github.com/void-linux/void-packages/pull/28972
New package: droidcam-1.7.1
<!-- Mark items with [x] where applicable -->
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [X] I built this PR locally for my native architecture, (ARCH-LIBC)
- [] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
tried armv7l and it failed to build
-->
A patch file from https://github.com/void-linux/void-packages/pull/28972.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-add_droidcam-28972.patch --]
[-- Type: text/x-diff, Size: 2205 bytes --]
From 6be32ca69772a67c8097beb3c1c4ac479e148a97 Mon Sep 17 00:00:00 2001
From: ibrokemypie <ibrokemypie@bastardi.net>
Date: Mon, 22 Feb 2021 23:45:17 +1100
Subject: [PATCH] New package: droidcam-1.7.1
---
srcpkgs/droidcam/files/droidcam.desktop | 10 ++++++++
srcpkgs/droidcam/template | 33 +++++++++++++++++++++++++
2 files changed, 43 insertions(+)
create mode 100644 srcpkgs/droidcam/files/droidcam.desktop
create mode 100644 srcpkgs/droidcam/template
diff --git a/srcpkgs/droidcam/files/droidcam.desktop b/srcpkgs/droidcam/files/droidcam.desktop
new file mode 100644
index 00000000000..b180df821a4
--- /dev/null
+++ b/srcpkgs/droidcam/files/droidcam.desktop
@@ -0,0 +1,10 @@
+[Desktop Entry]
+Encoding=UTF-8
+Version=3.2.1
+Name=Droidcam
+Type=Application
+Exec=droidcam
+Icon=droidcam
+Categories=GNOME;AudioVideo;
+Comment=A tool for using your Android phone as a wireless/usb webcam
+
diff --git a/srcpkgs/droidcam/template b/srcpkgs/droidcam/template
new file mode 100644
index 00000000000..204f56e746c
--- /dev/null
+++ b/srcpkgs/droidcam/template
@@ -0,0 +1,33 @@
+# Template file for 'droidcam'
+pkgname=droidcam
+version=1.7.1
+revision=1
+makedepends="pkg-config libjpeg-turbo-devel ffmpeg-devel alsa-lib-devel speex-devel \
+ libusbmuxd-devel libplist-devel gtk+3-devel"
+depends="v4l2loopback"
+short_desc="Tool for using your android device as a wireless/usb webcam"
+maintainer="ibrokemypie <ibrokemypie@bastardi.net>"
+license="GPL-2.0-or-later"
+homepage="https://github.com/dev47apps/droidcam"
+distfiles="https://github.com/dev47apps/${pkgname}/archive/v${version}.tar.gz"
+checksum="1f925c093df165afcd39e76b12a3db0f19fabbf15a11e1c7b55a97bba331f113"
+nopie=true
+make_build_args="USBMUXD=-lusbmuxd-2.0"
+build_style="gnu-makefile"
+
+pre_build() {
+ make_build_args="${make_build_args} JPEG=$(pkg-config --libs --cflags libturbojpeg)"
+}
+
+post_build() {
+ vsed -e "s/Icon=.*/Icon=droidcam/" -i droidcam.desktop
+}
+
+do_install() {
+ vbin droidcam
+ vbin droidcam-cli
+ vinstall icon2.png 644 /usr/share/pixmaps/ droidcam.png
+ vinstall icon2.png 644 /opt/ droidcam-icon.png
+ vinstall ${FILESDIR}/droidcam.desktop 644 /usr/share/applications/
+ vdoc README.md
+}
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PR PATCH] [Updated] New package: droidcam-1.7.1
2021-02-22 12:52 [PR PATCH] New package: droidcam-1.7.1 ibrokemypie
` (8 preceding siblings ...)
2021-02-23 5:38 ` [PR PATCH] [Updated] " ibrokemypie
@ 2021-02-23 5:38 ` ibrokemypie
2021-02-23 5:40 ` [PR REVIEW] " ibrokemypie
` (5 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: ibrokemypie @ 2021-02-23 5:38 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1645 bytes --]
There is an updated pull request by ibrokemypie against master on the void-packages repository
https://github.com/ibrokemypie/void-packages add_droidcam
https://github.com/void-linux/void-packages/pull/28972
New package: droidcam-1.7.1
<!-- Mark items with [x] where applicable -->
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [X] I built this PR locally for my native architecture, (ARCH-LIBC)
- [] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
tried armv7l and it failed to build
-->
A patch file from https://github.com/void-linux/void-packages/pull/28972.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-add_droidcam-28972.patch --]
[-- Type: text/x-diff, Size: 2203 bytes --]
From e42f69d8f92c5da80fd7355020e86e6996f09074 Mon Sep 17 00:00:00 2001
From: ibrokemypie <ibrokemypie@bastardi.net>
Date: Mon, 22 Feb 2021 23:45:17 +1100
Subject: [PATCH] New package: droidcam-1.7.1
---
srcpkgs/droidcam/files/droidcam.desktop | 10 ++++++++
srcpkgs/droidcam/template | 33 +++++++++++++++++++++++++
2 files changed, 43 insertions(+)
create mode 100644 srcpkgs/droidcam/files/droidcam.desktop
create mode 100644 srcpkgs/droidcam/template
diff --git a/srcpkgs/droidcam/files/droidcam.desktop b/srcpkgs/droidcam/files/droidcam.desktop
new file mode 100644
index 00000000000..b180df821a4
--- /dev/null
+++ b/srcpkgs/droidcam/files/droidcam.desktop
@@ -0,0 +1,10 @@
+[Desktop Entry]
+Encoding=UTF-8
+Version=3.2.1
+Name=Droidcam
+Type=Application
+Exec=droidcam
+Icon=droidcam
+Categories=GNOME;AudioVideo;
+Comment=A tool for using your Android phone as a wireless/usb webcam
+
diff --git a/srcpkgs/droidcam/template b/srcpkgs/droidcam/template
new file mode 100644
index 00000000000..c9cc08e23ce
--- /dev/null
+++ b/srcpkgs/droidcam/template
@@ -0,0 +1,33 @@
+# Template file for 'droidcam'
+pkgname=droidcam
+version=1.7.1
+revision=1
+makedepends="pkg-config libjpeg-turbo-devel ffmpeg-devel alsa-lib-devel speex-devel \
+ libusbmuxd-devel libplist-devel gtk+3-devel"
+depends="v4l2loopback"
+short_desc="Tool for using your android device as a wireless/usb webcam"
+maintainer="ibrokemypie <ibrokemypie@bastardi.net>"
+license="GPL-2.0-or-later"
+homepage="https://github.com/dev47apps/droidcam"
+distfiles="https://github.com/dev47apps/droidcam/archive/v${version}.tar.gz"
+checksum="1f925c093df165afcd39e76b12a3db0f19fabbf15a11e1c7b55a97bba331f113"
+nopie=true
+make_build_args="USBMUXD=-lusbmuxd-2.0"
+build_style="gnu-makefile"
+
+pre_build() {
+ make_build_args="${make_build_args} JPEG=$(pkg-config --libs --cflags libturbojpeg)"
+}
+
+post_build() {
+ vsed -e "s/Icon=.*/Icon=droidcam/" -i droidcam.desktop
+}
+
+do_install() {
+ vbin droidcam
+ vbin droidcam-cli
+ vinstall icon2.png 644 /usr/share/pixmaps/ droidcam.png
+ vinstall icon2.png 644 /opt/ droidcam-icon.png
+ vinstall ${FILESDIR}/droidcam.desktop 644 /usr/share/applications/
+ vdoc README.md
+}
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PR REVIEW] New package: droidcam-1.7.1
2021-02-22 12:52 [PR PATCH] New package: droidcam-1.7.1 ibrokemypie
` (9 preceding siblings ...)
2021-02-23 5:38 ` ibrokemypie
@ 2021-02-23 5:40 ` ibrokemypie
2021-02-23 5:54 ` [PR PATCH] [Updated] " ibrokemypie
` (4 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: ibrokemypie @ 2021-02-23 5:40 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1020 bytes --]
New review comment by ibrokemypie on void-packages repository
https://github.com/void-linux/void-packages/pull/28972#discussion_r580780457
Comment:
Using the gnu-makefile build style fails building with this:
```
g++ cc src/droidcam-cli.c src/connection.c src/settings.c src/decoder.c src/decoder_snd.c src/decoder_v4l2.c src/av.c src/usb.c -lturbojpeg `pkg-config --libs --cflags libswscale libavutil` -lspeex -lasound -lpthread -lm -lusbmuxd-2.0 -o droidcam-cli
g++: error: cc: No such file or directory
make: *** [Makefile:42: droidcam-cli] Error 1
=> ERROR: droidcam-1.7.1_1: do_build: '${make_cmd} CC="$CC" CXX="$CXX" LD="$LD" AR="$AR" RANLIB="$RANLIB" CPP="$CPP" AS="$AS" OBJCOPY="$OBJCOPY" OBJDUMP="$OBJDUMP" CFLAGS="$CFLAGS" CXXFLAGS="$CXXFLAGS" LDFLAGS="$LDFLAGS" ${makejobs} ${make_build_args} ${make_build_target}' exited with 2
=> ERROR: in do_build() at common/build-style/gnu-makefile.sh:9
```
I have no idea where its getting "g++ cc" from though, cc isnt mentioned in the upstream makefile
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PR PATCH] [Updated] New package: droidcam-1.7.1
2021-02-22 12:52 [PR PATCH] New package: droidcam-1.7.1 ibrokemypie
` (10 preceding siblings ...)
2021-02-23 5:40 ` [PR REVIEW] " ibrokemypie
@ 2021-02-23 5:54 ` ibrokemypie
2021-02-23 5:58 ` ibrokemypie
` (3 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: ibrokemypie @ 2021-02-23 5:54 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1645 bytes --]
There is an updated pull request by ibrokemypie against master on the void-packages repository
https://github.com/ibrokemypie/void-packages add_droidcam
https://github.com/void-linux/void-packages/pull/28972
New package: droidcam-1.7.1
<!-- Mark items with [x] where applicable -->
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [X] I built this PR locally for my native architecture, (ARCH-LIBC)
- [] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
tried armv7l and it failed to build
-->
A patch file from https://github.com/void-linux/void-packages/pull/28972.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-add_droidcam-28972.patch --]
[-- Type: text/x-diff, Size: 2248 bytes --]
From 7bf3a106e626f76b0390c9e83fcf9d06ed1097e7 Mon Sep 17 00:00:00 2001
From: ibrokemypie <ibrokemypie@bastardi.net>
Date: Mon, 22 Feb 2021 23:45:17 +1100
Subject: [PATCH] New package: droidcam-1.7.1
---
srcpkgs/droidcam/files/droidcam.desktop | 10 +++++++
srcpkgs/droidcam/template | 37 +++++++++++++++++++++++++
2 files changed, 47 insertions(+)
create mode 100644 srcpkgs/droidcam/files/droidcam.desktop
create mode 100644 srcpkgs/droidcam/template
diff --git a/srcpkgs/droidcam/files/droidcam.desktop b/srcpkgs/droidcam/files/droidcam.desktop
new file mode 100644
index 00000000000..b180df821a4
--- /dev/null
+++ b/srcpkgs/droidcam/files/droidcam.desktop
@@ -0,0 +1,10 @@
+[Desktop Entry]
+Encoding=UTF-8
+Version=3.2.1
+Name=Droidcam
+Type=Application
+Exec=droidcam
+Icon=droidcam
+Categories=GNOME;AudioVideo;
+Comment=A tool for using your Android phone as a wireless/usb webcam
+
diff --git a/srcpkgs/droidcam/template b/srcpkgs/droidcam/template
new file mode 100644
index 00000000000..db7b946aba9
--- /dev/null
+++ b/srcpkgs/droidcam/template
@@ -0,0 +1,37 @@
+# Template file for 'droidcam'
+pkgname=droidcam
+version=1.7.1
+revision=1
+makedepends="pkg-config libjpeg-turbo-devel ffmpeg-devel alsa-lib-devel speex-devel \
+ libusbmuxd-devel libplist-devel gtk+3-devel"
+depends="v4l2loopback"
+short_desc="Tool for using your android device as a wireless/usb webcam"
+maintainer="ibrokemypie <ibrokemypie@bastardi.net>"
+license="GPL-2.0-or-later"
+homepage="https://github.com/dev47apps/droidcam"
+distfiles="https://github.com/dev47apps/droidcam/archive/v${version}.tar.gz"
+checksum="1f925c093df165afcd39e76b12a3db0f19fabbf15a11e1c7b55a97bba331f113"
+nopie=true
+make_build_args="USBMUXD=-lusbmuxd-2.0"
+#build_style="gnu-makefile"
+
+pre_build() {
+ make_build_args="${make_build_args} JPEG=$(pkg-config --libs --cflags libturbojpeg)"
+}
+
+do_build() {
+ make ${make_build_args}
+}
+
+post_build() {
+ vsed -e "s/Icon=.*/Icon=droidcam/" -i droidcam.desktop
+}
+
+do_install() {
+ vbin droidcam
+ vbin droidcam-cli
+ vinstall icon2.png 644 /usr/share/pixmaps/ droidcam.png
+ vinstall icon2.png 644 /opt/ droidcam-icon.png
+ vinstall ${FILESDIR}/droidcam.desktop 644 /usr/share/applications/
+ vdoc README.md
+}
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PR PATCH] [Updated] New package: droidcam-1.7.1
2021-02-22 12:52 [PR PATCH] New package: droidcam-1.7.1 ibrokemypie
` (11 preceding siblings ...)
2021-02-23 5:54 ` [PR PATCH] [Updated] " ibrokemypie
@ 2021-02-23 5:58 ` ibrokemypie
2021-02-23 5:58 ` ibrokemypie
` (2 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: ibrokemypie @ 2021-02-23 5:58 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1645 bytes --]
There is an updated pull request by ibrokemypie against master on the void-packages repository
https://github.com/ibrokemypie/void-packages add_droidcam
https://github.com/void-linux/void-packages/pull/28972
New package: droidcam-1.7.1
<!-- Mark items with [x] where applicable -->
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [X] I built this PR locally for my native architecture, (ARCH-LIBC)
- [] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
tried armv7l and it failed to build
-->
A patch file from https://github.com/void-linux/void-packages/pull/28972.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-add_droidcam-28972.patch --]
[-- Type: text/x-diff, Size: 2248 bytes --]
From ed64f78e812eb1dbafd093e8f20390c0189ab0ae Mon Sep 17 00:00:00 2001
From: ibrokemypie <ibrokemypie@bastardi.net>
Date: Mon, 22 Feb 2021 23:45:17 +1100
Subject: [PATCH] New package: droidcam-1.7.1
---
srcpkgs/droidcam/files/droidcam.desktop | 10 +++++++
srcpkgs/droidcam/template | 37 +++++++++++++++++++++++++
2 files changed, 47 insertions(+)
create mode 100644 srcpkgs/droidcam/files/droidcam.desktop
create mode 100644 srcpkgs/droidcam/template
diff --git a/srcpkgs/droidcam/files/droidcam.desktop b/srcpkgs/droidcam/files/droidcam.desktop
new file mode 100644
index 00000000000..b180df821a4
--- /dev/null
+++ b/srcpkgs/droidcam/files/droidcam.desktop
@@ -0,0 +1,10 @@
+[Desktop Entry]
+Encoding=UTF-8
+Version=3.2.1
+Name=Droidcam
+Type=Application
+Exec=droidcam
+Icon=droidcam
+Categories=GNOME;AudioVideo;
+Comment=A tool for using your Android phone as a wireless/usb webcam
+
diff --git a/srcpkgs/droidcam/template b/srcpkgs/droidcam/template
new file mode 100644
index 00000000000..db7b946aba9
--- /dev/null
+++ b/srcpkgs/droidcam/template
@@ -0,0 +1,37 @@
+# Template file for 'droidcam'
+pkgname=droidcam
+version=1.7.1
+revision=1
+makedepends="pkg-config libjpeg-turbo-devel ffmpeg-devel alsa-lib-devel speex-devel \
+ libusbmuxd-devel libplist-devel gtk+3-devel"
+depends="v4l2loopback"
+short_desc="Tool for using your android device as a wireless/usb webcam"
+maintainer="ibrokemypie <ibrokemypie@bastardi.net>"
+license="GPL-2.0-or-later"
+homepage="https://github.com/dev47apps/droidcam"
+distfiles="https://github.com/dev47apps/droidcam/archive/v${version}.tar.gz"
+checksum="1f925c093df165afcd39e76b12a3db0f19fabbf15a11e1c7b55a97bba331f113"
+nopie=true
+make_build_args="USBMUXD=-lusbmuxd-2.0"
+#build_style="gnu-makefile"
+
+pre_build() {
+ make_build_args="${make_build_args} JPEG=$(pkg-config --libs --cflags libturbojpeg)"
+}
+
+do_build() {
+ make ${make_build_args}
+}
+
+post_build() {
+ vsed -e "s/Icon=.*/Icon=droidcam/" -i droidcam.desktop
+}
+
+do_install() {
+ vbin droidcam
+ vbin droidcam-cli
+ vinstall icon2.png 644 /usr/share/pixmaps/ droidcam.png
+ vinstall icon2.png 644 /opt/ droidcam-icon.png
+ vinstall ${FILESDIR}/droidcam.desktop 644 /usr/share/applications/
+ vdoc README.md
+}
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PR PATCH] [Updated] New package: droidcam-1.7.1
2021-02-22 12:52 [PR PATCH] New package: droidcam-1.7.1 ibrokemypie
` (12 preceding siblings ...)
2021-02-23 5:58 ` ibrokemypie
@ 2021-02-23 5:58 ` ibrokemypie
2021-02-23 6:32 ` [PR REVIEW] " ericonr
2021-03-23 17:43 ` [PR PATCH] [Closed]: " ericonr
15 siblings, 0 replies; 17+ messages in thread
From: ibrokemypie @ 2021-02-23 5:58 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1645 bytes --]
There is an updated pull request by ibrokemypie against master on the void-packages repository
https://github.com/ibrokemypie/void-packages add_droidcam
https://github.com/void-linux/void-packages/pull/28972
New package: droidcam-1.7.1
<!-- Mark items with [x] where applicable -->
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [X] I built this PR locally for my native architecture, (ARCH-LIBC)
- [] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
tried armv7l and it failed to build
-->
A patch file from https://github.com/void-linux/void-packages/pull/28972.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-add_droidcam-28972.patch --]
[-- Type: text/x-diff, Size: 2256 bytes --]
From 2479f08cdc4e75846646e82eab7f1393be4bf5d8 Mon Sep 17 00:00:00 2001
From: ibrokemypie <ibrokemypie@bastardi.net>
Date: Mon, 22 Feb 2021 23:45:17 +1100
Subject: [PATCH] New package: droidcam-1.7.1
---
srcpkgs/droidcam/files/droidcam.desktop | 10 +++++++
srcpkgs/droidcam/template | 38 +++++++++++++++++++++++++
2 files changed, 48 insertions(+)
create mode 100644 srcpkgs/droidcam/files/droidcam.desktop
create mode 100644 srcpkgs/droidcam/template
diff --git a/srcpkgs/droidcam/files/droidcam.desktop b/srcpkgs/droidcam/files/droidcam.desktop
new file mode 100644
index 00000000000..b180df821a4
--- /dev/null
+++ b/srcpkgs/droidcam/files/droidcam.desktop
@@ -0,0 +1,10 @@
+[Desktop Entry]
+Encoding=UTF-8
+Version=3.2.1
+Name=Droidcam
+Type=Application
+Exec=droidcam
+Icon=droidcam
+Categories=GNOME;AudioVideo;
+Comment=A tool for using your Android phone as a wireless/usb webcam
+
diff --git a/srcpkgs/droidcam/template b/srcpkgs/droidcam/template
new file mode 100644
index 00000000000..0fbb7885ba7
--- /dev/null
+++ b/srcpkgs/droidcam/template
@@ -0,0 +1,38 @@
+# Template file for 'droidcam'
+pkgname=droidcam
+version=1.7.1
+revision=1
+make_build_args="USBMUXD=-lusbmuxd-2.0"
+makedepends="pkg-config libjpeg-turbo-devel ffmpeg-devel alsa-lib-devel \
+ speex-devel libusbmuxd-devel libplist-devel gtk+3-devel"
+depends="v4l2loopback"
+short_desc="Tool for using your android device as a wireless/usb webcam"
+maintainer="ibrokemypie <ibrokemypie@bastardi.net>"
+license="GPL-2.0-or-later"
+homepage="https://github.com/dev47apps/droidcam"
+distfiles="https://github.com/dev47apps/droidcam/archive/v${version}.tar.gz"
+checksum="1f925c093df165afcd39e76b12a3db0f19fabbf15a11e1c7b55a97bba331f113"
+nopie=true
+#build_style="gnu-makefile"
+
+pre_build() {
+ make_build_args="${make_build_args} \
+ JPEG=$(pkg-config --libs --cflags libturbojpeg)"
+}
+
+do_build() {
+ make ${make_build_args}
+}
+
+post_build() {
+ vsed -e "s/Icon=.*/Icon=droidcam/" -i droidcam.desktop
+}
+
+do_install() {
+ vbin droidcam
+ vbin droidcam-cli
+ vinstall icon2.png 644 /usr/share/pixmaps/ droidcam.png
+ vinstall icon2.png 644 /opt/ droidcam-icon.png
+ vinstall ${FILESDIR}/droidcam.desktop 644 /usr/share/applications/
+ vdoc README.md
+}
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PR REVIEW] New package: droidcam-1.7.1
2021-02-22 12:52 [PR PATCH] New package: droidcam-1.7.1 ibrokemypie
` (13 preceding siblings ...)
2021-02-23 5:58 ` ibrokemypie
@ 2021-02-23 6:32 ` ericonr
2021-03-23 17:43 ` [PR PATCH] [Closed]: " ericonr
15 siblings, 0 replies; 17+ messages in thread
From: ericonr @ 2021-02-23 6:32 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 244 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/28972#discussion_r580796009
Comment:
Apply https://github.com/dev47apps/droidcam/pull/146 as a patch, it should just work for us then.
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PR PATCH] [Closed]: New package: droidcam-1.7.1
2021-02-22 12:52 [PR PATCH] New package: droidcam-1.7.1 ibrokemypie
` (14 preceding siblings ...)
2021-02-23 6:32 ` [PR REVIEW] " ericonr
@ 2021-03-23 17:43 ` ericonr
15 siblings, 0 replies; 17+ messages in thread
From: ericonr @ 2021-03-23 17:43 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1476 bytes --]
There's a closed pull request on the void-packages repository
New package: droidcam-1.7.1
https://github.com/void-linux/void-packages/pull/28972
Description:
<!-- Mark items with [x] where applicable -->
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [X] I built this PR locally for my native architecture, (ARCH-LIBC)
- [] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
tried armv7l and it failed to build
-->
^ permalink raw reply [flat|nested] 17+ messages in thread