Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] common/gnu-configure-args: set exec_prefix to ${prefix}
@ 2021-02-23 13:08 sgn
  2021-02-23 13:11 ` sgn
                   ` (6 more replies)
  0 siblings, 7 replies; 8+ messages in thread
From: sgn @ 2021-02-23 13:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1823 bytes --]

There is a new pull request by sgn against master on the void-packages repository

https://github.com/sgn/void-packages gnu-configure-set-exec-prefix
https://github.com/void-linux/void-packages/pull/28996

common/gnu-configure-args: set exec_prefix to ${prefix}
autotools will pass its configure_args to subdir if required,
if we don't init exec_prefix, it will pass --libdir=NONE/lib{32,64} to
subdir configure.

---

Found when fixing openmpi

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28996.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gnu-configure-set-exec-prefix-28996.patch --]
[-- Type: text/x-diff, Size: 1221 bytes --]

From 66aa43f9d35e90c2be8a226d57f30caa7a31f20b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
 <congdanhqx@gmail.com>
Date: Tue, 23 Feb 2021 20:05:17 +0700
Subject: [PATCH] common/gnu-configure-args: set exec_prefix to ${prefix}

autotools will pass its configure_args to subdir if required,
if we don't init exec_prefix, it will pass --libdir=NONE/lib{32,64} to
subdir configure.
---
 common/environment/configure/gnu-configure-args.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/common/environment/configure/gnu-configure-args.sh b/common/environment/configure/gnu-configure-args.sh
index dafbf5dc110..c3ab67a7855 100644
--- a/common/environment/configure/gnu-configure-args.sh
+++ b/common/environment/configure/gnu-configure-args.sh
@@ -18,6 +18,7 @@ export configure_args+=" --host=$XBPS_TRIPLET --build=$XBPS_TRIPLET"
 # This is to make sure 32-bit and 64-bit libs can coexist when looking
 # up things (the opposite-libdir is always symlinked as libNN)
 export configure_args+=" --libdir=\${exec_prefix}/lib${XBPS_TARGET_WORDSIZE}"
+export configure_args+=" --exec-prefix=\${prefix}"
 
 _AUTOCONFCACHEDIR=${XBPS_COMMONDIR}/environment/configure/autoconf_cache
 

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: common/gnu-configure-args: set exec_prefix to ${prefix}
  2021-02-23 13:08 [PR PATCH] common/gnu-configure-args: set exec_prefix to ${prefix} sgn
@ 2021-02-23 13:11 ` sgn
  2021-02-23 13:16 ` [PR PATCH] [Updated] " sgn
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: sgn @ 2021-02-23 13:11 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 220 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/28996#issuecomment-784192560

Comment:
@ahesford And I think we can add `libevent-devel` into `makedepends` for `openmpi`?

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Updated] common/gnu-configure-args: set exec_prefix to ${prefix}
  2021-02-23 13:08 [PR PATCH] common/gnu-configure-args: set exec_prefix to ${prefix} sgn
  2021-02-23 13:11 ` sgn
@ 2021-02-23 13:16 ` sgn
  2021-02-23 13:21 ` sgn
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: sgn @ 2021-02-23 13:16 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1828 bytes --]

There is an updated pull request by sgn against master on the void-packages repository

https://github.com/sgn/void-packages gnu-configure-set-exec-prefix
https://github.com/void-linux/void-packages/pull/28996

common/gnu-configure-args: set exec_prefix to ${prefix}
autotools will pass its configure_args to subdir if required,
if we don't init exec_prefix, it will pass --libdir=NONE/lib{32,64} to
subdir configure.

---

Found when fixing openmpi

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28996.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gnu-configure-set-exec-prefix-28996.patch --]
[-- Type: text/x-diff, Size: 2102 bytes --]

From 66aa43f9d35e90c2be8a226d57f30caa7a31f20b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
 <congdanhqx@gmail.com>
Date: Tue, 23 Feb 2021 20:05:17 +0700
Subject: [PATCH 1/2] common/gnu-configure-args: set exec_prefix to ${prefix}

autotools will pass its configure_args to subdir if required,
if we don't init exec_prefix, it will pass --libdir=NONE/lib{32,64} to
subdir configure.
---
 common/environment/configure/gnu-configure-args.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/common/environment/configure/gnu-configure-args.sh b/common/environment/configure/gnu-configure-args.sh
index dafbf5dc110..c3ab67a7855 100644
--- a/common/environment/configure/gnu-configure-args.sh
+++ b/common/environment/configure/gnu-configure-args.sh
@@ -18,6 +18,7 @@ export configure_args+=" --host=$XBPS_TRIPLET --build=$XBPS_TRIPLET"
 # This is to make sure 32-bit and 64-bit libs can coexist when looking
 # up things (the opposite-libdir is always symlinked as libNN)
 export configure_args+=" --libdir=\${exec_prefix}/lib${XBPS_TARGET_WORDSIZE}"
+export configure_args+=" --exec-prefix=\${prefix}"
 
 _AUTOCONFCACHEDIR=${XBPS_COMMONDIR}/environment/configure/autoconf_cache
 

From f62d18623abc89c390bf6cc806a78c9afcbc241a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
 <congdanhqx@gmail.com>
Date: Tue, 23 Feb 2021 20:15:14 +0700
Subject: [PATCH 2/2] openmpi: hostmakedepends+=pkg-config

---
 srcpkgs/openmpi/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/openmpi/template b/srcpkgs/openmpi/template
index f8ef1ef0779..6fbf3611328 100644
--- a/srcpkgs/openmpi/template
+++ b/srcpkgs/openmpi/template
@@ -4,7 +4,7 @@ version=4.1.0
 revision=1
 build_style=gnu-configure
 configure_args="--enable-ipv6 --with-hwloc=${XBPS_CROSS_BASE}/usr"
-hostmakedepends="gcc-fortran libgomp-devel perl"
+hostmakedepends="gcc-fortran libgomp-devel perl pkg-config"
 makedepends="libgfortran-devel libgomp-devel libhwloc-devel zlib-devel"
 conf_files="
  /etc/openmpi-default-hostfile

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: common/gnu-configure-args: set exec_prefix to ${prefix}
  2021-02-23 13:08 [PR PATCH] common/gnu-configure-args: set exec_prefix to ${prefix} sgn
  2021-02-23 13:11 ` sgn
  2021-02-23 13:16 ` [PR PATCH] [Updated] " sgn
@ 2021-02-23 13:21 ` sgn
  2021-02-23 14:49 ` ahesford
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: sgn @ 2021-02-23 13:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 204 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/28996#issuecomment-784198843

Comment:
Anyway, is it correct to move `ompi_monitoring_prof.so` to `-devel`

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: common/gnu-configure-args: set exec_prefix to ${prefix}
  2021-02-23 13:08 [PR PATCH] common/gnu-configure-args: set exec_prefix to ${prefix} sgn
                   ` (2 preceding siblings ...)
  2021-02-23 13:21 ` sgn
@ 2021-02-23 14:49 ` ahesford
  2021-02-23 14:59 ` [PR PATCH] [Updated] " sgn
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: ahesford @ 2021-02-23 14:49 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 657 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/28996#issuecomment-784255185

Comment:
Yes to adding `libevent-devel` to `makedepends`.

The `ompi_monitoring_prof.so` library is not intended for linking; it is [supposed to be used with LD_PRELOAD](https://github.com/open-mpi/ompi/blob/master/ompi/mca/common/monitoring/monitoring_prof.c#L30-L33). I recommend 
```bash
mv "${DESTDIR}/usr/lib/ompi_monitoring_prof.so" "${DESTDIR}/usr/lib/openmpi"
```
in `post_install` to keep this library out of `/usr/lib` but make it available to those interested in profiling without requiring `openmpi-devel`.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Updated] common/gnu-configure-args: set exec_prefix to ${prefix}
  2021-02-23 13:08 [PR PATCH] common/gnu-configure-args: set exec_prefix to ${prefix} sgn
                   ` (3 preceding siblings ...)
  2021-02-23 14:49 ` ahesford
@ 2021-02-23 14:59 ` sgn
  2021-02-24 11:31 ` sgn
  2021-02-24 11:31 ` [PR PATCH] [Merged]: " sgn
  6 siblings, 0 replies; 8+ messages in thread
From: sgn @ 2021-02-23 14:59 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1828 bytes --]

There is an updated pull request by sgn against master on the void-packages repository

https://github.com/sgn/void-packages gnu-configure-set-exec-prefix
https://github.com/void-linux/void-packages/pull/28996

common/gnu-configure-args: set exec_prefix to ${prefix}
autotools will pass its configure_args to subdir if required,
if we don't init exec_prefix, it will pass --libdir=NONE/lib{32,64} to
subdir configure.

---

Found when fixing openmpi

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28996.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gnu-configure-set-exec-prefix-28996.patch --]
[-- Type: text/x-diff, Size: 2664 bytes --]

From 66aa43f9d35e90c2be8a226d57f30caa7a31f20b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
 <congdanhqx@gmail.com>
Date: Tue, 23 Feb 2021 20:05:17 +0700
Subject: [PATCH 1/2] common/gnu-configure-args: set exec_prefix to ${prefix}

autotools will pass its configure_args to subdir if required,
if we don't init exec_prefix, it will pass --libdir=NONE/lib{32,64} to
subdir configure.
---
 common/environment/configure/gnu-configure-args.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/common/environment/configure/gnu-configure-args.sh b/common/environment/configure/gnu-configure-args.sh
index dafbf5dc110..c3ab67a7855 100644
--- a/common/environment/configure/gnu-configure-args.sh
+++ b/common/environment/configure/gnu-configure-args.sh
@@ -18,6 +18,7 @@ export configure_args+=" --host=$XBPS_TRIPLET --build=$XBPS_TRIPLET"
 # This is to make sure 32-bit and 64-bit libs can coexist when looking
 # up things (the opposite-libdir is always symlinked as libNN)
 export configure_args+=" --libdir=\${exec_prefix}/lib${XBPS_TARGET_WORDSIZE}"
+export configure_args+=" --exec-prefix=\${prefix}"
 
 _AUTOCONFCACHEDIR=${XBPS_COMMONDIR}/environment/configure/autoconf_cache
 

From 7f5d1575768af871c22decf1a911bb71fc8a0442 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
 <congdanhqx@gmail.com>
Date: Tue, 23 Feb 2021 20:15:14 +0700
Subject: [PATCH 2/2] openmpi: un-bundle libevent

While we're at it, move:
	/usr/lib/ompi_monitoring_prof.so

back to main package and put inside /usr/lib/openmpi
---
 srcpkgs/openmpi/template | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/openmpi/template b/srcpkgs/openmpi/template
index f8ef1ef0779..5f962b4fd38 100644
--- a/srcpkgs/openmpi/template
+++ b/srcpkgs/openmpi/template
@@ -1,11 +1,12 @@
 # Template file for 'openmpi'
 pkgname=openmpi
 version=4.1.0
-revision=1
+revision=2
 build_style=gnu-configure
 configure_args="--enable-ipv6 --with-hwloc=${XBPS_CROSS_BASE}/usr"
-hostmakedepends="gcc-fortran libgomp-devel perl"
-makedepends="libgfortran-devel libgomp-devel libhwloc-devel zlib-devel"
+hostmakedepends="gcc-fortran libgomp-devel perl pkg-config"
+makedepends="libgfortran-devel libgomp-devel libhwloc-devel zlib-devel
+ libevent-devel"
 conf_files="
  /etc/openmpi-default-hostfile
  /etc/openmpi-mca-params.conf
@@ -42,6 +43,8 @@ pre_configure() {
 
 post_install() {
 	vlicense LICENSE
+	# https://github.com/void-linux/void-packages/pull/28996#issuecomment-784255185
+	mv "${DESTDIR}/usr/lib/ompi_monitoring_prof.so" "${DESTDIR}/usr/lib/openmpi"
 }
 
 libopenmpi_package() {

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: common/gnu-configure-args: set exec_prefix to ${prefix}
  2021-02-23 13:08 [PR PATCH] common/gnu-configure-args: set exec_prefix to ${prefix} sgn
                   ` (4 preceding siblings ...)
  2021-02-23 14:59 ` [PR PATCH] [Updated] " sgn
@ 2021-02-24 11:31 ` sgn
  2021-02-24 11:31 ` [PR PATCH] [Merged]: " sgn
  6 siblings, 0 replies; 8+ messages in thread
From: sgn @ 2021-02-24 11:31 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 311 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/28996#issuecomment-785012622

Comment:
`--exec-prefix` is defaulted to `$prefix` anyway and `--prefix` has been set, I think most case should be covered, let's fix it later if anything arise, merging now.
Thanks.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Merged]: common/gnu-configure-args: set exec_prefix to ${prefix}
  2021-02-23 13:08 [PR PATCH] common/gnu-configure-args: set exec_prefix to ${prefix} sgn
                   ` (5 preceding siblings ...)
  2021-02-24 11:31 ` sgn
@ 2021-02-24 11:31 ` sgn
  6 siblings, 0 replies; 8+ messages in thread
From: sgn @ 2021-02-24 11:31 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1658 bytes --]

There's a merged pull request on the void-packages repository

common/gnu-configure-args: set exec_prefix to ${prefix}
https://github.com/void-linux/void-packages/pull/28996

Description:
autotools will pass its configure_args to subdir if required,
if we don't init exec_prefix, it will pass --libdir=NONE/lib{32,64} to
subdir configure.

---

Found when fixing openmpi

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2021-02-24 11:31 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-23 13:08 [PR PATCH] common/gnu-configure-args: set exec_prefix to ${prefix} sgn
2021-02-23 13:11 ` sgn
2021-02-23 13:16 ` [PR PATCH] [Updated] " sgn
2021-02-23 13:21 ` sgn
2021-02-23 14:49 ` ahesford
2021-02-23 14:59 ` [PR PATCH] [Updated] " sgn
2021-02-24 11:31 ` sgn
2021-02-24 11:31 ` [PR PATCH] [Merged]: " sgn

Github messages for voidlinux

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.vuxu.org/voidlinux-github

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 voidlinux-github voidlinux-github/ http://inbox.vuxu.org/voidlinux-github \
		voidlinux-github@inbox.vuxu.org
	public-inbox-index voidlinux-github

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.github.voidlinux


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git