Github messages for voidlinux
 help / color / mirror / Atom feed
From: heliocat <heliocat@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] deadbeef: update to 1.8.7 and fix build
Date: Tue, 23 Feb 2021 23:06:34 +0100	[thread overview]
Message-ID: <20210223220634._NVZGXJ-QehBi4nuCgPt--215pDoj3BZJE1uQZHV-og@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-28965@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 333 bytes --]

New review comment by heliocat on void-packages repository

https://github.com/void-linux/void-packages/pull/28965#discussion_r581421725

Comment:
Yeah, all from upstream. I generated the patch from the ```missing``` file dropped by intltoolize. I'm hesitant to comment just because it should be fairly obvious what's going on here.

  parent reply	other threads:[~2021-02-23 22:06 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-22  2:44 [PR PATCH] " heliocat
2021-02-22  9:09 ` ericonr
2021-02-22 20:03 ` [PR PATCH] [Updated] " heliocat
2021-02-22 20:23 ` heliocat
2021-02-23 18:27 ` [PR PATCH] [Updated] " heliocat
2021-02-23 18:39 ` heliocat
2021-02-23 19:06 ` [PR PATCH] [Updated] " heliocat
2021-02-23 19:14 ` [PR REVIEW] " ericonr
2021-02-23 19:14 ` ericonr
2021-02-23 19:14 ` ericonr
2021-02-23 19:14 ` ericonr
2021-02-23 19:14 ` ericonr
2021-02-23 21:56 ` heliocat
2021-02-23 21:59 ` heliocat
2021-02-23 22:02 ` heliocat
2021-02-23 22:06 ` heliocat [this message]
2021-02-23 22:07 ` heliocat
2021-02-23 22:10 ` ericonr
2021-02-23 22:10 ` ericonr
2021-02-23 22:13 ` heliocat
2021-02-23 22:14 ` heliocat
2021-02-23 22:15 ` heliocat
2021-02-23 23:02 ` [PR PATCH] [Updated] " heliocat
2021-02-24  0:20 ` heliocat
2021-02-24  0:31 ` [PR REVIEW] " heliocat
2021-02-24  0:31 ` heliocat
2021-02-24  3:37 ` [PR PATCH] [Closed]: " ericonr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210223220634._NVZGXJ-QehBi4nuCgPt--215pDoj3BZJE1uQZHV-og@z \
    --to=heliocat@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).