Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] python3-pipx: add missing dependency
@ 2021-02-26 14:41 titouanco
  2021-02-26 15:04 ` ericonr
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: titouanco @ 2021-02-26 14:41 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1820 bytes --]

There is a new pull request by titouanco against master on the void-packages repository

https://github.com/titouanco/void-packages pipx
https://github.com/void-linux/void-packages/pull/29071

python3-pipx: add missing dependency
colorama is a new dependency in the 0.16.1.0 release of pipx (but wasn't added in the [commit](https://github.com/void-linux/void-packages/commit/a35dddca80d6b2497972171686834cd885ba9a1f) updating pipx earlier today) 

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/29071.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pipx-29071.patch --]
[-- Type: text/x-diff, Size: 1002 bytes --]

From 4fca4b608372819ae5881028f48918f165638d77 Mon Sep 17 00:00:00 2001
From: TC <git@titouan.co>
Date: Fri, 26 Feb 2021 15:25:07 +0100
Subject: [PATCH] python3-pipx: add missing dependency

---
 srcpkgs/python3-pipx/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/python3-pipx/template b/srcpkgs/python3-pipx/template
index 77f215ac8c6..b1b4454ec85 100644
--- a/srcpkgs/python3-pipx/template
+++ b/srcpkgs/python3-pipx/template
@@ -1,11 +1,11 @@
 # Template file for 'python3-pipx'
 pkgname=python3-pipx
 version=0.16.1.0
-revision=1
+revision=2
 wrksrc="pipx-${version}"
 build_style=python3-module
 hostmakedepends="python3-setuptools"
-depends="python3-argcomplete python3-userpath python3-setuptools python3-packaging"
+depends="python3-argcomplete python3-colorama python3-userpath python3-setuptools python3-packaging"
 short_desc="Install and Run Python Applications in Isolated Environments"
 maintainer="Leah Neukirchen <leah@vuxu.org>"
 license="MIT"

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: python3-pipx: add missing dependency
  2021-02-26 14:41 [PR PATCH] python3-pipx: add missing dependency titouanco
@ 2021-02-26 15:04 ` ericonr
  2021-02-26 15:04 ` [PR PATCH] [Merged]: " ericonr
  2021-02-26 15:16 ` titouanco
  2 siblings, 0 replies; 4+ messages in thread
From: ericonr @ 2021-02-26 15:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 224 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29071#issuecomment-786701785

Comment:
You might want to look into updating colorama as well, they "require" version 0.4.4

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PR PATCH] [Merged]: python3-pipx: add missing dependency
  2021-02-26 14:41 [PR PATCH] python3-pipx: add missing dependency titouanco
  2021-02-26 15:04 ` ericonr
@ 2021-02-26 15:04 ` ericonr
  2021-02-26 15:16 ` titouanco
  2 siblings, 0 replies; 4+ messages in thread
From: ericonr @ 2021-02-26 15:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1668 bytes --]

There's a merged pull request on the void-packages repository

python3-pipx: add missing dependency
https://github.com/void-linux/void-packages/pull/29071

Description:
colorama is a new dependency in the 0.16.1.0 release of pipx (but wasn't added in the [commit](https://github.com/void-linux/void-packages/commit/a35dddca80d6b2497972171686834cd885ba9a1f) updating pipx earlier today) 

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: python3-pipx: add missing dependency
  2021-02-26 14:41 [PR PATCH] python3-pipx: add missing dependency titouanco
  2021-02-26 15:04 ` ericonr
  2021-02-26 15:04 ` [PR PATCH] [Merged]: " ericonr
@ 2021-02-26 15:16 ` titouanco
  2 siblings, 0 replies; 4+ messages in thread
From: titouanco @ 2021-02-26 15:16 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 213 bytes --]

New comment by titouanco on void-packages repository

https://github.com/void-linux/void-packages/pull/29071#issuecomment-786709197

Comment:
Yeah I saw the version requirement, I'll make a PR later today :smile:

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-02-26 15:16 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-26 14:41 [PR PATCH] python3-pipx: add missing dependency titouanco
2021-02-26 15:04 ` ericonr
2021-02-26 15:04 ` [PR PATCH] [Merged]: " ericonr
2021-02-26 15:16 ` titouanco

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).