* [PR PATCH] tcl: make tclConfig.sh executable
@ 2021-02-27 11:18 curiousgay
2021-02-27 15:12 ` [PR REVIEW] " ericonr
` (5 more replies)
0 siblings, 6 replies; 7+ messages in thread
From: curiousgay @ 2021-02-27 11:18 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 373 bytes --]
There is a new pull request by curiousgay against master on the void-packages repository
https://github.com/curiousgay/void-packages tcl
https://github.com/void-linux/void-packages/pull/29094
tcl: make tclConfig.sh executable
This is needed for tcltls which I'm about to package.
A patch file from https://github.com/void-linux/void-packages/pull/29094.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-tcl-29094.patch --]
[-- Type: text/x-diff, Size: 901 bytes --]
From 88999ccc4e13824ea872f65fa1e14038ace4f9f0 Mon Sep 17 00:00:00 2001
From: Leonid Bobrov <curiousbeaver@disroot.org>
Date: Sat, 27 Feb 2021 13:16:00 +0200
Subject: [PATCH] tcl: make tclConfig.sh executable
This is needed for tcltls which I'm about to package.
---
srcpkgs/tcl/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/tcl/template b/srcpkgs/tcl/template
index d36663d8b1f..db7b47b12cb 100644
--- a/srcpkgs/tcl/template
+++ b/srcpkgs/tcl/template
@@ -1,7 +1,7 @@
# Template file for 'tcl'
pkgname=tcl
version=8.6.11
-revision=1
+revision=2
wrksrc="tcl${version}"
build_wrksrc=unix
build_style=gnu-configure
@@ -26,6 +26,7 @@ post_extract() {
do_install() {
make INSTALL_ROOT=${DESTDIR} install install-private-headers
ln -s tclsh8.6 ${DESTDIR}/usr/bin/tclsh
+ chmod +x ${DESTDIR}/usr/lib/tclConfig.sh
vlicense ../license.terms LICENSE
}
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PR REVIEW] tcl: make tclConfig.sh executable
2021-02-27 11:18 [PR PATCH] tcl: make tclConfig.sh executable curiousgay
@ 2021-02-27 15:12 ` ericonr
2021-02-27 15:24 ` [PR PATCH] [Updated] " curiousgay
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2021-02-27 15:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 209 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/29094#discussion_r584139768
Comment:
```suggestion
chmod 755 ${DESTDIR}/usr/lib/tclConfig.sh
```
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PR PATCH] [Updated] tcl: make tclConfig.sh executable
2021-02-27 11:18 [PR PATCH] tcl: make tclConfig.sh executable curiousgay
2021-02-27 15:12 ` [PR REVIEW] " ericonr
@ 2021-02-27 15:24 ` curiousgay
2021-02-27 15:25 ` [PR REVIEW] " curiousgay
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: curiousgay @ 2021-02-27 15:24 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 378 bytes --]
There is an updated pull request by curiousgay against master on the void-packages repository
https://github.com/curiousgay/void-packages tcl
https://github.com/void-linux/void-packages/pull/29094
tcl: make tclConfig.sh executable
This is needed for tcltls which I'm about to package.
A patch file from https://github.com/void-linux/void-packages/pull/29094.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-tcl-29094.patch --]
[-- Type: text/x-diff, Size: 902 bytes --]
From 3aed335a9f0315c0fd4cb28504e9331f53a19e24 Mon Sep 17 00:00:00 2001
From: Leonid Bobrov <curiousbeaver@disroot.org>
Date: Sat, 27 Feb 2021 13:16:00 +0200
Subject: [PATCH] tcl: make tclConfig.sh executable
This is needed for tcltls which I'm about to package.
---
srcpkgs/tcl/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/tcl/template b/srcpkgs/tcl/template
index d36663d8b1f..520c3e10294 100644
--- a/srcpkgs/tcl/template
+++ b/srcpkgs/tcl/template
@@ -1,7 +1,7 @@
# Template file for 'tcl'
pkgname=tcl
version=8.6.11
-revision=1
+revision=2
wrksrc="tcl${version}"
build_wrksrc=unix
build_style=gnu-configure
@@ -26,6 +26,7 @@ post_extract() {
do_install() {
make INSTALL_ROOT=${DESTDIR} install install-private-headers
ln -s tclsh8.6 ${DESTDIR}/usr/bin/tclsh
+ chmod 755 ${DESTDIR}/usr/lib/tclConfig.sh
vlicense ../license.terms LICENSE
}
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PR REVIEW] tcl: make tclConfig.sh executable
2021-02-27 11:18 [PR PATCH] tcl: make tclConfig.sh executable curiousgay
2021-02-27 15:12 ` [PR REVIEW] " ericonr
2021-02-27 15:24 ` [PR PATCH] [Updated] " curiousgay
@ 2021-02-27 15:25 ` curiousgay
2021-02-27 19:09 ` ericonr
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: curiousgay @ 2021-02-27 15:25 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 154 bytes --]
New review comment by curiousgay on void-packages repository
https://github.com/void-linux/void-packages/pull/29094#discussion_r584141062
Comment:
done
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: tcl: make tclConfig.sh executable
2021-02-27 11:18 [PR PATCH] tcl: make tclConfig.sh executable curiousgay
` (2 preceding siblings ...)
2021-02-27 15:25 ` [PR REVIEW] " curiousgay
@ 2021-02-27 19:09 ` ericonr
2021-02-28 5:54 ` [PR PATCH] [Closed]: " curiousgay
2021-02-28 5:54 ` curiousgay
5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2021-02-27 19:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 317 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/29094#issuecomment-787120755
Comment:
I feel like `tcltls` is doing something wrong, if it needs that file to be executable... It just sets some variables, so really all it should do is be sourced by other scripts.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: tcl: make tclConfig.sh executable
2021-02-27 11:18 [PR PATCH] tcl: make tclConfig.sh executable curiousgay
` (4 preceding siblings ...)
2021-02-28 5:54 ` [PR PATCH] [Closed]: " curiousgay
@ 2021-02-28 5:54 ` curiousgay
5 siblings, 0 replies; 7+ messages in thread
From: curiousgay @ 2021-02-28 5:54 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 220 bytes --]
New comment by curiousgay on void-packages repository
https://github.com/void-linux/void-packages/pull/29094#issuecomment-787401070
Comment:
alright, there is only one line that needs to be patched to source that file
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PR PATCH] [Closed]: tcl: make tclConfig.sh executable
2021-02-27 11:18 [PR PATCH] tcl: make tclConfig.sh executable curiousgay
` (3 preceding siblings ...)
2021-02-27 19:09 ` ericonr
@ 2021-02-28 5:54 ` curiousgay
2021-02-28 5:54 ` curiousgay
5 siblings, 0 replies; 7+ messages in thread
From: curiousgay @ 2021-02-28 5:54 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 220 bytes --]
There's a closed pull request on the void-packages repository
tcl: make tclConfig.sh executable
https://github.com/void-linux/void-packages/pull/29094
Description:
This is needed for tcltls which I'm about to package.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-02-28 5:54 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-27 11:18 [PR PATCH] tcl: make tclConfig.sh executable curiousgay
2021-02-27 15:12 ` [PR REVIEW] " ericonr
2021-02-27 15:24 ` [PR PATCH] [Updated] " curiousgay
2021-02-27 15:25 ` [PR REVIEW] " curiousgay
2021-02-27 19:09 ` ericonr
2021-02-28 5:54 ` [PR PATCH] [Closed]: " curiousgay
2021-02-28 5:54 ` curiousgay
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).