From: NeelChotai <NeelChotai@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] efibootmgr: correct install message
Date: Sat, 27 Feb 2021 21:52:05 +0100 [thread overview]
Message-ID: <20210227205205.3wCMldugxwUelX3tY9zIfX7xxfvsK1KjGX8fQE5QaQ0@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-29098@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1623 bytes --]
There is an updated pull request by NeelChotai against master on the void-packages repository
https://github.com/NeelChotai/void-packages efibootmgr-message-fix
https://github.com/void-linux/void-packages/pull/29098
efibootmgr: correct install message
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/29098.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-efibootmgr-message-fix-29098.patch --]
[-- Type: text/x-diff, Size: 2395 bytes --]
From b16454975a54f8a191b08e12acb95af4652debca Mon Sep 17 00:00:00 2001
From: Neel Chotai <neel@chot.ai>
Date: Sat, 27 Feb 2021 20:03:09 +0000
Subject: [PATCH] efibootmgr: correct install message, document mount
instructions
---
srcpkgs/efibootmgr/INSTALL.msg | 2 +-
srcpkgs/efibootmgr/files/README.voidlinux | 5 +++++
srcpkgs/efibootmgr/template | 4 ++--
3 files changed, 8 insertions(+), 3 deletions(-)
create mode 100644 srcpkgs/efibootmgr/files/README.voidlinux
diff --git a/srcpkgs/efibootmgr/INSTALL.msg b/srcpkgs/efibootmgr/INSTALL.msg
index 2b27d196f3e..c1c3d065767 100644
--- a/srcpkgs/efibootmgr/INSTALL.msg
+++ b/srcpkgs/efibootmgr/INSTALL.msg
@@ -4,7 +4,7 @@ Enable this by editing /etc/default/efibootmgr-kernel-hook.
The efi variables need to be accessible in order for this to work, so
add this line to your fstab and reboot or mount manually:
- efivarfs /sys/firmware/efi/efivars efivarfs 0 0
+ efivarfs /sys/firmware/efi/efivars efivarfs defaults 0 0
-----------------------------------------------------------------------
Kernel cmd options can be configured in /etc/default/efibootmgr-kernel-hook,
but you always have to reconfigure the kernel:
diff --git a/srcpkgs/efibootmgr/files/README.voidlinux b/srcpkgs/efibootmgr/files/README.voidlinux
new file mode 100644
index 00000000000..e95191f7d22
--- /dev/null
+++ b/srcpkgs/efibootmgr/files/README.voidlinux
@@ -0,0 +1,5 @@
+Some systems do not automatically mount efivars. If /sys/firmware/efi/efivars is empty, your system is affected.
+
+In order to to automatically mount efivars, add the following entry to /etc/fstab:
+
+efivarfs /sys/firmware/efi/efivars efivarfs defaults 0 0
diff --git a/srcpkgs/efibootmgr/template b/srcpkgs/efibootmgr/template
index e9b1bff036a..ca131efb1b1 100644
--- a/srcpkgs/efibootmgr/template
+++ b/srcpkgs/efibootmgr/template
@@ -1,7 +1,7 @@
# Template file for 'efibootmgr'
pkgname=efibootmgr
version=17
-revision=3
+revision=4
hostmakedepends="pkg-config"
makedepends="libefivar-devel popt-devel"
short_desc="Tool to modify UEFI Firmware Boot Manager Variables"
@@ -39,7 +39,7 @@ do_install() {
}
post_install() {
- vlicense COPYING
+ vdoc ${FILESDIR}/README.voidlinux
vmkdir etc/
vinstall "${FILESDIR}/efibootmgr-kernel-hook.confd" 644 etc/default efibootmgr-kernel-hook
vinstall ${FILESDIR}/kernel.d/efibootmgr.post-install 744 \
next prev parent reply other threads:[~2021-02-27 20:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-27 20:09 [PR PATCH] " NeelChotai
2021-02-27 20:10 ` ericonr
2021-02-27 20:52 ` NeelChotai [this message]
2021-02-27 20:53 ` NeelChotai
2021-02-27 20:56 ` ahesford
2021-02-27 21:10 ` [PR PATCH] [Updated] " NeelChotai
2021-02-27 21:18 ` NeelChotai
2021-02-28 7:13 ` [PR PATCH] [Merged]: " ericonr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210227205205.3wCMldugxwUelX3tY9zIfX7xxfvsK1KjGX8fQE5QaQ0@z \
--to=neelchotai@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).