Github messages for voidlinux
 help / color / mirror / Atom feed
From: tibequadorian <tibequadorian@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] musescore: update to 3.6.2.
Date: Sun, 28 Feb 2021 04:45:16 +0100	[thread overview]
Message-ID: <20210228034516.H-hcM9lignu6Ucara_w3wAfndNvm_JbOPzDwuOMboDY@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-29063@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1737 bytes --]

There is an updated pull request by tibequadorian against master on the void-packages repository

https://github.com/tibequadorian/void-packages musescore
https://github.com/void-linux/void-packages/pull/29063

musescore: update to 3.6.2.
Change maintainer (https://github.com/void-linux/void-packages/issues/29061)

I'll see if I can get cross builds working...

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/29063.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-musescore-29063.patch --]
[-- Type: text/x-diff, Size: 3327 bytes --]

From 66b477a8bb47ecabaac99b86b544a8a2f3793d62 Mon Sep 17 00:00:00 2001
From: tibequadorian <tibequadorian@posteo.de>
Date: Thu, 25 Feb 2021 22:17:41 +0100
Subject: [PATCH] musescore: update to 3.6.2.

change maintainer
enable cross builds
add soundfont to distfiles
disable qtwebengine because its unportable and unnecessary as it just provides some web content in the start center
---
 srcpkgs/musescore/template | 39 +++++++++++++++++---------------------
 1 file changed, 17 insertions(+), 22 deletions(-)

diff --git a/srcpkgs/musescore/template b/srcpkgs/musescore/template
index a853eedba5d..9bc29cf3307 100644
--- a/srcpkgs/musescore/template
+++ b/srcpkgs/musescore/template
@@ -1,15 +1,13 @@
 # Template file for 'musescore'
-# TODO: Add MuseScore Soundfont as distfiles or separate package instead of
-# downloading in the build process.
-# https://ftp.osuosl.org/pub/musescore/soundfont/MuseScore_General/
 pkgname=musescore
-version=3.5.2
+version=3.6.2
 revision=1
 wrksrc="MuseScore-${version}"
 build_style=gnu-makefile
-make_build_args="PREFIX=/usr USE_SYSTEM_FREETYPE=ON MUSESCORE_BUILD_CONFIG=release"
+make_build_args="PREFIX=/usr USE_SYSTEM_FREETYPE=ON BUILD_WEBENGINE=OFF
+ DOWNLOAD_SOUNDFONT=OFF MUSESCORE_BUILD_CONFIG=release"
 make_install_args="-C build.release"
-hostmakedepends="cmake pkg-config"
+hostmakedepends="cmake pkg-config qt5-qmake qt5-host-tools qt5-tools"
 makedepends="jack-devel lame-devel libsndfile-devel portaudio-devel
  portmidi-devel pulseaudio-devel qt5-declarative-devel qt5-script-devel
  qt5-svg-devel qt5-tools-devel qt5-webchannel-devel
@@ -17,22 +15,19 @@ makedepends="jack-devel lame-devel libsndfile-devel portaudio-devel
  qt5-plugin-pgsql qt5-plugin-sqlite qt5-plugin-tds qt5-quickcontrols2-devel"
 depends="qt5-plugin-sqlite qt5-graphicaleffects qt5-quickcontrols2"
 short_desc="Create, play and print beautiful sheet music"
-maintainer="Brian Olsen <bnolsen@comcast.net>"
+maintainer="tibequadorian <tibequadorian@posteo.de>"
 license="GPL-2.0-or-later"
 homepage="https://musescore.org/"
-distfiles="https://github.com/musescore/MuseScore/archive/v${version}.tar.gz"
-checksum=75b8e783edca9d23718770b3f715d95b88f64545e0372f4ccba58ab073cc7068
-nocross="genManual: cannot execute binary file: Exec format error"
+_soundfont_url="https://ftp.osuosl.org/pub/musescore/soundfont/MuseScore_General"
+distfiles="https://github.com/musescore/MuseScore/archive/v${version}.tar.gz
+ ${_soundfont_url}/MuseScore_General.sf3
+ ${_soundfont_url}/MuseScore_General_License.md"
+checksum="c37acc6d7a316f04925265d2d22a35d715888580e16eff846e9b621954133c45
+ 5b85b6c2c61d10b2b91cddd41efcce7b25cd31c8271d511c73afafbef20b6fa3
+ 5ad8d737e13c7f01f5b9674872a82a92b4ba253603e8ed14b9db12293550b4b9"
+skip_extraction="MuseScore_General.sf3 MuseScore_General_License.md"
 
-build_options="webengine"
-desc_option_webengine="Build with Qt5 WebEngine support"
-
-if [ "$XBPS_TARGET_ENDIAN" = "le" ]; then
-	build_options_default="webengine"
-fi
-
-if [ "$build_option_webengine" ]; then
-	makedepends+=" qt5-webengine-devel"
-else
-	make_build_args+=" BUILD_WEBENGINE=OFF"
-fi
+post_extract() {
+	cp "${XBPS_SRCDISTDIR}/${pkgname}-${version}/MuseScore_General.sf3" "${wrksrc}/share/sound/"
+	cp "${XBPS_SRCDISTDIR}/${pkgname}-${version}/MuseScore_General_License.md" "${wrksrc}/share/sound/"
+}

  parent reply	other threads:[~2021-02-28  3:45 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-25 22:29 [PR PATCH] [WIP] " tibequadorian
2021-02-26  0:38 ` tibequadorian
2021-02-26 21:28 ` [PR PATCH] [Updated] " tibequadorian
2021-02-26 22:01 ` tibequadorian
2021-02-26 22:08 ` tibequadorian
2021-02-26 22:14 ` tibequadorian
2021-02-26 22:39 ` [PR PATCH] [Updated] " tibequadorian
2021-02-26 23:24 ` tibequadorian
2021-02-26 23:25 ` tibequadorian
2021-02-27  0:08 ` [PR PATCH] [Updated] " tibequadorian
2021-02-27  0:08 ` tibequadorian
2021-02-27 11:32 ` tibequadorian
2021-02-27 13:20 ` [PR PATCH] [Updated] " tibequadorian
2021-02-27 13:33 ` tibequadorian
2021-02-27 20:46 ` [PR REVIEW] " ericonr
2021-02-28  3:39 ` tibequadorian
2021-02-28  3:41 ` tibequadorian
2021-02-28  3:45 ` tibequadorian [this message]
2021-02-28  3:45 ` [PR PATCH] [Updated] " tibequadorian
2021-02-28  3:47 ` [PR REVIEW] " tibequadorian
2021-02-28  6:52 ` [PR PATCH] [Merged]: " ericonr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210228034516.H-hcM9lignu6Ucara_w3wAfndNvm_JbOPzDwuOMboDY@z \
    --to=tibequadorian@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).