Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] glibc: add INSTALL hook to make gconv module cache
@ 2021-02-27 21:57 ArsenArsen
  2021-02-27 21:58 ` [PR REVIEW] " ericonr
                   ` (17 more replies)
  0 siblings, 18 replies; 19+ messages in thread
From: ArsenArsen @ 2021-02-27 21:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1728 bytes --]

There is a new pull request by ArsenArsen against master on the void-packages repository

https://github.com/ArsenArsen/void-packages master
https://github.com/void-linux/void-packages/pull/29103

glibc: add INSTALL hook to make gconv module cache
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (amd64-glibc)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl

I have not tested this on more machines, if someone is able to test a cross install, that would be greatly appreciated.

A patch file from https://github.com/void-linux/void-packages/pull/29103.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-29103.patch --]
[-- Type: text/x-diff, Size: 1109 bytes --]

From 84a012e2d06576c9f8e9ba92d77370e31341141c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Arsen=20Arsenovi=C4=87?= <arsen@aarsen.me>
Date: Sat, 27 Feb 2021 22:34:12 +0100
Subject: [PATCH] glibc: add INSTALL hook to make gconv module cache

---
 srcpkgs/glibc/INSTALL  | 8 ++++++++
 srcpkgs/glibc/template | 2 +-
 2 files changed, 9 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/glibc/INSTALL

diff --git a/srcpkgs/glibc/INSTALL b/srcpkgs/glibc/INSTALL
new file mode 100644
index 00000000000..1d58e3badab
--- /dev/null
+++ b/srcpkgs/glibc/INSTALL
@@ -0,0 +1,8 @@
+# Build iconv module cache
+#
+case "${ACTION}" in
+post)
+	echo "Generating iconv module cache..."
+	iconvconfig --nostdlib --prefix="$(pwd)" usr/lib${XBPS_TARGET_WORDSIZE}/gconv
+	;;
+esac
diff --git a/srcpkgs/glibc/template b/srcpkgs/glibc/template
index 9202e414545..7a487594da9 100644
--- a/srcpkgs/glibc/template
+++ b/srcpkgs/glibc/template
@@ -1,7 +1,7 @@
 # Template file for 'glibc'
 pkgname=glibc
 version=2.32
-revision=1
+revision=2
 bootstrap=yes
 short_desc="GNU C library"
 maintainer="Enno Boland <gottox@voidlinux.org>"

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PR REVIEW] glibc: add INSTALL hook to make gconv module cache
  2021-02-27 21:57 [PR PATCH] glibc: add INSTALL hook to make gconv module cache ArsenArsen
@ 2021-02-27 21:58 ` ericonr
  2021-02-27 22:12 ` [PR PATCH] [Updated] " ArsenArsen
                   ` (16 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: ericonr @ 2021-02-27 21:58 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 228 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29103#discussion_r584196207

Comment:
That variable won't be defined. `usr/lib/gconv` is the best you can get, I think.

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PR PATCH] [Updated] glibc: add INSTALL hook to make gconv module cache
  2021-02-27 21:57 [PR PATCH] glibc: add INSTALL hook to make gconv module cache ArsenArsen
  2021-02-27 21:58 ` [PR REVIEW] " ericonr
@ 2021-02-27 22:12 ` ArsenArsen
  2021-02-27 22:34 ` ArsenArsen
                   ` (15 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: ArsenArsen @ 2021-02-27 22:12 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1733 bytes --]

There is an updated pull request by ArsenArsen against master on the void-packages repository

https://github.com/ArsenArsen/void-packages master
https://github.com/void-linux/void-packages/pull/29103

glibc: add INSTALL hook to make gconv module cache
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (amd64-glibc)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl

I have not tested this on more machines, if someone is able to test a cross install, that would be greatly appreciated.

A patch file from https://github.com/void-linux/void-packages/pull/29103.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-29103.patch --]
[-- Type: text/x-diff, Size: 1086 bytes --]

From e7cd2953fab0e3be99633d169ceec732b9719a73 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Arsen=20Arsenovi=C4=87?= <arsen@aarsen.me>
Date: Sat, 27 Feb 2021 22:34:12 +0100
Subject: [PATCH] glibc: add INSTALL hook to make gconv module cache

---
 srcpkgs/glibc/INSTALL  | 8 ++++++++
 srcpkgs/glibc/template | 2 +-
 2 files changed, 9 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/glibc/INSTALL

diff --git a/srcpkgs/glibc/INSTALL b/srcpkgs/glibc/INSTALL
new file mode 100644
index 00000000000..c6b459be99c
--- /dev/null
+++ b/srcpkgs/glibc/INSTALL
@@ -0,0 +1,8 @@
+# Build iconv module cache
+#
+case "${ACTION}" in
+post)
+	echo "Generating iconv module cache..."
+	iconvconfig --nostdlib --prefix="$(pwd)" usr/lib/gconv
+	;;
+esac
diff --git a/srcpkgs/glibc/template b/srcpkgs/glibc/template
index 9202e414545..7a487594da9 100644
--- a/srcpkgs/glibc/template
+++ b/srcpkgs/glibc/template
@@ -1,7 +1,7 @@
 # Template file for 'glibc'
 pkgname=glibc
 version=2.32
-revision=1
+revision=2
 bootstrap=yes
 short_desc="GNU C library"
 maintainer="Enno Boland <gottox@voidlinux.org>"

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PR PATCH] [Updated] glibc: add INSTALL hook to make gconv module cache
  2021-02-27 21:57 [PR PATCH] glibc: add INSTALL hook to make gconv module cache ArsenArsen
  2021-02-27 21:58 ` [PR REVIEW] " ericonr
  2021-02-27 22:12 ` [PR PATCH] [Updated] " ArsenArsen
@ 2021-02-27 22:34 ` ArsenArsen
  2021-02-27 22:36 ` ArsenArsen
                   ` (14 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: ArsenArsen @ 2021-02-27 22:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1733 bytes --]

There is an updated pull request by ArsenArsen against master on the void-packages repository

https://github.com/ArsenArsen/void-packages master
https://github.com/void-linux/void-packages/pull/29103

glibc: add INSTALL hook to make gconv module cache
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (amd64-glibc)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl

I have not tested this on more machines, if someone is able to test a cross install, that would be greatly appreciated.

A patch file from https://github.com/void-linux/void-packages/pull/29103.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-29103.patch --]
[-- Type: text/x-diff, Size: 1129 bytes --]

From 965176b87efebb97424be28645a8f43d5d972b3a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Arsen=20Arsenovi=C4=87?= <arsen@aarsen.me>
Date: Sat, 27 Feb 2021 22:34:12 +0100
Subject: [PATCH] glibc: add INSTALL hook to make gconv module cache

---
 srcpkgs/glibc/INSTALL  | 10 ++++++++++
 srcpkgs/glibc/template |  2 +-
 2 files changed, 11 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/glibc/INSTALL

diff --git a/srcpkgs/glibc/INSTALL b/srcpkgs/glibc/INSTALL
new file mode 100644
index 00000000000..abf60732363
--- /dev/null
+++ b/srcpkgs/glibc/INSTALL
@@ -0,0 +1,10 @@
+# Build iconv module cache
+#
+case "${ACTION}" in
+post)
+	if [ -e usr/lib64 ]; then
+		echo "Generating iconv module cache..."
+		iconvconfig --nostdlib --prefix="$(pwd)" usr/lib64/gconv
+	fi
+	;;
+esac
diff --git a/srcpkgs/glibc/template b/srcpkgs/glibc/template
index 9202e414545..7a487594da9 100644
--- a/srcpkgs/glibc/template
+++ b/srcpkgs/glibc/template
@@ -1,7 +1,7 @@
 # Template file for 'glibc'
 pkgname=glibc
 version=2.32
-revision=1
+revision=2
 bootstrap=yes
 short_desc="GNU C library"
 maintainer="Enno Boland <gottox@voidlinux.org>"

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: glibc: add INSTALL hook to make gconv module cache
  2021-02-27 21:57 [PR PATCH] glibc: add INSTALL hook to make gconv module cache ArsenArsen
                   ` (2 preceding siblings ...)
  2021-02-27 22:34 ` ArsenArsen
@ 2021-02-27 22:36 ` ArsenArsen
  2021-02-27 22:55 ` [PR REVIEW] " ericonr
                   ` (13 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: ArsenArsen @ 2021-02-27 22:36 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 339 bytes --]

New comment by ArsenArsen on void-packages repository

https://github.com/void-linux/void-packages/pull/29103#issuecomment-787198406

Comment:
I've updated the INSTALL script to only run if `lib64` is present, in case of a multilib system. This may prevent the fix from being applied to 32-bit systems. There's probably a better solution?

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PR REVIEW] glibc: add INSTALL hook to make gconv module cache
  2021-02-27 21:57 [PR PATCH] glibc: add INSTALL hook to make gconv module cache ArsenArsen
                   ` (3 preceding siblings ...)
  2021-02-27 22:36 ` ArsenArsen
@ 2021-02-27 22:55 ` ericonr
  2021-02-27 23:07 ` [PR PATCH] [Updated] " ArsenArsen
                   ` (12 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: ericonr @ 2021-02-27 22:55 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 486 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29103#discussion_r584201506

Comment:
For the normal case, don't run this conditionally, and always use `usr/lib`.

What you can do to cater to (current) multilib setups is detect if `usr/lib32` is a directory and `usr/lib32/gconv` exists, and then run iconvconfig for it as well, assuming it behaves correctly (which it should, glibc is full of workarounds for every thing).

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PR PATCH] [Updated] glibc: add INSTALL hook to make gconv module cache
  2021-02-27 21:57 [PR PATCH] glibc: add INSTALL hook to make gconv module cache ArsenArsen
                   ` (4 preceding siblings ...)
  2021-02-27 22:55 ` [PR REVIEW] " ericonr
@ 2021-02-27 23:07 ` ArsenArsen
  2021-02-28  7:10 ` ericonr
                   ` (11 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: ArsenArsen @ 2021-02-27 23:07 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1733 bytes --]

There is an updated pull request by ArsenArsen against master on the void-packages repository

https://github.com/ArsenArsen/void-packages master
https://github.com/void-linux/void-packages/pull/29103

glibc: add INSTALL hook to make gconv module cache
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (amd64-glibc)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl

I have not tested this on more machines, if someone is able to test a cross install, that would be greatly appreciated.

A patch file from https://github.com/void-linux/void-packages/pull/29103.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-29103.patch --]
[-- Type: text/x-diff, Size: 1086 bytes --]

From 426a1400b393d50f49d044775c16f4f4edf40927 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Arsen=20Arsenovi=C4=87?= <arsen@aarsen.me>
Date: Sat, 27 Feb 2021 22:34:12 +0100
Subject: [PATCH] glibc: add INSTALL hook to make gconv module cache

---
 srcpkgs/glibc/INSTALL  | 8 ++++++++
 srcpkgs/glibc/template | 2 +-
 2 files changed, 9 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/glibc/INSTALL

diff --git a/srcpkgs/glibc/INSTALL b/srcpkgs/glibc/INSTALL
new file mode 100644
index 00000000000..c6b459be99c
--- /dev/null
+++ b/srcpkgs/glibc/INSTALL
@@ -0,0 +1,8 @@
+# Build iconv module cache
+#
+case "${ACTION}" in
+post)
+	echo "Generating iconv module cache..."
+	iconvconfig --nostdlib --prefix="$(pwd)" usr/lib/gconv
+	;;
+esac
diff --git a/srcpkgs/glibc/template b/srcpkgs/glibc/template
index 9202e414545..7a487594da9 100644
--- a/srcpkgs/glibc/template
+++ b/srcpkgs/glibc/template
@@ -1,7 +1,7 @@
 # Template file for 'glibc'
 pkgname=glibc
 version=2.32
-revision=1
+revision=2
 bootstrap=yes
 short_desc="GNU C library"
 maintainer="Enno Boland <gottox@voidlinux.org>"

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: glibc: add INSTALL hook to make gconv module cache
  2021-02-27 21:57 [PR PATCH] glibc: add INSTALL hook to make gconv module cache ArsenArsen
                   ` (5 preceding siblings ...)
  2021-02-27 23:07 ` [PR PATCH] [Updated] " ArsenArsen
@ 2021-02-28  7:10 ` ericonr
  2021-02-28 19:11 ` ArsenArsen
                   ` (10 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: ericonr @ 2021-02-28  7:10 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 249 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29103#issuecomment-787407451

Comment:
LGTM to me, but idk if adding INSTALL to glibc has any issues.

Would appreciate reviews from others here.

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: glibc: add INSTALL hook to make gconv module cache
  2021-02-27 21:57 [PR PATCH] glibc: add INSTALL hook to make gconv module cache ArsenArsen
                   ` (6 preceding siblings ...)
  2021-02-28  7:10 ` ericonr
@ 2021-02-28 19:11 ` ArsenArsen
  2021-02-28 19:32 ` Duncaen
                   ` (9 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: ArsenArsen @ 2021-02-28 19:11 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 967 bytes --]

New comment by ArsenArsen on void-packages repository

https://github.com/void-linux/void-packages/pull/29103#issuecomment-787505300

Comment:
I've managed to test the changes on aarch64. The difference seems less significant, but it is consistent, and the cache is generated fine.

Before:
```
[arsen@void-live void-packages]$ time (for x in $(seq 1 100); do bash -c ''; done;)

real    0m6.681s
user    0m4.558s
sys    0m2.325s
[arsen@void-live void-packages]$ time (for x in $(seq 1 100); do python3 -c pass; done;)

real    0m47.313s
user    0m39.021s
sys    0m8.497s
[arsen@void-live void-packages]$ 
```

After:
```
[arsen@void-live void-packages]$ time (for x in $(seq 1 100); do bash -c ''; done;)

real    0m6.430s
user    0m4.570s
sys    0m2.091s
[arsen@void-live void-packages]$ time (for x in $(seq 1 100); do python3 -c pass; done;)

real    0m48.410s
user    0m40.391s
sys    0m8.228s
[arsen@void-live void-packages]$ 
```

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: glibc: add INSTALL hook to make gconv module cache
  2021-02-27 21:57 [PR PATCH] glibc: add INSTALL hook to make gconv module cache ArsenArsen
                   ` (7 preceding siblings ...)
  2021-02-28 19:11 ` ArsenArsen
@ 2021-02-28 19:32 ` Duncaen
  2021-02-28 20:44 ` ArsenArsen
                   ` (8 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: Duncaen @ 2021-02-28 19:32 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 532 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/29103#issuecomment-787508665

Comment:
> LGTM to me, but idk if adding INSTALL to glibc has any issues.

It kinda is problematic in the sense that the scripts are problematic in general at the moment.
If glibc breaks ABI shit goes south, if its because of the script in the glibc update itself or the next script does not really matter.

Also is it really required to build this case on the system or could we just ship it?


^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: glibc: add INSTALL hook to make gconv module cache
  2021-02-27 21:57 [PR PATCH] glibc: add INSTALL hook to make gconv module cache ArsenArsen
                   ` (8 preceding siblings ...)
  2021-02-28 19:32 ` Duncaen
@ 2021-02-28 20:44 ` ArsenArsen
  2021-02-28 23:54 ` [PR PATCH] [Updated] " ArsenArsen
                   ` (7 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: ArsenArsen @ 2021-02-28 20:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 328 bytes --]

New comment by ArsenArsen on void-packages repository

https://github.com/void-linux/void-packages/pull/29103#issuecomment-787519855

Comment:
> Also is it really required to build this case on the system or could we just ship it?

You're right, it can be built before. Debian also does that. I'll look into it later tonight.

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PR PATCH] [Updated] glibc: add INSTALL hook to make gconv module cache
  2021-02-27 21:57 [PR PATCH] glibc: add INSTALL hook to make gconv module cache ArsenArsen
                   ` (9 preceding siblings ...)
  2021-02-28 20:44 ` ArsenArsen
@ 2021-02-28 23:54 ` ArsenArsen
  2021-03-02  7:07 ` [PR PATCH] [Updated] glibc: generate gconv cache when possible ArsenArsen
                   ` (6 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: ArsenArsen @ 2021-02-28 23:54 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1691 bytes --]

There is an updated pull request by ArsenArsen against master on the void-packages repository

https://github.com/ArsenArsen/void-packages master
https://github.com/void-linux/void-packages/pull/29103

glibc: add INSTALL hook to make gconv module cache
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (amd64-glibc)
- [x] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64

I have not tested this on more machines, if someone is able to test a cross install, that would be greatly appreciated.

A patch file from https://github.com/void-linux/void-packages/pull/29103.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-29103.patch --]
[-- Type: text/x-diff, Size: 1060 bytes --]

From 6f7b44dd297d19a2a8f4b2523a9bed97912b4fff Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Arsen=20Arsenovi=C4=87?= <arsen@aarsen.me>
Date: Sat, 27 Feb 2021 22:34:12 +0100
Subject: [PATCH] glibc: generate gconv cache when possible

---
 srcpkgs/glibc/template | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/glibc/template b/srcpkgs/glibc/template
index 9202e414545..cda15366c28 100644
--- a/srcpkgs/glibc/template
+++ b/srcpkgs/glibc/template
@@ -1,7 +1,7 @@
 # Template file for 'glibc'
 pkgname=glibc
 version=2.32
-revision=1
+revision=2
 bootstrap=yes
 short_desc="GNU C library"
 maintainer="Enno Boland <gottox@voidlinux.org>"
@@ -176,6 +176,16 @@ do_install() {
 			;;
 		*) ;;
 	esac
+
+	# Generate gconv caches
+	if [ "${XBPS_TARGET_MACHINE%-musl}" = "${XBPS_MACHINE%-musl}" ]; then
+		"${DESTDIR}/usr/lib/ld-${version}.so" \
+				--library-path "${DESTDIR}/usr/lib" \
+				"${DESTDIR}/usr/bin/iconvconfig" \
+				--nostdlib \
+				--prefix "${DESTDIR}" \
+				"/usr/lib/gconv"
+	fi
 }
 
 glibc-devel_package() {

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PR PATCH] [Updated] glibc: generate gconv cache when possible
  2021-02-27 21:57 [PR PATCH] glibc: add INSTALL hook to make gconv module cache ArsenArsen
                   ` (10 preceding siblings ...)
  2021-02-28 23:54 ` [PR PATCH] [Updated] " ArsenArsen
@ 2021-03-02  7:07 ` ArsenArsen
  2021-03-04 18:02 ` ArsenArsen
                   ` (5 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: ArsenArsen @ 2021-03-02  7:07 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1682 bytes --]

There is an updated pull request by ArsenArsen against master on the void-packages repository

https://github.com/ArsenArsen/void-packages master
https://github.com/void-linux/void-packages/pull/29103

glibc: generate gconv cache when possible
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (amd64-glibc)
- [x] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64

I have not tested this on more machines, if someone is able to test a cross install, that would be greatly appreciated.

A patch file from https://github.com/void-linux/void-packages/pull/29103.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-29103.patch --]
[-- Type: text/x-diff, Size: 1086 bytes --]

From 426a1400b393d50f49d044775c16f4f4edf40927 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Arsen=20Arsenovi=C4=87?= <arsen@aarsen.me>
Date: Sat, 27 Feb 2021 22:34:12 +0100
Subject: [PATCH] glibc: add INSTALL hook to make gconv module cache

---
 srcpkgs/glibc/INSTALL  | 8 ++++++++
 srcpkgs/glibc/template | 2 +-
 2 files changed, 9 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/glibc/INSTALL

diff --git a/srcpkgs/glibc/INSTALL b/srcpkgs/glibc/INSTALL
new file mode 100644
index 00000000000..c6b459be99c
--- /dev/null
+++ b/srcpkgs/glibc/INSTALL
@@ -0,0 +1,8 @@
+# Build iconv module cache
+#
+case "${ACTION}" in
+post)
+	echo "Generating iconv module cache..."
+	iconvconfig --nostdlib --prefix="$(pwd)" usr/lib/gconv
+	;;
+esac
diff --git a/srcpkgs/glibc/template b/srcpkgs/glibc/template
index 9202e414545..7a487594da9 100644
--- a/srcpkgs/glibc/template
+++ b/srcpkgs/glibc/template
@@ -1,7 +1,7 @@
 # Template file for 'glibc'
 pkgname=glibc
 version=2.32
-revision=1
+revision=2
 bootstrap=yes
 short_desc="GNU C library"
 maintainer="Enno Boland <gottox@voidlinux.org>"

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: glibc: generate gconv cache when possible
  2021-02-27 21:57 [PR PATCH] glibc: add INSTALL hook to make gconv module cache ArsenArsen
                   ` (11 preceding siblings ...)
  2021-03-02  7:07 ` [PR PATCH] [Updated] glibc: generate gconv cache when possible ArsenArsen
@ 2021-03-04 18:02 ` ArsenArsen
  2021-03-06 12:21 ` [PR PATCH] [Updated] " ArsenArsen
                   ` (4 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: ArsenArsen @ 2021-03-04 18:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 200 bytes --]

New comment by ArsenArsen on void-packages repository

https://github.com/void-linux/void-packages/pull/29103#issuecomment-790814282

Comment:
blocked on https://github.com/void-linux/xbps/issues/382

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PR PATCH] [Updated] glibc: generate gconv cache when possible
  2021-02-27 21:57 [PR PATCH] glibc: add INSTALL hook to make gconv module cache ArsenArsen
                   ` (12 preceding siblings ...)
  2021-03-04 18:02 ` ArsenArsen
@ 2021-03-06 12:21 ` ArsenArsen
  2021-08-24 18:11 ` [PR PATCH] [Updated] [NOMERGE] " ArsenArsen
                   ` (3 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: ArsenArsen @ 2021-03-06 12:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1682 bytes --]

There is an updated pull request by ArsenArsen against master on the void-packages repository

https://github.com/ArsenArsen/void-packages master
https://github.com/void-linux/void-packages/pull/29103

glibc: generate gconv cache when possible
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (amd64-glibc)
- [x] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64

I have not tested this on more machines, if someone is able to test a cross install, that would be greatly appreciated.

A patch file from https://github.com/void-linux/void-packages/pull/29103.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-29103.patch --]
[-- Type: text/x-diff, Size: 2740 bytes --]

From 426a1400b393d50f49d044775c16f4f4edf40927 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Arsen=20Arsenovi=C4=87?= <arsen@aarsen.me>
Date: Sat, 27 Feb 2021 22:34:12 +0100
Subject: [PATCH 1/2] glibc: add INSTALL hook to make gconv module cache

---
 srcpkgs/glibc/INSTALL  | 8 ++++++++
 srcpkgs/glibc/template | 2 +-
 2 files changed, 9 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/glibc/INSTALL

diff --git a/srcpkgs/glibc/INSTALL b/srcpkgs/glibc/INSTALL
new file mode 100644
index 00000000000..c6b459be99c
--- /dev/null
+++ b/srcpkgs/glibc/INSTALL
@@ -0,0 +1,8 @@
+# Build iconv module cache
+#
+case "${ACTION}" in
+post)
+	echo "Generating iconv module cache..."
+	iconvconfig --nostdlib --prefix="$(pwd)" usr/lib/gconv
+	;;
+esac
diff --git a/srcpkgs/glibc/template b/srcpkgs/glibc/template
index 9202e414545..7a487594da9 100644
--- a/srcpkgs/glibc/template
+++ b/srcpkgs/glibc/template
@@ -1,7 +1,7 @@
 # Template file for 'glibc'
 pkgname=glibc
 version=2.32
-revision=1
+revision=2
 bootstrap=yes
 short_desc="GNU C library"
 maintainer="Enno Boland <gottox@voidlinux.org>"

From 243504ade70d6efba8097fb4c6fdedd21c5c2825 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Arsen=20Arsenovi=C4=87?= <arsen@aarsen.me>
Date: Sat, 6 Mar 2021 13:21:23 +0100
Subject: [PATCH 2/2] glibc: break out glibc-gconv

---
 srcpkgs/glibc-gconv                            |  1 +
 srcpkgs/glibc/{INSTALL => glibc-gconv.INSTALL} |  0
 srcpkgs/glibc/template                         | 11 +++++++++++
 3 files changed, 12 insertions(+)
 create mode 120000 srcpkgs/glibc-gconv
 rename srcpkgs/glibc/{INSTALL => glibc-gconv.INSTALL} (100%)

diff --git a/srcpkgs/glibc-gconv b/srcpkgs/glibc-gconv
new file mode 120000
index 00000000000..0c4c137d7ca
--- /dev/null
+++ b/srcpkgs/glibc-gconv
@@ -0,0 +1 @@
+glibc
\ No newline at end of file
diff --git a/srcpkgs/glibc/INSTALL b/srcpkgs/glibc/glibc-gconv.INSTALL
similarity index 100%
rename from srcpkgs/glibc/INSTALL
rename to srcpkgs/glibc/glibc-gconv.INSTALL
diff --git a/srcpkgs/glibc/template b/srcpkgs/glibc/template
index 7a487594da9..95be15df8f7 100644
--- a/srcpkgs/glibc/template
+++ b/srcpkgs/glibc/template
@@ -50,6 +50,7 @@ conf_files="
 if [ "$CHROOT_READY" ]; then
 	hostmakedepends="bison perl python3 texinfo"
 fi
+depends="glibc-gconv"
 makedepends="kernel-libc-headers"
 lib32files="/usr/lib/gconv/gconv-modules"
 lib32symlinks="ld-linux.so.2"
@@ -192,6 +193,16 @@ glibc-devel_package() {
 		fi
 	}
 }
+
+glibc-gconv_package() {
+	depends="glibc>=${version}_${revision}"
+	short_desc+=" - gconv modules"
+	pkg_install() {
+		vmove "usr/lib/gconv"
+		vmove "usr/bin/iconvconfig"
+	}
+}
+
 glibc-locales_package() {
 	conf_files="/etc/default/libc-locales"
 	short_desc+=" - locale data files"

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PR PATCH] [Updated] [NOMERGE] glibc: generate gconv cache when possible
  2021-02-27 21:57 [PR PATCH] glibc: add INSTALL hook to make gconv module cache ArsenArsen
                   ` (13 preceding siblings ...)
  2021-03-06 12:21 ` [PR PATCH] [Updated] " ArsenArsen
@ 2021-08-24 18:11 ` ArsenArsen
  2021-08-24 18:14 ` ArsenArsen
                   ` (2 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: ArsenArsen @ 2021-08-24 18:11 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1692 bytes --]

There is an updated pull request by ArsenArsen against master on the void-packages repository

https://github.com/ArsenArsen/void-packages master
https://github.com/void-linux/void-packages/pull/29103

[NOMERGE] glibc: generate gconv cache when possible
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (amd64-glibc)
- [x] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64

I have not tested this on more machines, if someone is able to test a cross install, that would be greatly appreciated.

A patch file from https://github.com/void-linux/void-packages/pull/29103.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-29103.patch --]
[-- Type: text/x-diff, Size: 2756 bytes --]

From 0f368c41854241d12e6dc64454df45ae32157166 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Arsen=20Arsenovi=C4=87?= <arsen@aarsen.me>
Date: Sat, 27 Feb 2021 22:34:12 +0100
Subject: [PATCH 1/2] glibc: add INSTALL hook to make gconv module cache

---
 srcpkgs/glibc/INSTALL  | 8 ++++++++
 srcpkgs/glibc/template | 2 +-
 2 files changed, 9 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/glibc/INSTALL

diff --git a/srcpkgs/glibc/INSTALL b/srcpkgs/glibc/INSTALL
new file mode 100644
index 000000000000..c6b459be99c4
--- /dev/null
+++ b/srcpkgs/glibc/INSTALL
@@ -0,0 +1,8 @@
+# Build iconv module cache
+#
+case "${ACTION}" in
+post)
+	echo "Generating iconv module cache..."
+	iconvconfig --nostdlib --prefix="$(pwd)" usr/lib/gconv
+	;;
+esac
diff --git a/srcpkgs/glibc/template b/srcpkgs/glibc/template
index c62a4d2aedf1..4a2f0e019e0c 100644
--- a/srcpkgs/glibc/template
+++ b/srcpkgs/glibc/template
@@ -1,7 +1,7 @@
 # Template file for 'glibc'
 pkgname=glibc
 version=2.32
-revision=2
+revision=3
 bootstrap=yes
 short_desc="GNU C library"
 maintainer="Enno Boland <gottox@voidlinux.org>"

From c437599bc656d720e4c34ef4dedf242aa0130bff Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Arsen=20Arsenovi=C4=87?= <arsen@aarsen.me>
Date: Sat, 6 Mar 2021 13:21:23 +0100
Subject: [PATCH 2/2] glibc: break out glibc-gconv

---
 srcpkgs/glibc-gconv                            |  1 +
 srcpkgs/glibc/{INSTALL => glibc-gconv.INSTALL} |  0
 srcpkgs/glibc/template                         | 11 +++++++++++
 3 files changed, 12 insertions(+)
 create mode 120000 srcpkgs/glibc-gconv
 rename srcpkgs/glibc/{INSTALL => glibc-gconv.INSTALL} (100%)

diff --git a/srcpkgs/glibc-gconv b/srcpkgs/glibc-gconv
new file mode 120000
index 000000000000..0c4c137d7ca7
--- /dev/null
+++ b/srcpkgs/glibc-gconv
@@ -0,0 +1 @@
+glibc
\ No newline at end of file
diff --git a/srcpkgs/glibc/INSTALL b/srcpkgs/glibc/glibc-gconv.INSTALL
similarity index 100%
rename from srcpkgs/glibc/INSTALL
rename to srcpkgs/glibc/glibc-gconv.INSTALL
diff --git a/srcpkgs/glibc/template b/srcpkgs/glibc/template
index 4a2f0e019e0c..eac1667ce1c7 100644
--- a/srcpkgs/glibc/template
+++ b/srcpkgs/glibc/template
@@ -49,6 +49,7 @@ conf_files="
 if [ "$CHROOT_READY" ]; then
 	hostmakedepends="bison gettext perl python3 texinfo"
 fi
+depends="glibc-gconv"
 makedepends="kernel-libc-headers"
 lib32files="/usr/lib/gconv/gconv-modules"
 lib32symlinks="ld-linux.so.2"
@@ -191,6 +192,16 @@ glibc-devel_package() {
 		fi
 	}
 }
+
+glibc-gconv_package() {
+	depends="glibc>=${version}_${revision}"
+	short_desc+=" - gconv modules"
+	pkg_install() {
+		vmove "usr/lib/gconv"
+		vmove "usr/bin/iconvconfig"
+	}
+}
+
 glibc-locales_package() {
 	conf_files="/etc/default/libc-locales"
 	short_desc+=" - locale data files"

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [NOMERGE] glibc: generate gconv cache when possible
  2021-02-27 21:57 [PR PATCH] glibc: add INSTALL hook to make gconv module cache ArsenArsen
                   ` (14 preceding siblings ...)
  2021-08-24 18:11 ` [PR PATCH] [Updated] [NOMERGE] " ArsenArsen
@ 2021-08-24 18:14 ` ArsenArsen
  2022-05-05  2:09 ` github-actions
  2022-05-19  2:15 ` [PR PATCH] [Closed]: " github-actions
  17 siblings, 0 replies; 19+ messages in thread
From: ArsenArsen @ 2021-08-24 18:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 876 bytes --]

New comment by ArsenArsen on void-packages repository

https://github.com/void-linux/void-packages/pull/29103#issuecomment-904867076

Comment:
Now that the issue that was blocking this is resolved, we can continue to re-evaluate this PR.

Right now, the install appears to work, including a force reinstall, which means that the old problem is gone, now what's left to decide is whether to figure out building this cache ahead of time, on the build server. According to my recollection, there's no specified format for this file, so the host libcs and target libcs caches may differ, but I can consult developers of other distributions for advice with this, maybe that's only the case theoretically, and in practice the format hasn't changed, ever? Maybe it fails gracefully if the file is wrong?

Is the ABI problem even an issue now that INSTALL scripts are batched up?

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [NOMERGE] glibc: generate gconv cache when possible
  2021-02-27 21:57 [PR PATCH] glibc: add INSTALL hook to make gconv module cache ArsenArsen
                   ` (15 preceding siblings ...)
  2021-08-24 18:14 ` ArsenArsen
@ 2022-05-05  2:09 ` github-actions
  2022-05-19  2:15 ` [PR PATCH] [Closed]: " github-actions
  17 siblings, 0 replies; 19+ messages in thread
From: github-actions @ 2022-05-05  2:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/29103#issuecomment-1118098294

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PR PATCH] [Closed]: [NOMERGE] glibc: generate gconv cache when possible
  2021-02-27 21:57 [PR PATCH] glibc: add INSTALL hook to make gconv module cache ArsenArsen
                   ` (16 preceding siblings ...)
  2022-05-05  2:09 ` github-actions
@ 2022-05-19  2:15 ` github-actions
  17 siblings, 0 replies; 19+ messages in thread
From: github-actions @ 2022-05-19  2:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1531 bytes --]

There's a closed pull request on the void-packages repository

[NOMERGE] glibc: generate gconv cache when possible
https://github.com/void-linux/void-packages/pull/29103

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (amd64-glibc)
- [x] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64

I have not tested this on more machines, if someone is able to test a cross install, that would be greatly appreciated.

^ permalink raw reply	[flat|nested] 19+ messages in thread

end of thread, other threads:[~2022-05-19  2:15 UTC | newest]

Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-27 21:57 [PR PATCH] glibc: add INSTALL hook to make gconv module cache ArsenArsen
2021-02-27 21:58 ` [PR REVIEW] " ericonr
2021-02-27 22:12 ` [PR PATCH] [Updated] " ArsenArsen
2021-02-27 22:34 ` ArsenArsen
2021-02-27 22:36 ` ArsenArsen
2021-02-27 22:55 ` [PR REVIEW] " ericonr
2021-02-27 23:07 ` [PR PATCH] [Updated] " ArsenArsen
2021-02-28  7:10 ` ericonr
2021-02-28 19:11 ` ArsenArsen
2021-02-28 19:32 ` Duncaen
2021-02-28 20:44 ` ArsenArsen
2021-02-28 23:54 ` [PR PATCH] [Updated] " ArsenArsen
2021-03-02  7:07 ` [PR PATCH] [Updated] glibc: generate gconv cache when possible ArsenArsen
2021-03-04 18:02 ` ArsenArsen
2021-03-06 12:21 ` [PR PATCH] [Updated] " ArsenArsen
2021-08-24 18:11 ` [PR PATCH] [Updated] [NOMERGE] " ArsenArsen
2021-08-24 18:14 ` ArsenArsen
2022-05-05  2:09 ` github-actions
2022-05-19  2:15 ` [PR PATCH] [Closed]: " github-actions

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).