Re: [PR PATCH] [Updated] glibc: add INSTALL hook to make gconv module cache

[ArsenArsen <ArsenArsen@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 1691 bytes --]

There is an updated pull request by ArsenArsen against master on the void-packages repository

https://github.com/ArsenArsen/void-packages master
https://github.com/void-linux/void-packages/pull/29103

glibc: add INSTALL hook to make gconv module cache
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (amd64-glibc)
- [x] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64

I have not tested this on more machines, if someone is able to test a cross install, that would be greatly appreciated.

A patch file from https://github.com/void-linux/void-packages/pull/29103.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-29103.patch --]
[-- Type: text/x-diff, Size: 1060 bytes --]

From 6f7b44dd297d19a2a8f4b2523a9bed97912b4fff Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Arsen=20Arsenovi=C4=87?= <arsen@aarsen.me>
Date: Sat, 27 Feb 2021 22:34:12 +0100
Subject: [PATCH] glibc: generate gconv cache when possible

---
 srcpkgs/glibc/template | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/glibc/template b/srcpkgs/glibc/template
index 9202e414545..cda15366c28 100644
--- a/srcpkgs/glibc/template
+++ b/srcpkgs/glibc/template
@@ -1,7 +1,7 @@
 # Template file for 'glibc'
 pkgname=glibc
 version=2.32
-revision=1
+revision=2
 bootstrap=yes
 short_desc="GNU C library"
 maintainer="Enno Boland <gottox@voidlinux.org>"
@@ -176,6 +176,16 @@ do_install() {
 			;;
 		*) ;;
 	esac
+
+	# Generate gconv caches
+	if [ "${XBPS_TARGET_MACHINE%-musl}" = "${XBPS_MACHINE%-musl}" ]; then
+		"${DESTDIR}/usr/lib/ld-${version}.so" \
+				--library-path "${DESTDIR}/usr/lib" \
+				"${DESTDIR}/usr/bin/iconvconfig" \
+				--nostdlib \
+				--prefix "${DESTDIR}" \
+				"/usr/lib/gconv"
+	fi
 }
 
 glibc-devel_package() {