From: jjsullivan5196 <jjsullivan5196@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] pinephone: add support for modem setup and audio routing.
Date: Mon, 01 Mar 2021 01:18:11 +0100 [thread overview]
Message-ID: <20210301001811.EfBh9ycT04JcnJHYh36ssn7zY6Tq4Z5D5zvN34r06Gg@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-25084@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 782 bytes --]
New review comment by jjsullivan5196 on void-packages repository
https://github.com/void-linux/void-packages/pull/25084#discussion_r584387362
Comment:
@ericonr Initially I took this out because I noticed this invocation didn't do anything, but that might be because the upstream script is 'broken' in a sense. The main parts of it are tested, but the variable which contains the path to the modem device file is unset https://gitlab.com/postmarketOS/pmaports/-/blob/master/device/main/device-pine64-pinephone/setup-modem.sh
This might have gone unnoticed, since the changes made by this script should be persistent until new settings are uploaded to the modem. I'll ask the pmos people about it, and try the script again myself. If nothing is wrong, I'll just kill this patch.
next prev parent reply other threads:[~2021-03-01 0:18 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 9:18 [PR PATCH] " jjsullivan5196
2021-01-29 3:10 ` ericonr
2021-01-29 4:08 ` jjsullivan5196
2021-02-05 10:17 ` [PR PATCH] [Updated] " jjsullivan5196
2021-02-05 10:19 ` jjsullivan5196
2021-02-05 10:20 ` jjsullivan5196
2021-02-05 10:22 ` jjsullivan5196
2021-02-06 5:00 ` [PR REVIEW] " the-maldridge
2021-02-06 5:13 ` jjsullivan5196
2021-02-06 5:15 ` the-maldridge
2021-02-06 5:19 ` ericonr
2021-02-06 5:32 ` [PR PATCH] [Updated] " jjsullivan5196
2021-02-06 5:35 ` [PR REVIEW] " jjsullivan5196
2021-02-06 7:06 ` [PR PATCH] [Updated] " jjsullivan5196
2021-02-06 7:09 ` jjsullivan5196
2021-02-06 7:15 ` jjsullivan5196
2021-02-06 7:21 ` jjsullivan5196
2021-02-22 21:39 ` MungFuSensei
2021-02-24 4:03 ` [PR REVIEW] " ericonr
2021-02-24 4:03 ` ericonr
2021-02-24 4:03 ` ericonr
2021-02-25 19:38 ` Piraty
2021-03-01 0:14 ` [PR PATCH] [Updated] " jjsullivan5196
2021-03-01 0:15 ` [PR REVIEW] " jjsullivan5196
2021-03-01 0:15 ` jjsullivan5196
2021-03-01 0:17 ` the-maldridge
2021-03-01 0:18 ` jjsullivan5196 [this message]
2022-04-09 9:28 ` JamiKettunen
2022-04-18 20:17 ` HadetTheUndying
2022-07-19 2:14 ` github-actions
2022-08-07 2:13 ` [PR PATCH] [Closed]: " github-actions
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210301001811.EfBh9ycT04JcnJHYh36ssn7zY6Tq4Z5D5zvN34r06Gg@z \
--to=jjsullivan5196@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).