From: gbrlsnchs <gbrlsnchs@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: tree-sitter: build and install tree-sitter CLI.
Date: Mon, 08 Mar 2021 01:06:42 +0100 [thread overview]
Message-ID: <20210308000642.VWMtclt0eA4SHy6nriTgCY0_dSnrrfz3rNQClaIPAo0@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-29272@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1299 bytes --]
New comment by gbrlsnchs on void-packages repository
https://github.com/void-linux/void-packages/pull/29272#issuecomment-792380919
Comment:
> I was really happy with building tree-sitter not requiring any Rust just yet... Do you think this is strictly necessary?
I think the CLI is part and parcel of tree-sitter as a whole, so currently we have an incomplete package in the repos. I say that based on [this explanation](https://tree-sitter.github.io/tree-sitter/implementation) from its homepage.
> Also, due to cross compilation and some other concerns, building the Rust parts would require a whole lot of code, to the point I would consider making this a `build_style=cargo` template and using `make` manually in `post_build` and post_install`for the`libtree-sitter` part; or just creating a paired template that should be updated in tandem that builds only the Rust part.
>
> Doing the first suggestion will probably work well enough, I think.
Yeah, we could have something like `tree-sitter-cli_package()` but, as you said, Rust demands fine-tuning manual installation, so it would be a bad choice maintainability-wise. I can in fact use the `cargo` build style for the CLI and then run the appropriate `make` command in `post_build`/`post_install` as needed, what do you think?
next prev parent reply other threads:[~2021-03-08 0:06 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-06 17:58 [PR PATCH] " gbrlsnchs
2021-03-07 21:33 ` ericonr
2021-03-07 21:38 ` ericonr
2021-03-08 0:06 ` gbrlsnchs [this message]
2021-03-08 0:34 ` ericonr
2021-03-08 0:45 ` gbrlsnchs
2021-03-08 2:27 ` ericonr
2021-03-08 14:26 ` gbrlsnchs
2021-03-08 14:27 ` gbrlsnchs
2021-03-08 14:27 ` gbrlsnchs
2021-03-08 15:13 ` ericonr
2021-03-08 17:50 ` gbrlsnchs
2021-03-08 18:27 ` ericonr
2021-03-08 18:27 ` ericonr
2021-03-08 18:49 ` gbrlsnchs
2021-03-08 18:55 ` FollieHiyuki
2021-03-08 19:03 ` ericonr
2021-03-08 20:50 ` [PR PATCH] [Updated] " gbrlsnchs
2021-03-08 20:51 ` gbrlsnchs
2021-03-08 20:53 ` gbrlsnchs
2021-03-08 20:56 ` gbrlsnchs
2021-03-08 22:52 ` ericonr
2021-03-09 0:31 ` gbrlsnchs
2021-03-09 0:39 ` ericonr
2021-03-09 0:39 ` ericonr
2021-03-09 1:02 ` gbrlsnchs
2021-03-09 1:06 ` [PR PATCH] [Updated] " gbrlsnchs
2021-03-09 8:51 ` FollieHiyuki
2021-03-15 23:48 ` [PR PATCH] [Closed]: " ericonr
2021-03-15 23:48 ` ericonr
2021-03-15 23:55 ` gbrlsnchs
2021-03-16 0:10 ` ericonr
2021-03-16 0:11 ` ericonr
2021-03-16 13:40 ` gbrlsnchs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210308000642.VWMtclt0eA4SHy6nriTgCY0_dSnrrfz3rNQClaIPAo0@z \
--to=gbrlsnchs@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).