From: endigma <endigma@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] docker: refactor, update, segment
Date: Fri, 12 Mar 2021 05:21:46 +0100 [thread overview]
Message-ID: <20210312042146.4teHlogmg3PJwDpuw6_WKTNCNd4om8tt1SP-eg08y4I@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-29326@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1223 bytes --]
New review comment by endigma on void-packages repository
https://github.com/void-linux/void-packages/pull/29326#discussion_r592900471
Comment:
ahesford: you suggest a restructure of the package to be as follows correct?:
```
docker-cli
-> docker (transitional package)
moby (docker-engine)
```
this isn't a horrible idea, but I think my approach is better for a few reasons:
1. the docker-cli doesn't depend on the docker container daemon, nor vice versa
2. some people may wish to install one of the two packages individually
3. as it stands, `docker` is a dummy package similar to `xorg` which provides all the tools one might expect or need.
4. renaming the engine package to moby may be more accurate to the repository used, however if someone queries the xbps repositories for docker related packages it might be better to name the package in relation to what it's normally used for. I've also updated the distfiles to be sourced from the `docker/engine` repository so in the event the versioning of these two projects ever differs the package should get the one compatible with other docker tools.
I'd love more input on how to improve things, and I've left responses on your suggested edits.
next prev parent reply other threads:[~2021-03-12 4:21 UTC|newest]
Thread overview: 97+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 18:30 [PR PATCH] " endigma
2021-03-08 18:56 ` endigma
2021-03-08 19:08 ` [PR PATCH] [Updated] " endigma
2021-03-08 19:10 ` endigma
2021-03-08 19:10 ` endigma
2021-03-08 19:12 ` [PR PATCH] [Updated] " endigma
2021-03-08 19:36 ` endigma
2021-03-08 19:37 ` endigma
2021-03-08 19:38 ` endigma
2021-03-11 21:04 ` [PR REVIEW] " ericonr
2021-03-11 21:04 ` ericonr
2021-03-11 21:04 ` ericonr
2021-03-11 21:04 ` ericonr
2021-03-11 21:04 ` ericonr
2021-03-11 23:56 ` [PR REVIEW] " endigma
2021-03-12 0:00 ` endigma
2021-03-12 0:00 ` endigma
2021-03-12 0:01 ` endigma
2021-03-12 0:02 ` [PR REVIEW] " endigma
2021-03-12 0:02 ` endigma
2021-03-12 0:03 ` [PR PATCH] [Updated] " endigma
2021-03-12 0:05 ` endigma
2021-03-12 0:07 ` [PR PATCH] [Updated] " endigma
2021-03-12 0:13 ` endigma
2021-03-12 0:15 ` endigma
2021-03-12 0:25 ` [PR REVIEW] " sgn
2021-03-12 1:03 ` [PR PATCH] [Updated] " endigma
2021-03-12 2:00 ` [PR REVIEW] " ahesford
2021-03-12 2:00 ` ahesford
2021-03-12 2:00 ` ahesford
2021-03-12 2:00 ` ahesford
2021-03-12 2:00 ` ahesford
2021-03-12 2:00 ` ahesford
2021-03-12 2:00 ` ahesford
2021-03-12 2:00 ` ahesford
2021-03-12 2:00 ` ahesford
2021-03-12 2:00 ` ahesford
2021-03-12 2:00 ` ahesford
2021-03-12 2:19 ` ericonr
2021-03-12 3:35 ` endigma
2021-03-12 3:39 ` endigma
2021-03-12 3:39 ` endigma
2021-03-12 3:41 ` endigma
2021-03-12 3:42 ` endigma
2021-03-12 3:47 ` endigma
2021-03-12 3:47 ` endigma
2021-03-12 3:49 ` endigma
2021-03-12 3:50 ` endigma
2021-03-12 3:57 ` endigma
2021-03-12 4:00 ` endigma
2021-03-12 4:01 ` endigma
2021-03-12 4:02 ` endigma
2021-03-12 4:02 ` endigma
2021-03-12 4:14 ` endigma
2021-03-12 4:14 ` endigma
2021-03-12 4:21 ` endigma [this message]
2021-03-12 4:22 ` endigma
2021-03-12 4:22 ` endigma
2021-03-12 4:23 ` endigma
2021-03-12 4:24 ` endigma
2021-03-12 4:24 ` endigma
2021-03-12 4:30 ` ahesford
2021-03-12 4:30 ` ahesford
2021-03-12 4:30 ` ahesford
2021-03-12 4:30 ` ahesford
2021-03-12 4:30 ` endigma
2021-03-12 4:34 ` [PR PATCH] [Updated] " endigma
2021-03-12 4:36 ` endigma
2021-03-12 4:37 ` [PR REVIEW] " endigma
2021-03-12 4:43 ` [PR PATCH] [Updated] " endigma
2021-03-12 4:43 ` [PR REVIEW] " endigma
2021-03-12 4:48 ` endigma
2021-03-12 4:48 ` endigma
2021-03-12 4:51 ` [PR PATCH] [Updated] " endigma
2021-03-16 15:51 ` endigma
2021-03-16 15:55 ` endigma
2021-03-16 17:24 ` [PR PATCH] [Updated] " rainyuu
2021-03-16 17:26 ` [PR REVIEW] " endigma
2021-03-16 17:26 ` endigma
2021-03-16 17:40 ` [PR PATCH] [Updated] " rainyuu
2021-03-16 18:41 ` rainyuu
2021-03-20 14:42 ` endigma
2021-03-20 15:25 ` dm17
2021-03-20 15:40 ` ahesford
2021-03-20 16:04 ` endigma
2021-03-21 5:40 ` [PR REVIEW] " sgn
2021-03-24 13:10 ` [PR PATCH] [Updated] " radiden
2021-03-24 13:19 ` radiden
2021-03-24 13:26 ` radiden
2021-03-24 13:26 ` radiden
2021-03-25 15:17 ` endigma
2021-03-31 2:38 ` endigma
2021-03-31 18:42 ` [PR PATCH] [Updated] " endigma
2021-03-31 18:42 ` endigma
2021-03-31 18:43 ` endigma
2021-04-01 18:50 ` ahesford
2021-04-01 18:50 ` [PR PATCH] [Closed]: " ahesford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210312042146.4teHlogmg3PJwDpuw6_WKTNCNd4om8tt1SP-eg08y4I@z \
--to=endigma@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).