From: unspecd <unspecd@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: ppp: update to 2.4.9.
Date: Fri, 12 Mar 2021 05:33:58 +0100 [thread overview]
Message-ID: <20210312043358.8qdrusz2RsZZ9jhz3BdmUu7q7oaU9P6twhs0MOAATUk@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-29322@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1427 bytes --]
New comment by unspecd on void-packages repository
https://github.com/void-linux/void-packages/pull/29322#issuecomment-797227730
Comment:
> Can you explain the reason for the revbumps
```sh
# Template file for 'ppp'
# rev-bump:
# * NetworkManager
# * NetworkManager-pptp
# * NetworkManager-l2tp
# When update this package
```
> Do any of them dlopen the modules shipped by `ppp`?
This is definitely not the case. I assume you are talking about these modules:
```shell
$ xbps-query -Rf ppp | grep so
/usr/lib/pppd/2.4.7/minconn.so
/usr/lib/pppd/2.4.7/openl2tp.so
/usr/lib/pppd/2.4.7/passprompt.so
/usr/lib/pppd/2.4.7/passwordfd.so
/usr/lib/pppd/2.4.7/pppoatm.so
…
```
`README.pppoe` says:
```
4. Add the following line to /etc/ppp/options:
plugin pppoe.so
```
Now let's see some source code. File `pppd/options.c`:
```c
/*
* Valid arguments.
*/
option_t general_options[] = {
…
#ifdef PLUGIN
{ "plugin", o_special, (void *)loadplugin,
"Load a plug-in module into pppd", OPT_PRIV | OPT_A2LIST },
#endif
```
```c
#ifdef PLUGIN
static int
loadplugin(char **argv)
{
…
if (strchr(arg, '/') == 0) {
const char *base = _PATH_PLUGIN;
…
}
handle = dlopen(path, RTLD_GLOBAL | RTLD_NOW);
…
init = (void (*)(void))dlsym(handle, "plugin_init");
```
File `pppd/pathnames.c`:
```c
#define _PATH_PLUGIN DESTDIR "/lib/pppd/" VERSION
```
next prev parent reply other threads:[~2021-03-12 4:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 15:38 [PR PATCH] " unspecd
2021-03-08 15:46 ` [PR PATCH] [Updated] " unspecd
2021-03-08 16:19 ` unspecd
2021-03-08 19:50 ` ericonr
2021-03-09 5:19 ` [PR PATCH] [Updated] " unspecd
2021-03-11 15:43 ` unspecd
2021-03-11 20:07 ` ericonr
2021-03-11 20:09 ` ericonr
2021-03-12 4:33 ` unspecd [this message]
2021-03-12 5:32 ` unspecd
2021-03-12 5:35 ` unspecd
2021-03-12 5:37 ` [PR PATCH] [Updated] " unspecd
2021-03-12 20:00 ` [PR REVIEW] " ericonr
2021-03-13 5:04 ` [PR PATCH] [Updated] " unspecd
2021-03-13 5:06 ` [PR REVIEW] " unspecd
2021-03-17 13:30 ` [PR PATCH] [Merged]: " ericonr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210312043358.8qdrusz2RsZZ9jhz3BdmUu7q7oaU9P6twhs0MOAATUk@z \
--to=unspecd@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).