From: ajshell1 <ajshell1@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: New package: pcem-17
Date: Sat, 13 Mar 2021 19:05:36 +0100 [thread overview]
Message-ID: <20210313180536.iWK0zogWPKQX1Ji-1MQbfuGjz5qLxyIg1E6zz-UlBK4@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-29285@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1093 bytes --]
New comment by ajshell1 on void-packages repository
https://github.com/void-linux/void-packages/pull/29285#issuecomment-798716421
Comment:
I've just realized that this is a duplicate of pull request #22340
I'll admit to blatantly using some of his code to improve my own pull request. For example, I realized that the automake was unnecessary. Also, I dug through pcem's configure file and realized that it only accepts i386/i686, x86_64, armv7l, and aarch64 CPUs. For this reason, I thought it was appropriate to include those specific architectures in the template.
At this point, here are a list of substantial differences between our templates:
1. Mine thinks that the license is GPL2 only, he thinks it's GPL2 or later. I have no idea which is right.
2. Somewhat different method of assigning the distfiles variable
3. He uses do_extract() while I use create_wkspace, to the same effect.
4. He uses vdoc on the readme files and tested files.
5. Different short_desc
6. Different maintainer.
I don't particularly care which of us is selected, as long as one of us is.
next prev parent reply other threads:[~2021-03-13 18:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-07 0:43 [PR PATCH] " ajshell1
2021-03-07 0:44 ` [PR PATCH] [Updated] " ajshell1
2021-03-07 3:19 ` ajshell1
2021-03-13 16:07 ` ajshell1
2021-03-13 17:25 ` ajshell1
2021-03-13 17:38 ` [PR REVIEW] " ajshell1
2021-03-13 17:55 ` [PR PATCH] [Updated] " ajshell1
2021-03-13 18:05 ` ajshell1 [this message]
2021-03-28 16:42 ` ScrelliCopter
2021-11-06 23:12 ` abenson
2021-11-06 23:12 ` [PR PATCH] [Closed]: " abenson
-- strict thread matches above, loose matches on Subject: below --
2020-05-27 2:11 [PR PATCH] New package: pcem-16 ScrelliCopter
2021-11-06 23:12 ` New package: pcem-17 abenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210313180536.iWK0zogWPKQX1Ji-1MQbfuGjz5qLxyIg1E6zz-UlBK4@z \
--to=ajshell1@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).