From: gbrlsnchs <gbrlsnchs@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] minikube: set version metadata to program.
Date: Sat, 13 Mar 2021 22:26:29 +0100 [thread overview]
Message-ID: <20210313212629.3aAlN807OMCxazHK_dTJrMHm7qiWXQYvhqEihPPVyHM@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-29449@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1588 bytes --]
There is an updated pull request by gbrlsnchs against master on the void-packages repository
https://github.com/gbrlsnchs/void-packages minikube
https://github.com/void-linux/void-packages/pull/29449
minikube: set version metadata to program.
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/29449.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-minikube-29449.patch --]
[-- Type: text/x-diff, Size: 1445 bytes --]
From 05e7ed82e495a24828743be87c5215a842df6f7b Mon Sep 17 00:00:00 2001
From: Gabriel Sanches <gabriel@gsr.dev>
Date: Sat, 13 Mar 2021 18:10:33 -0300
Subject: [PATCH] minikube: set version metadata to program.
This commit makes the command `minikube version` return correct
information about the program, and not only a placeholder.
---
srcpkgs/minikube/template | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/minikube/template b/srcpkgs/minikube/template
index a091708aa97..46fcfbbccf7 100644
--- a/srcpkgs/minikube/template
+++ b/srcpkgs/minikube/template
@@ -1,10 +1,11 @@
# Template file for 'minikube'
pkgname=minikube
version=1.18.0
-revision=1
+revision=2
build_style=go
build_helper=qemu
go_import_path="k8s.io/minikube/cmd/minikube k8s.io/minikube/cmd/drivers/kvm"
+go_ldflags="-X k8s.io/minikube/pkg/version.version=v${version}"
hostmakedepends="go-bindata python pkg-config git"
makedepends="libvirt-devel"
depends="kubectl"
@@ -24,6 +25,13 @@ pre_configure() {
pre_build() {
make pkg/minikube/assets/assets.go pkg/minikube/translate/translations.go
+
+ # Set up correct commit information to be embedded in the CLI.
+ _tmpdir=$(mktemp -d)
+ git clone --depth 1 --branch v${version} https://github.com/kubernetes/minikube ${_tmpdir}
+ cd ${_tmpdir}
+ go_ldflags+=" -X k8s.io/minikube/pkg/version.gitCommitID=$(git rev-parse --short HEAD)"
+ rm -rf ${_tmpdir}
}
do_install() {
next prev parent reply other threads:[~2021-03-13 21:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-13 21:23 [PR PATCH] " gbrlsnchs
2021-03-13 21:26 ` gbrlsnchs [this message]
2021-03-14 0:28 ` [PR REVIEW] " sgn
2021-03-14 0:56 ` gbrlsnchs
2021-03-23 10:20 ` Gottox
2021-03-23 10:21 ` Gottox
2021-03-23 10:21 ` [PR PATCH] [Closed]: " Gottox
2021-03-23 13:40 ` [PR REVIEW] " gbrlsnchs
2021-03-23 13:41 ` gbrlsnchs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210313212629.3aAlN807OMCxazHK_dTJrMHm7qiWXQYvhqEihPPVyHM@z \
--to=gbrlsnchs@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).