From: yopito <yopito@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: Freecad: Update to 0.19.1
Date: Tue, 16 Mar 2021 23:37:18 +0100 [thread overview]
Message-ID: <20210316223718.IW-JH8GBFeLg5FtkWJfmKt5y2mCjYGmnquaJCeSDk_g@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-29466@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 3023 bytes --]
New comment by yopito on void-packages repository
https://github.com/void-linux/void-packages/pull/29466#issuecomment-800659268
Comment:
Comparing this PR with my freecad.current branch, I've noticed the points below.
This is a partial review, I have to compare other items (some patches and template file too).
`srcpkgs/freecad/patches/001-remove-python2.patch` is useless: don't need to build with python3.
`srcpkgs/freecad/patches/150-vtk9.patch` : content is out of date. suggestion:
```
Taken from https://github.com/wwmayer/FreeCAD/commit/bb9bcbd51df7c3cb76c5823038e4ea0f7e25a9ff
but removed patch on file src/Mod/Fem/Gui/ViewProviderFemPostObject.cpp : already applied (2021-01-20)
```
missing patch `srcpkgs/freecad/patches/152-cmake-vtk9.patch`:
```
--- cMake/FreeCAD_Helpers/SetupSalomeSMESH.cmake 2020-11-26 15:59:27.000000000 +0100
+++ cMake/FreeCAD_Helpers/SetupSalomeSMESH.cmake 2020-11-26 23:09:12.778262636 +0100
@@ -11,6 +11,8 @@
set(SMESH_VERSION_TWEAK 0)
#if we use smesh we definitely also need vtk, no matter of external or internal smesh
+ find_package(VTK REQUIRED NO_MODULE)
+ if(${VTK_MAJOR_VERSION} LESS 9)
set (VTK_COMPONENTS
vtkCommonCore
vtkCommonDataModel
@@ -23,18 +25,37 @@
vtkFiltersSources
vtkFiltersGeometry
)
-
- # check which modules are available
- if(UNIX OR WIN32)
find_package(VTK COMPONENTS vtkCommonCore REQUIRED NO_MODULE)
list(APPEND VTK_COMPONENTS vtkIOMPIParallel vtkParallelMPI vtkhdf5 vtkFiltersParallelDIY2 vtkRenderingCore vtkInteractionStyle vtkRenderingFreeType vtkRenderingOpenGL2)
+ else()
+ # VTK 9 changed its component names
+ set (VTK_COMPONENTS
+ CommonCore
+ CommonDataModel
+ FiltersVerdict
+ IOXML
+ FiltersCore
+ FiltersGeneral
+ IOLegacy
+ FiltersExtraction
+ FiltersSources
+ FiltersGeometry
+ )
+ find_package(VTK COMPONENTS CommonCore REQUIRED NO_MODULE)
+ list(APPEND VTK_COMPONENTS IOMPIParallel ParallelMPI hdf5 FiltersParallelDIY2 RenderingCore InteractionStyle RenderingFreeType RenderingOpenGL2)
+ endif()
+
+ # check which modules are available
foreach(_module ${VTK_COMPONENTS})
+ if(${VTK_MAJOR_VERSION} LESS 9)
list (FIND VTK_MODULES_ENABLED ${_module} _index)
+ else()
+ list (FIND VTK_AVAILABLE_COMPONENTS ${_module} _index)
+ endif()
if (${_index} GREATER -1)
list(APPEND AVAILABLE_VTK_COMPONENTS ${_module})
endif()
endforeach()
- endif()
# don't check VERSION 6 as this would exclude VERSION 7
if(AVAILABLE_VTK_COMPONENTS)
```
next prev parent reply other threads:[~2021-03-16 22:37 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 0:21 [PR PATCH] " sww1235
2021-03-15 0:32 ` ericonr
2021-03-15 22:44 ` sww1235
2021-03-16 1:57 ` [PR PATCH] [Updated] " sww1235
2021-03-16 2:00 ` sww1235
2021-03-16 19:05 ` yopito
2021-03-16 19:06 ` yopito
2021-03-16 20:27 ` karl-nilsson
2021-03-16 20:57 ` sww1235
2021-03-16 21:03 ` ericonr
2021-03-16 21:16 ` karl-nilsson
2021-03-16 21:43 ` yopito
2021-03-16 22:37 ` yopito [this message]
2021-03-16 23:28 ` sww1235
2021-03-16 23:29 ` sww1235
2021-03-16 23:33 ` sww1235
2021-03-17 19:07 ` yopito
2021-03-17 20:43 ` yopito
2021-03-18 1:58 ` sww1235
2021-03-18 19:31 ` yopito
2021-03-20 3:10 ` [PR PATCH] [Closed]: " sww1235
2021-03-20 3:11 ` sww1235
2021-03-19 7:02 [PR PATCH] [WIP] freecad: update " yopito
2021-03-21 17:55 ` yopito
2021-03-22 4:15 ` sww1235
2021-03-25 4:19 ` ericonr
2021-03-25 6:44 ` yopito
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210316223718.IW-JH8GBFeLg5FtkWJfmKt5y2mCjYGmnquaJCeSDk_g@z \
--to=yopito@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).