From: heliocat <heliocat@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: Allow busybox to provide ip/tc
Date: Thu, 18 Mar 2021 07:52:32 +0100 [thread overview]
Message-ID: <20210318065232.IHj33cf9wih-oPzJ0_fO2--asDJyl8VHx7fbKHNibnk@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-15836@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 508 bytes --]
New comment by heliocat on void-packages repository
https://github.com/void-linux/void-packages/pull/15836#issuecomment-801678384
Comment:
Shouldn't `test "$(readlink -f root/usr/bin/file)" = "pkg-b-file"` be `test "$(readlink root/usr/bin/file)" = "pkg-b-file"`? `realpath`/`readlink -f` will fully canonicalize the path and return an absolute which won't then pass the string equality test. I'll give the test a better pass when I've got some more time but I think there are a few logic issues in there.
next prev parent reply other threads:[~2021-03-18 6:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-27 20:13 [PR PATCH] " voidlinux-github
2021-03-17 20:16 ` heliocat
2021-03-17 20:17 ` heliocat
2021-03-18 3:58 ` CameronNemo
2021-03-18 3:59 ` CameronNemo
2021-03-18 6:52 ` heliocat [this message]
2021-03-19 7:28 ` heliocat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210318065232.IHj33cf9wih-oPzJ0_fO2--asDJyl8VHx7fbKHNibnk@z \
--to=heliocat@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).