Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] mbedtls: update to 2.16.10
@ 2021-03-13  6:35 unspecd
  2021-03-13 10:37 ` mobinmob
                   ` (7 more replies)
  0 siblings, 8 replies; 9+ messages in thread
From: unspecd @ 2021-03-13  6:35 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1608 bytes --]

There is a new pull request by unspecd against master on the void-packages repository

https://github.com/unspecd/void-packages pkg/mbedtls
https://github.com/void-linux/void-packages/pull/29430

mbedtls: update to 2.16.10
Also:
- Fix changelog location.
- Use scripts/config.pl instead of sed.

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, x86_64-musl
- [x] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [x] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl


A patch file from https://github.com/void-linux/void-packages/pull/29430.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pkg/mbedtls-29430.patch --]
[-- Type: text/x-diff, Size: 1588 bytes --]

From fe659963285bbbc84a50107e9a1688bebe9a05fe Mon Sep 17 00:00:00 2001
From: Evgeny Ermakov <evgeny.v.ermakov@gmail.com>
Date: Sat, 13 Mar 2021 17:26:59 +1100
Subject: [PATCH] mbedtls: update to 2.16.10

Also:
- Fix changelog location.
- Use scripts/config.pl instead of sed.
---
 srcpkgs/mbedtls/template | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/mbedtls/template b/srcpkgs/mbedtls/template
index 4793fa29f24..b3e635d83ab 100644
--- a/srcpkgs/mbedtls/template
+++ b/srcpkgs/mbedtls/template
@@ -1,7 +1,7 @@
 # Template file for 'mbedtls'
 pkgname=mbedtls
 reverts="2.17.0_1"
-version=2.16.9
+version=2.16.10
 revision=1
 wrksrc="mbedtls-mbedtls-${version}"
 build_style=cmake
@@ -11,15 +11,13 @@ short_desc="Portable cryptographic TLS library"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="Apache-2.0"
 homepage="https://tls.mbed.org/"
-changelog="https://raw.githubusercontent.com/ARMmbed/mbedtls/development/ChangeLog"
+changelog="https://raw.githubusercontent.com/ARMmbed/mbedtls/v{version}/ChangeLog"
 distfiles="https://github.com/ARMmbed/mbedtls/archive/mbedtls-${version}.tar.gz"
-checksum=b7ca99ee10551b5b13242b7effebefd2a5cc38c287e5f5be1267d51ee45effe3
-
+checksum=78c02e2d277a302454ada90274d16d80f88d761bdd4243528e4206cf7920be78
 
 pre_configure() {
-	sed -i include/mbedtls/config.h \
-		-e 's/.*\(#define MBEDTLS_THREADING_C\)/\1/' \
-		-e 's/.*\(#define MBEDTLS_THREADING_PTHREAD\)/\1/'
+	./scripts/config.pl set MBEDTLS_THREADING_C
+	./scripts/config.pl set MBEDTLS_THREADING_PTHREAD
 }
 
 mbedtls-utils_package() {

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: mbedtls: update to 2.16.10
  2021-03-13  6:35 [PR PATCH] mbedtls: update to 2.16.10 unspecd
@ 2021-03-13 10:37 ` mobinmob
  2021-03-13 10:37 ` mobinmob
                   ` (6 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: mobinmob @ 2021-03-13 10:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 332 bytes --]

New comment by mobinmob on void-packages repository

https://github.com/void-linux/void-packages/pull/29430#issuecomment-798126056

Comment:
Nice @unspecd !
This is un update in the TLS branch, so it should not break API/ABI. I see only a little change in the release notes, but I have no idea of it affects programms in the repo.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: mbedtls: update to 2.16.10
  2021-03-13  6:35 [PR PATCH] mbedtls: update to 2.16.10 unspecd
  2021-03-13 10:37 ` mobinmob
@ 2021-03-13 10:37 ` mobinmob
  2021-03-13 11:56 ` unspecd
                   ` (5 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: mobinmob @ 2021-03-13 10:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 332 bytes --]

New comment by mobinmob on void-packages repository

https://github.com/void-linux/void-packages/pull/29430#issuecomment-798126056

Comment:
Nice @unspecd !
This is un update in the LTS branch, so it should not break API/ABI. I see only a little change in the release notes, but I have no idea of it affects programms in the repo.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: mbedtls: update to 2.16.10
  2021-03-13  6:35 [PR PATCH] mbedtls: update to 2.16.10 unspecd
  2021-03-13 10:37 ` mobinmob
  2021-03-13 10:37 ` mobinmob
@ 2021-03-13 11:56 ` unspecd
  2021-03-15 19:30 ` unspecd
                   ` (4 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: unspecd @ 2021-03-13 11:56 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 188 bytes --]

New comment by unspecd on void-packages repository

https://github.com/void-linux/void-packages/pull/29430#issuecomment-798239633

Comment:
@mobinmob
I will check the affected packages. 

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: mbedtls: update to 2.16.10
  2021-03-13  6:35 [PR PATCH] mbedtls: update to 2.16.10 unspecd
                   ` (2 preceding siblings ...)
  2021-03-13 11:56 ` unspecd
@ 2021-03-15 19:30 ` unspecd
  2021-03-15 19:39 ` ericonr
                   ` (3 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: unspecd @ 2021-03-15 19:30 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 6234 bytes --]

New comment by unspecd on void-packages repository

https://github.com/void-linux/void-packages/pull/29430#issuecomment-799694502

Comment:
### Summary

`!` - affected
`^` - update available

| Package                       | Location                                                                                                                                                                                                                 | Reason                                                                                                                                                                                         |
|:------------------------------|:-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|:-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| bctoolbox<sup>!^</sup>        | [src/crypto/mbedtls.c](https://gitlab.linphone.org/BC/public/bctoolbox/-/blob/4.4.17/src/crypto/mbedtls.c): [1](https://gitlab.linphone.org/BC/public/bctoolbox/-/blob/4.4.17/src/crypto/mbedtls.c#L115-116), [2](https://gitlab.linphone.org/BC/public/bctoolbox/-/blob/4.4.17/src/crypto/mbedtls.c#L289-294) | [violates the contract](https://github.com/ARMmbed/mbedtls/commit/831956980c66b03ab00e2bdc0fbcc55f98bf5f02#diff-f77aa8299db40b4403be0b49ca6eca52ab4ee2a2f00bb200a798e07a89b25850R305-R306) |
| dislocker                     | -                                                                                                                                                                                                                        | -                                                                                                                                                                                              |
| dolphin-emu<sup>!</sup>       | [libcurl](https://github.com/curl/curl/blob/2f33be817cbce6ad7a36f27dd7ada9219f13584c/lib/vtls/mbedtls.c#L272-L298)                                                                                                                                                                                             | [violates the contract](https://github.com/ARMmbed/mbedtls/commit/831956980c66b03ab00e2bdc0fbcc55f98bf5f02#diff-f77aa8299db40b4403be0b49ca6eca52ab4ee2a2f00bb200a798e07a89b25850R305-R306) |
| godot                         | -                                                                                                                                                                                                                        | -                                                                                                                                                                                              |
| hiawatha<sup>!</sup>          | [src/tls.c](https://gitlab.com/hsleisink/hiawatha/-/blob/v10.11/src/tls.c#L279-282)                                                                                                                                   | [violates the contract](https://github.com/ARMmbed/mbedtls/commit/831956980c66b03ab00e2bdc0fbcc55f98bf5f02#diff-f77aa8299db40b4403be0b49ca6eca52ab4ee2a2f00bb200a798e07a89b25850R305-R306) |
| julia<sup>^</sup>             | [libcurl](https://github.com/curl/curl/blob/2f33be817cbce6ad7a36f27dd7ada9219f13584c/lib/vtls/mbedtls.c#L272-L298)                                                                                                                                                                                             | [violates the contract](https://github.com/ARMmbed/mbedtls/commit/831956980c66b03ab00e2bdc0fbcc55f98bf5f02#diff-f77aa8299db40b4403be0b49ca6eca52ab4ee2a2f00bb200a798e07a89b25850R305-R306) |
| obs                           | [plugins/obs-outputs/librtmp/rtmp.c](https://github.com/obsproject/obs-studio/blob/26.1.2/plugins/obs-outputs/librtmp/rtmp.c#L383-L390)                                                                               | [violates the contract](https://github.com/ARMmbed/mbedtls/commit/831956980c66b03ab00e2bdc0fbcc55f98bf5f02#diff-f77aa8299db40b4403be0b49ca6eca52ab4ee2a2f00bb200a798e07a89b25850R305-R306) |
| retroarch<sup>!</sup>         | [libretro-common/net/net_socket_ssl.c](https://github.com/libretro/RetroArch/blob/v1.9.0/libretro-common/net/net_socket_ssl.c#L91-L109)                                                                               | [violates the contract](https://github.com/ARMmbed/mbedtls/commit/831956980c66b03ab00e2bdc0fbcc55f98bf5f02#diff-f77aa8299db40b4403be0b49ca6eca52ab4ee2a2f00bb200a798e07a89b25850R305-R306) |
| rvault<sup>^</sup>            |                                                                                                                                                                                                                          | -                                                                                                                                                                                              |
| shadowsocks-libev<sup>^</sup> |                                                                                                                                                                                                                          | -                                                                                                                                                                                              |
| tpm2-tss<sup>^</sup>          |                                                                                                                                                                                                                          | -                                                                                                                                                                                              |


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: mbedtls: update to 2.16.10
  2021-03-13  6:35 [PR PATCH] mbedtls: update to 2.16.10 unspecd
                   ` (3 preceding siblings ...)
  2021-03-15 19:30 ` unspecd
@ 2021-03-15 19:39 ` ericonr
  2021-03-15 19:39 ` ericonr
                   ` (2 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: ericonr @ 2021-03-15 19:39 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 298 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29430#issuecomment-799699852

Comment:
What does this table mean? Do we need to update/fix these packages for the library update? Or is the issue new? A stable API shouldn't change the contract...

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: mbedtls: update to 2.16.10
  2021-03-13  6:35 [PR PATCH] mbedtls: update to 2.16.10 unspecd
                   ` (4 preceding siblings ...)
  2021-03-15 19:39 ` ericonr
@ 2021-03-15 19:39 ` ericonr
  2021-03-18  9:15 ` unspecd
  2021-04-03  4:45 ` [PR PATCH] [Closed]: " ericonr
  7 siblings, 0 replies; 9+ messages in thread
From: ericonr @ 2021-03-15 19:39 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29430#issuecomment-799699852

Comment:
What does this table mean? Do we need to update/fix these packages for the library update? Or is the issue not new? A stable update shouldn't change the contract...

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: mbedtls: update to 2.16.10
  2021-03-13  6:35 [PR PATCH] mbedtls: update to 2.16.10 unspecd
                   ` (5 preceding siblings ...)
  2021-03-15 19:39 ` ericonr
@ 2021-03-18  9:15 ` unspecd
  2021-04-03  4:45 ` [PR PATCH] [Closed]: " ericonr
  7 siblings, 0 replies; 9+ messages in thread
From: unspecd @ 2021-03-18  9:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 520 bytes --]

New comment by unspecd on void-packages repository

https://github.com/void-linux/void-packages/pull/29430#issuecomment-801760479

Comment:
Sorry for the delay.

At first, I thought it might be a leak in the function [mbedtls_ctr_drbg_seed](https://github.com/ARMmbed/mbedtls/blob/v2.16.10/library/ctr_drbg.c#L409), which in turn calls `pthread_mutex_init`, but then I found out that the latter does not allocate any resources.

So there is no need to update or fix these packages.

I'm sorry if I confused you.


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR PATCH] [Closed]: mbedtls: update to 2.16.10
  2021-03-13  6:35 [PR PATCH] mbedtls: update to 2.16.10 unspecd
                   ` (6 preceding siblings ...)
  2021-03-18  9:15 ` unspecd
@ 2021-04-03  4:45 ` ericonr
  7 siblings, 0 replies; 9+ messages in thread
From: ericonr @ 2021-04-03  4:45 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1453 bytes --]

There's a closed pull request on the void-packages repository

mbedtls: update to 2.16.10
https://github.com/void-linux/void-packages/pull/29430

Description:
Also:
- Fix changelog location.
- Use scripts/config.pl instead of sed.

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, x86_64-musl
- [x] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [x] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2021-04-03  4:45 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-13  6:35 [PR PATCH] mbedtls: update to 2.16.10 unspecd
2021-03-13 10:37 ` mobinmob
2021-03-13 10:37 ` mobinmob
2021-03-13 11:56 ` unspecd
2021-03-15 19:30 ` unspecd
2021-03-15 19:39 ` ericonr
2021-03-15 19:39 ` ericonr
2021-03-18  9:15 ` unspecd
2021-04-03  4:45 ` [PR PATCH] [Closed]: " ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).