From: Chocimier <Chocimier@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] CONTRIBUTING.md: be clearer about "one commit per PR" rule.
Date: Thu, 18 Mar 2021 20:18:16 +0100 [thread overview]
Message-ID: <20210318191816.LlYRuoWwEtqMrnNNaUB8qlYzjdTbg7sRdtgVxG8knuo@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-29568@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 310 bytes --]
New review comment by Chocimier on void-packages repository
https://github.com/void-linux/void-packages/pull/29568#discussion_r597170817
Comment:
"per package" was rarely interpreted as "per subpackage". Might we use "per package (with subpackages)" or "per template" or some longer form to make it clearer?
next prev parent reply other threads:[~2021-03-18 19:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 17:30 [PR PATCH] " ericonr
2021-03-18 18:25 ` [PR REVIEW] " Chocimier
2021-03-18 19:05 ` [PR PATCH] [Updated] " ericonr
2021-03-18 19:06 ` [PR REVIEW] " ericonr
2021-03-18 19:18 ` Chocimier [this message]
2021-03-24 2:03 ` [PR PATCH] [Updated] " ericonr
2021-03-24 2:03 ` ericonr
2021-03-24 3:13 ` [PR PATCH] [Merged]: " ericonr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210318191816.LlYRuoWwEtqMrnNNaUB8qlYzjdTbg7sRdtgVxG8knuo@z \
--to=chocimier@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).