From: Justinizer <Justinizer@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] New package: kleopatra:20.12.3
Date: Sun, 21 Mar 2021 10:39:17 +0100 [thread overview]
Message-ID: <20210321093917.RjSJBtY2AWQaSCkDDIG9MQnhNGhjf29L3ISVM6ivmuY@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-29605@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 2056 bytes --]
There is an updated pull request by Justinizer against master on the void-packages repository
https://github.com/Justinizer/void-packages master
https://github.com/void-linux/void-packages/pull/29605
New package: kleopatra:20.12.3
<!-- Mark items with [x] where applicable -->
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86-64)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
-----------------
- [ ] I had an issue with pinentry-qt. I had to insert into `~/.gnupg/gpg-agent.conf` following line:
` pinentry-program /usr/bin/pinentry-qt `
Otherwise kleopatra will throw errors in generating keys. Maybe this can be solved somehow.
According to the packager-README.md of the source files kleopatra doesn't work with pinentry-curses. But VoidLinux is using pinentry-curses per default, so this has to be changed for kleopatra.
A patch file from https://github.com/void-linux/void-packages/pull/29605.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-29605.patch --]
[-- Type: text/x-diff, Size: 7494 bytes --]
From 8ed5b30c727e8a027131dc5155d494627e4dafd0 Mon Sep 17 00:00:00 2001
From: Justin Jagieniak <justin@JustinPC.fritz.box>
Date: Sat, 20 Mar 2021 04:59:23 +0100
Subject: [PATCH 1/7] New package: kleopatra:20.12.3
---
srcpkgs/kleopatra/template | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
create mode 100644 srcpkgs/kleopatra/template
diff --git a/srcpkgs/kleopatra/template b/srcpkgs/kleopatra/template
new file mode 100644
index 000000000000..f79c201778cd
--- /dev/null
+++ b/srcpkgs/kleopatra/template
@@ -0,0 +1,20 @@
+# Template file for 'kleopatra'
+pkgname=kleopatra
+version=20.12.3
+revision=1
+archs="x86_64"
+build_style=cmake
+#configure_args=""
+#make_build_args=""
+#make_install_args=""
+#conf_files=""
+#make_dirs="/var/log/dir 0755 root root"
+hostmakedepends="extra-cmake-modules kdoctools boost"
+makedepends="kcmutils-devel AppStream gettext kitemmodels-devel gpgmeqt-devel libkleo-devel kmime-devel"
+depends="hicolor-icon-theme libkleo kcmutils kmime gnupg2 gnupg2-scdaemon pinentry-qt"
+short_desc="Certificate Manager and Unified Crypto GUI"
+maintainer="Justin Jagieniak <justin@jagieniak.net>"
+license="GPL-2.0-or-later, LGPL-2.1-or-later, GFDL-1.2-or-later"
+homepage="https://www.kde.org/applications/utilities/kleopatra/"
+distfiles="${KDE_SITE}/release-service/${version}/src/${pkgname}-${version}.tar.xz"
+checksum="bf30f99bc6abd44d512ca8c53a7e81af625db72547a33df5c581101d787feaa0"
From 65de2b7bcabf3fe87c57f0b1d2fa0f3f9213c72c Mon Sep 17 00:00:00 2001
From: Justin Jagieniak <justin@jagieniak.net>
Date: Sat, 20 Mar 2021 16:15:24 +0100
Subject: [PATCH 2/7] Resolve the commits by Johnnynator
---
srcpkgs/kleopatra/template | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/srcpkgs/kleopatra/template b/srcpkgs/kleopatra/template
index f79c201778cd..92cbfee5a352 100644
--- a/srcpkgs/kleopatra/template
+++ b/srcpkgs/kleopatra/template
@@ -2,14 +2,8 @@
pkgname=kleopatra
version=20.12.3
revision=1
-archs="x86_64"
build_style=cmake
-#configure_args=""
-#make_build_args=""
-#make_install_args=""
-#conf_files=""
-#make_dirs="/var/log/dir 0755 root root"
-hostmakedepends="extra-cmake-modules kdoctools boost"
+hostmakedepends="extra-cmake-modules kdoctools"
makedepends="kcmutils-devel AppStream gettext kitemmodels-devel gpgmeqt-devel libkleo-devel kmime-devel"
depends="hicolor-icon-theme libkleo kcmutils kmime gnupg2 gnupg2-scdaemon pinentry-qt"
short_desc="Certificate Manager and Unified Crypto GUI"
From d09e302592cc1714ce64620f932bf4e9371bd342 Mon Sep 17 00:00:00 2001
From: Justin Jagieniak <justin@jagieniak.net>
Date: Sat, 20 Mar 2021 18:03:09 +0100
Subject: [PATCH 3/7] add qt5-qmake as dependency
---
srcpkgs/kleopatra/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/kleopatra/template b/srcpkgs/kleopatra/template
index 92cbfee5a352..26642d5b43d6 100644
--- a/srcpkgs/kleopatra/template
+++ b/srcpkgs/kleopatra/template
@@ -2,9 +2,10 @@
pkgname=kleopatra
version=20.12.3
revision=1
+archs="x86_64,x86_64-musl,i686"
build_style=cmake
hostmakedepends="extra-cmake-modules kdoctools"
-makedepends="kcmutils-devel AppStream gettext kitemmodels-devel gpgmeqt-devel libkleo-devel kmime-devel"
+makedepends="kcmutils-devel AppStream gettext kitemmodels-devel gpgmeqt-devel libkleo-devel kmime-devel qt5-qmake"
depends="hicolor-icon-theme libkleo kcmutils kmime gnupg2 gnupg2-scdaemon pinentry-qt"
short_desc="Certificate Manager and Unified Crypto GUI"
maintainer="Justin Jagieniak <justin@jagieniak.net>"
From 1144706b6432b3eb500ccef6c2269ed2c085233d Mon Sep 17 00:00:00 2001
From: Justin Jagieniak <justin@jagieniak.net>
Date: Sat, 20 Mar 2021 18:04:03 +0100
Subject: [PATCH 4/7] remove archs
---
srcpkgs/kleopatra/template | 1 -
1 file changed, 1 deletion(-)
diff --git a/srcpkgs/kleopatra/template b/srcpkgs/kleopatra/template
index 26642d5b43d6..dfbc99989f4b 100644
--- a/srcpkgs/kleopatra/template
+++ b/srcpkgs/kleopatra/template
@@ -2,7 +2,6 @@
pkgname=kleopatra
version=20.12.3
revision=1
-archs="x86_64,x86_64-musl,i686"
build_style=cmake
hostmakedepends="extra-cmake-modules kdoctools"
makedepends="kcmutils-devel AppStream gettext kitemmodels-devel gpgmeqt-devel libkleo-devel kmime-devel qt5-qmake"
From 586537431b5ef8e982bd2ba8247428825f2a3cb8 Mon Sep 17 00:00:00 2001
From: Justin Jagieniak <justin@jagieniak.net>
Date: Sun, 21 Mar 2021 07:20:14 +0100
Subject: [PATCH 5/7] Add qt5-qmake and qt5-host-tools to hostmakedepends.
---
srcpkgs/kleopatra/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/kleopatra/template b/srcpkgs/kleopatra/template
index dfbc99989f4b..b92f9219bcd0 100644
--- a/srcpkgs/kleopatra/template
+++ b/srcpkgs/kleopatra/template
@@ -3,8 +3,8 @@ pkgname=kleopatra
version=20.12.3
revision=1
build_style=cmake
-hostmakedepends="extra-cmake-modules kdoctools"
-makedepends="kcmutils-devel AppStream gettext kitemmodels-devel gpgmeqt-devel libkleo-devel kmime-devel qt5-qmake"
+hostmakedepends="extra-cmake-modules kdoctools qt5-qmake qt5-host-tools"
+makedepends="kcmutils-devel AppStream gettext kitemmodels-devel gpgmeqt-devel libkleo-devel kmime-devel"
depends="hicolor-icon-theme libkleo kcmutils kmime gnupg2 gnupg2-scdaemon pinentry-qt"
short_desc="Certificate Manager and Unified Crypto GUI"
maintainer="Justin Jagieniak <justin@jagieniak.net>"
From ccfa9bd5d1d5497669163a90db46c7390f5b5971 Mon Sep 17 00:00:00 2001
From: Justin Jagieniak <justin@jagieniak.net>
Date: Sun, 21 Mar 2021 07:46:09 +0100
Subject: [PATCH 6/7] Add kcoreaddons to hostmakedepends.
---
srcpkgs/kleopatra/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/kleopatra/template b/srcpkgs/kleopatra/template
index b92f9219bcd0..dd49bd1be8a3 100644
--- a/srcpkgs/kleopatra/template
+++ b/srcpkgs/kleopatra/template
@@ -3,7 +3,7 @@ pkgname=kleopatra
version=20.12.3
revision=1
build_style=cmake
-hostmakedepends="extra-cmake-modules kdoctools qt5-qmake qt5-host-tools"
+hostmakedepends="extra-cmake-modules kdoctools qt5-qmake qt5-host-tools kcoreaddons"
makedepends="kcmutils-devel AppStream gettext kitemmodels-devel gpgmeqt-devel libkleo-devel kmime-devel"
depends="hicolor-icon-theme libkleo kcmutils kmime gnupg2 gnupg2-scdaemon pinentry-qt"
short_desc="Certificate Manager and Unified Crypto GUI"
From 357fe2d46724398899cf032d8a14b8cd4a7535fc Mon Sep 17 00:00:00 2001
From: Justin Jagieniak <justin@jagieniak.net>
Date: Sun, 21 Mar 2021 10:38:59 +0100
Subject: [PATCH 7/7] move gettext to hostdepends
---
srcpkgs/kleopatra/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/kleopatra/template b/srcpkgs/kleopatra/template
index dd49bd1be8a3..aac7898688c3 100644
--- a/srcpkgs/kleopatra/template
+++ b/srcpkgs/kleopatra/template
@@ -3,8 +3,8 @@ pkgname=kleopatra
version=20.12.3
revision=1
build_style=cmake
-hostmakedepends="extra-cmake-modules kdoctools qt5-qmake qt5-host-tools kcoreaddons"
-makedepends="kcmutils-devel AppStream gettext kitemmodels-devel gpgmeqt-devel libkleo-devel kmime-devel"
+hostmakedepends="extra-cmake-modules kdoctools qt5-qmake qt5-host-tools kcoreaddons gettext"
+makedepends="kcmutils-devel AppStream kitemmodels-devel gpgmeqt-devel libkleo-devel kmime-devel"
depends="hicolor-icon-theme libkleo kcmutils kmime gnupg2 gnupg2-scdaemon pinentry-qt"
short_desc="Certificate Manager and Unified Crypto GUI"
maintainer="Justin Jagieniak <justin@jagieniak.net>"
next prev parent reply other threads:[~2021-03-21 9:39 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-20 4:05 [PR PATCH] " Justinizer
2021-03-20 5:17 ` cinerea0
2021-03-20 14:30 ` [PR REVIEW] " Johnnynator
2021-03-20 14:30 ` Johnnynator
2021-03-20 14:30 ` Johnnynator
2021-03-20 15:15 ` [PR PATCH] [Updated] " Justinizer
2021-03-20 15:17 ` [PR REVIEW] " Justinizer
2021-03-20 15:29 ` Justinizer
2021-03-20 15:32 ` Justinizer
2021-03-20 15:32 ` ericonr
2021-03-20 15:33 ` ericonr
2021-03-20 15:34 ` Justinizer
2021-03-20 15:43 ` Justinizer
2021-03-20 16:13 ` Johnnynator
2021-03-20 17:03 ` [PR PATCH] [Updated] " Justinizer
2021-03-20 17:04 ` Justinizer
2021-03-20 17:36 ` [PR REVIEW] " Justinizer
2021-03-21 5:43 ` sgn
2021-03-21 6:20 ` [PR PATCH] [Updated] " Justinizer
2021-03-21 6:46 ` Justinizer
2021-03-21 7:00 ` [PR REVIEW] " Justinizer
2021-03-21 7:22 ` sgn
2021-03-21 9:39 ` Justinizer [this message]
2021-03-21 9:47 ` [PR PATCH] [Updated] " Justinizer
2021-03-21 10:00 ` Justinizer
2021-03-21 10:04 ` sgn
2021-03-21 10:05 ` sgn
2021-03-21 10:15 ` [PR PATCH] [Updated] " Justinizer
2021-03-21 11:40 ` [PR REVIEW] " Johnnynator
2021-03-21 11:40 ` Johnnynator
2021-03-21 15:06 ` [PR PATCH] [Updated] " Justinizer
2021-03-21 15:10 ` Justinizer
2021-03-21 15:13 ` Justinizer
2021-03-21 15:26 ` Justinizer
2021-03-21 15:28 ` Justinizer
2021-03-21 15:39 ` Justinizer
2021-03-21 15:55 ` Justinizer
2021-03-21 16:32 ` Justinizer
2021-03-21 17:00 ` [PR PATCH] [Merged]: " Johnnynator
2021-03-24 0:34 ` ericonr
2021-03-24 5:19 ` Justinizer
2021-03-24 6:00 ` Justinizer
2021-03-24 11:42 ` ericonr
2021-03-24 19:06 ` Justinizer
2021-03-24 19:08 ` ericonr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210321093917.RjSJBtY2AWQaSCkDDIG9MQnhNGhjf29L3ISVM6ivmuY@z \
--to=justinizer@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).