Github messages for voidlinux
 help / color / mirror / Atom feed
From: Oreo639 <Oreo639@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: wildmidi: update to 0.4.4
Date: Sun, 21 Mar 2021 22:17:13 +0100	[thread overview]
Message-ID: <20210321211713.RXNf-vq8_Vg8pLVpfu-VRNytqD5PPtT5ks0BnIIboAU@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-29668@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 599 bytes --]

New comment by Oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/29668#issuecomment-803660348

Comment:
The issue here is a different issue than before. The issue before is explained here:
https://github.com/Mindwerks/wildmidi/commit/ef50330257b60049b357e2729d88ddda82f4e5f6
The issue here is due to this:
https://github.com/Mindwerks/wildmidi/blob/master/src/wildmidi.c#L1999-L2000

(The issue here is that if you play a song and try to save as midi while playing a song, if there isn't a path separator in the name, it will try to read the wrong `argv[]`)

  parent reply	other threads:[~2021-03-21 21:17 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-21 20:00 [PR PATCH] " Oreo639
2021-03-21 20:02 ` Oreo639
2021-03-21 20:58 ` [PR REVIEW] " ericonr
2021-03-21 20:59 ` [PR PATCH] [Updated] " Oreo639
2021-03-21 21:00 ` Oreo639
2021-03-21 21:00 ` [PR REVIEW] " Oreo639
2021-03-21 21:00 ` Oreo639
2021-03-21 21:06 ` ericonr
2021-03-21 21:09 ` Oreo639
2021-03-21 21:10 ` Oreo639
2021-03-21 21:11 ` Oreo639
2021-03-21 21:12 ` Oreo639
2021-03-21 21:17 ` Oreo639 [this message]
2021-03-21 21:25 ` ericonr
2021-03-21 21:28 ` Oreo639
2021-03-21 21:33 ` Oreo639
2021-03-21 21:39 ` ericonr
2021-03-21 21:39 ` [PR PATCH] [Merged]: " ericonr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210321211713.RXNf-vq8_Vg8pLVpfu-VRNytqD5PPtT5ks0BnIIboAU@z \
    --to=oreo639@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).