Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] empathy: remove package.
@ 2021-02-21 22:24 ericonr
  2021-02-21 22:54 ` Gottox
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: ericonr @ 2021-02-21 22:24 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 2092 bytes --]

There is a new pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages empathy
https://github.com/void-linux/void-packages/pull/28963

empathy: remove package.
Has been abandonware for at least three years, as seen in [1].
This is not great for a network exposed messenger, though it hasn't
received any CVEs as far as I could find.

It is also a blocker for enchant 1.x removal, though this is easy to fix
with the patch from [2]. I decided not to go with this option for the
reason listed above.

[1] https://gitlab.gnome.org/GNOME/empathy/-/commit/37976f61d8dddc950a9b7d3b1417d784b331927f
[2] https://gitlab.gnome.org/GNOME/empathy/-/merge_requests/3

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28963.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-empathy-28963.patch --]
[-- Type: text/x-diff, Size: 3503 bytes --]

From cafa4838dd5c076ba42ec237c6edcd41d721d506 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Sun, 21 Feb 2021 19:18:53 -0300
Subject: [PATCH] empathy: remove package.

Has been abandonware for at least three years, as seen in [1].
This is not great for a network exposed messenger, though it hasn't
received any CVEs as far as I could find.

It is also a blocker for enchant 1.x removal, though this is easy to fix
with the patch from [2]. I decided not to go with this option for the
reason listed above.

[1] https://gitlab.gnome.org/GNOME/empathy/-/commit/37976f61d8dddc950a9b7d3b1417d784b331927f
[2] https://gitlab.gnome.org/GNOME/empathy/-/merge_requests/3
---
 srcpkgs/empathy/INSTALL.msg       |  8 --------
 srcpkgs/empathy/template          | 31 -------------------------------
 srcpkgs/removed-packages/template |  1 +
 3 files changed, 1 insertion(+), 39 deletions(-)
 delete mode 100644 srcpkgs/empathy/INSTALL.msg
 delete mode 100644 srcpkgs/empathy/template

diff --git a/srcpkgs/empathy/INSTALL.msg b/srcpkgs/empathy/INSTALL.msg
deleted file mode 100644
index de8e50ea3da..00000000000
--- a/srcpkgs/empathy/INSTALL.msg
+++ /dev/null
@@ -1,8 +0,0 @@
-Some optional packages must be installed for additional functionality:
-
-	- telepathy-butterfly for MSN support
-	- telepathy-gabble for XMPP/jabber support
-	- telepathy-haze for libpurple support
-	- telepathy-idle for IRC support
-	- telepathy-rakia for SIP support
-	- telepathy-salut for link-local XMPP support
diff --git a/srcpkgs/empathy/template b/srcpkgs/empathy/template
deleted file mode 100644
index 4e01bad39a3..00000000000
--- a/srcpkgs/empathy/template
+++ /dev/null
@@ -1,31 +0,0 @@
-# Template file for 'empathy'
-pkgname=empathy
-version=3.12.14
-revision=2
-build_style=gnu-configure
-configure_args="
- --enable-gst-1.0=yes --enable-gudev=yes --enable-spell=yes
- --disable-schemas-compile --disable-static --enable-goa=no
- --enable-ubuntu-online-accounts=no --enable-geocode=yes
- --enable-location=yes --enable-nautilus-sendto=no --enable-map=yes"
-hostmakedepends="pkg-config intltool itstool glib-devel libxslt geoclue2"
-makedepends="
- libcanberra-devel clutter-gst-devel clutter-gtk-devel
- telepathy-glib-devel telepathy-logger-devel libnotify-devel
- telepathy-farstream-devel telepathy-mission-control-devel
- evolution-data-server-devel geocode-glib-devel folks-devel
- webkit2gtk-devel libgudev-devel pulseaudio-devel cheese-devel
- enchant-devel NetworkManager-devel libchamplain-devel
- gnutls-devel gsettings-desktop-schemas-devel geoclue2-devel iso-codes"
-depends="gsettings-desktop-schemas>=3.12 iso-codes"
-short_desc="GNOME instant messaging client using the Telepathy framework"
-maintainer="Orphaned <orphan@voidlinux.org>"
-license="GPL-2.0-or-later, LGPL-2.1-or-later"
-homepage="http://live.gnome.org/Empathy"
-distfiles="${GNOME_SITE}/$pkgname/${version%.*}/$pkgname-$version.tar.xz"
-checksum=7d86942ce97edd10ade0e6ae6a210d35e4d627fe4d223377d71fd1840bc6e3a3
-disable_parallel_build=yes
-
-pre_configure() {
-	CFLAGS+=" -I$wrksrc/telepathy-account-widgets"
-}
diff --git a/srcpkgs/removed-packages/template b/srcpkgs/removed-packages/template
index 2d2338a8b9b..512b604f350 100644
--- a/srcpkgs/removed-packages/template
+++ b/srcpkgs/removed-packages/template
@@ -37,6 +37,7 @@ replaces="
  ebtables<=2.0.10.4_8
  eclipse-ecj<=4.9_3
  electron7<=7.3.3_1
+ empathy<=3.12.14_2
  enventor<=1.0.0_2
  epstopdf<=2.27_3
  fontmatrix<=0.6.0.20171228_2

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: empathy: remove package.
  2021-02-21 22:24 [PR PATCH] empathy: remove package ericonr
@ 2021-02-21 22:54 ` Gottox
  2021-03-22  1:04 ` [PR PATCH] [Closed]: " ericonr
  2021-03-22  1:04 ` ericonr
  2 siblings, 0 replies; 4+ messages in thread
From: Gottox @ 2021-02-21 22:54 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 342 bytes --]

New comment by Gottox on void-packages repository

https://github.com/void-linux/void-packages/pull/28963#issuecomment-782943265

Comment:
I would keep it for now. I would guess, that there are a bunch of users that are still using it.

Just to get an idea, I set up a twitter poll: https://twitter.com/VoidLinux/status/1363622828457811970

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PR PATCH] [Closed]: empathy: remove package.
  2021-02-21 22:24 [PR PATCH] empathy: remove package ericonr
  2021-02-21 22:54 ` Gottox
@ 2021-03-22  1:04 ` ericonr
  2021-03-22  1:04 ` ericonr
  2 siblings, 0 replies; 4+ messages in thread
From: ericonr @ 2021-03-22  1:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1941 bytes --]

There's a closed pull request on the void-packages repository

empathy: remove package.
https://github.com/void-linux/void-packages/pull/28963

Description:
Has been abandonware for at least three years, as seen in [1].
This is not great for a network exposed messenger, though it hasn't
received any CVEs as far as I could find.

It is also a blocker for enchant 1.x removal, though this is easy to fix
with the patch from [2]. I decided not to go with this option for the
reason listed above.

[1] https://gitlab.gnome.org/GNOME/empathy/-/commit/37976f61d8dddc950a9b7d3b1417d784b331927f
[2] https://gitlab.gnome.org/GNOME/empathy/-/merge_requests/3

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: empathy: remove package.
  2021-02-21 22:24 [PR PATCH] empathy: remove package ericonr
  2021-02-21 22:54 ` Gottox
  2021-03-22  1:04 ` [PR PATCH] [Closed]: " ericonr
@ 2021-03-22  1:04 ` ericonr
  2 siblings, 0 replies; 4+ messages in thread
From: ericonr @ 2021-03-22  1:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 158 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28963#issuecomment-803698717

Comment:
Closed in #29598 

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-03-22  1:04 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-21 22:24 [PR PATCH] empathy: remove package ericonr
2021-02-21 22:54 ` Gottox
2021-03-22  1:04 ` [PR PATCH] [Closed]: " ericonr
2021-03-22  1:04 ` ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).