Re: [PR PATCH] [Updated] PulseEffects5

[paper42 <paper42@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 1885 bytes --]

There is an updated pull request by paper42 against master on the void-packages repository

https://github.com/paper42/void-packages pulseeffects5
https://github.com/void-linux/void-packages/pull/29638

PulseEffects5
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

PulseEffects 5 only supports PipeWire, so I made a new package `pulseeffects-legacy` which will stay on the PulseEffects 4. This approach is similar to what other distributions have done. I also added an install message to pulseeffects to let users know about this change.

related issue: #29006

A patch file from https://github.com/void-linux/void-packages/pull/29638.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pulseeffects5-29638.patch --]
[-- Type: text/x-diff, Size: 3985 bytes --]

From bd808fe0fb05ab1119794bfc8fb59802b4204fec Mon Sep 17 00:00:00 2001
From: Paper <paper@tilde.institute>
Date: Mon, 22 Mar 2021 22:49:03 +0100
Subject: [PATCH 1/2] New package: pulseeffects-legacy-4.8.5

---
 srcpkgs/pulseeffects-legacy/template | 20 ++++++++++++++++++++
 srcpkgs/pulseeffects-legacy/update   |  1 +
 2 files changed, 21 insertions(+)
 create mode 100644 srcpkgs/pulseeffects-legacy/template
 create mode 100644 srcpkgs/pulseeffects-legacy/update

diff --git a/srcpkgs/pulseeffects-legacy/template b/srcpkgs/pulseeffects-legacy/template
new file mode 100644
index 000000000000..ba73e829cb4c
--- /dev/null
+++ b/srcpkgs/pulseeffects-legacy/template
@@ -0,0 +1,20 @@
+# Template file for 'pulseeffects-legacy'
+pkgname=pulseeffects-legacy
+version=4.8.5
+revision=1
+wrksrc="pulseeffects-${version}"
+build_style=meson
+hostmakedepends="itstool pkg-config gettext"
+makedepends="boost-devel glib-devel gsettings-desktop-schemas-devel
+ gst-plugins-bad1-devel gtkmm-devel libebur128-devel lilv-devel
+ pulseaudio-devel python3-gobject-devel sratom-devel
+ libsndfile-devel"
+depends="calf gsettings-desktop-schemas gst-plugins-bad1
+ gst-plugins-good1 pulseaudio python3-gobject python3-scipy"
+short_desc="Sound effects for systems using PulseAudio (legacy)"
+maintainer="Orphaned <orphan@voidlinux.org>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/wwmm/pulseeffects"
+distfiles="https://github.com/wwmm/pulseeffects/archive/v${version}.tar.gz"
+checksum=df1c4c4a9811c62a549822dacde3a9e36233ba3ec58817ae52a236f6181a507c
+python_version=3
diff --git a/srcpkgs/pulseeffects-legacy/update b/srcpkgs/pulseeffects-legacy/update
new file mode 100644
index 000000000000..2638b2b10b6e
--- /dev/null
+++ b/srcpkgs/pulseeffects-legacy/update
@@ -0,0 +1 @@
+ignore="5.*"

From b3e1d8fde319efb204661579899aa423c054802f Mon Sep 17 00:00:00 2001
From: Paper <paper@tilde.institute>
Date: Sat, 20 Mar 2021 23:54:16 +0100
Subject: [PATCH 2/2] pulseeffects: update to 5.0.3

---
 srcpkgs/pulseeffects/INSTALL.msg |  2 ++
 srcpkgs/pulseeffects/template    | 14 +++++++-------
 2 files changed, 9 insertions(+), 7 deletions(-)
 create mode 100644 srcpkgs/pulseeffects/INSTALL.msg

diff --git a/srcpkgs/pulseeffects/INSTALL.msg b/srcpkgs/pulseeffects/INSTALL.msg
new file mode 100644
index 000000000000..e564d056c163
--- /dev/null
+++ b/srcpkgs/pulseeffects/INSTALL.msg
@@ -0,0 +1,2 @@
+PulseEffects 5+ supports only PipeWire and drops support for PulseAudio.
+If you want to use PulseEffects with PulseAudio, install pulseeffects-legacy.
diff --git a/srcpkgs/pulseeffects/template b/srcpkgs/pulseeffects/template
index a06f3042d97f..e3e13e60636b 100644
--- a/srcpkgs/pulseeffects/template
+++ b/srcpkgs/pulseeffects/template
@@ -1,19 +1,19 @@
 # Template file for 'pulseeffects'
 pkgname=pulseeffects
-version=4.8.4
+version=5.0.3
 revision=1
 build_style=meson
 hostmakedepends="itstool pkg-config gettext"
 makedepends="boost-devel glib-devel gsettings-desktop-schemas-devel
  gst-plugins-bad1-devel gtkmm-devel libebur128-devel lilv-devel
- pulseaudio-devel python3-gobject-devel sratom-devel
- libsndfile-devel"
+ pipewire-devel python3-gobject-devel sratom-devel zita-convolver-devel
+ libsndfile-devel libbs2b-devel"
 depends="calf gsettings-desktop-schemas gst-plugins-bad1
- gst-plugins-good1 pulseaudio python3-gobject python3-scipy"
-short_desc="Sound effects for Pulseaudio applications"
+ gst-plugins-good1 pipewire python3-gobject python3-scipy zita-convolver"
+short_desc="Sound effects for systems using PipeWire"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-3.0-or-later"
 homepage="https://github.com/wwmm/pulseeffects"
-distfiles="https://github.com/wwmm/pulseeffects/archive/${version}.tar.gz"
-checksum=12ba3205025d815a747b58636861594f7d1e43a578a5b0411f7794f4c12e5d86
+distfiles="https://github.com/wwmm/pulseeffects/archive/v${version}.tar.gz"
+checksum=2e14858918b54bee5f6e4898cc803ae2170b4d624407fef39e0831b6584c4a4f
 python_version=3