* [PR PATCH] PulseEffects5
@ 2021-03-20 23:06 paper42
2021-03-21 0:26 ` PulseEffects5 ericonr
` (12 more replies)
0 siblings, 13 replies; 14+ messages in thread
From: paper42 @ 2021-03-20 23:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1880 bytes --]
There is a new pull request by paper42 against master on the void-packages repository
https://github.com/paper42/void-packages pulseeffects5
https://github.com/void-linux/void-packages/pull/29638
PulseEffects5
<!-- Mark items with [x] where applicable -->
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
PulseEffects 5 only supports PipeWire, so I made a new package `pulseeffects-legacy` which will stay on the PulseEffects 4. This approach is similar to what other distributions have done. I also added an install message to pulseeffects to let users know about this change.
related issue: #29006
A patch file from https://github.com/void-linux/void-packages/pull/29638.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pulseeffects5-29638.patch --]
[-- Type: text/x-diff, Size: 3662 bytes --]
From 308e50b69c0e921b5c27f60ded6a37a352828714 Mon Sep 17 00:00:00 2001
From: Paper <paper@tilde.institute>
Date: Sat, 20 Mar 2021 23:51:51 +0100
Subject: [PATCH 1/2] New package: pulseeffects-legacy-4.8.5
---
srcpkgs/pulseeffects-legacy/template | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
create mode 100644 srcpkgs/pulseeffects-legacy/template
diff --git a/srcpkgs/pulseeffects-legacy/template b/srcpkgs/pulseeffects-legacy/template
new file mode 100644
index 000000000000..ba73e829cb4c
--- /dev/null
+++ b/srcpkgs/pulseeffects-legacy/template
@@ -0,0 +1,20 @@
+# Template file for 'pulseeffects-legacy'
+pkgname=pulseeffects-legacy
+version=4.8.5
+revision=1
+wrksrc="pulseeffects-${version}"
+build_style=meson
+hostmakedepends="itstool pkg-config gettext"
+makedepends="boost-devel glib-devel gsettings-desktop-schemas-devel
+ gst-plugins-bad1-devel gtkmm-devel libebur128-devel lilv-devel
+ pulseaudio-devel python3-gobject-devel sratom-devel
+ libsndfile-devel"
+depends="calf gsettings-desktop-schemas gst-plugins-bad1
+ gst-plugins-good1 pulseaudio python3-gobject python3-scipy"
+short_desc="Sound effects for systems using PulseAudio (legacy)"
+maintainer="Orphaned <orphan@voidlinux.org>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/wwmm/pulseeffects"
+distfiles="https://github.com/wwmm/pulseeffects/archive/v${version}.tar.gz"
+checksum=df1c4c4a9811c62a549822dacde3a9e36233ba3ec58817ae52a236f6181a507c
+python_version=3
From 8d874dc1360b4e949084f1c19a4eab2243907eab Mon Sep 17 00:00:00 2001
From: Paper <paper@tilde.institute>
Date: Sat, 20 Mar 2021 23:54:16 +0100
Subject: [PATCH 2/2] pulseeffects: update to 5.0.3
---
srcpkgs/pulseeffects/INSTALL.msg | 2 ++
srcpkgs/pulseeffects/template | 14 +++++++-------
2 files changed, 9 insertions(+), 7 deletions(-)
create mode 100644 srcpkgs/pulseeffects/INSTALL.msg
diff --git a/srcpkgs/pulseeffects/INSTALL.msg b/srcpkgs/pulseeffects/INSTALL.msg
new file mode 100644
index 000000000000..e564d056c163
--- /dev/null
+++ b/srcpkgs/pulseeffects/INSTALL.msg
@@ -0,0 +1,2 @@
+PulseEffects 5+ supports only PipeWire and drops support for PulseAudio.
+If you want to use PulseEffects with PulseAudio, install pulseeffects-legacy.
diff --git a/srcpkgs/pulseeffects/template b/srcpkgs/pulseeffects/template
index a06f3042d97f..e3e13e60636b 100644
--- a/srcpkgs/pulseeffects/template
+++ b/srcpkgs/pulseeffects/template
@@ -1,19 +1,19 @@
# Template file for 'pulseeffects'
pkgname=pulseeffects
-version=4.8.4
+version=5.0.3
revision=1
build_style=meson
hostmakedepends="itstool pkg-config gettext"
makedepends="boost-devel glib-devel gsettings-desktop-schemas-devel
gst-plugins-bad1-devel gtkmm-devel libebur128-devel lilv-devel
- pulseaudio-devel python3-gobject-devel sratom-devel
- libsndfile-devel"
+ pipewire-devel python3-gobject-devel sratom-devel zita-convolver-devel
+ libsndfile-devel libbs2b-devel"
depends="calf gsettings-desktop-schemas gst-plugins-bad1
- gst-plugins-good1 pulseaudio python3-gobject python3-scipy"
-short_desc="Sound effects for Pulseaudio applications"
+ gst-plugins-good1 pipewire python3-gobject python3-scipy zita-convolver"
+short_desc="Sound effects for systems using PipeWire"
maintainer="Orphaned <orphan@voidlinux.org>"
license="GPL-3.0-or-later"
homepage="https://github.com/wwmm/pulseeffects"
-distfiles="https://github.com/wwmm/pulseeffects/archive/${version}.tar.gz"
-checksum=12ba3205025d815a747b58636861594f7d1e43a578a5b0411f7794f4c12e5d86
+distfiles="https://github.com/wwmm/pulseeffects/archive/v${version}.tar.gz"
+checksum=2e14858918b54bee5f6e4898cc803ae2170b4d624407fef39e0831b6584c4a4f
python_version=3
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: PulseEffects5
2021-03-20 23:06 [PR PATCH] PulseEffects5 paper42
@ 2021-03-21 0:26 ` ericonr
2021-03-22 21:11 ` PulseEffects5 ericonr
` (11 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: ericonr @ 2021-03-21 0:26 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 183 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/29638#issuecomment-803490336
Comment:
This looks like a reasonable path forward.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: PulseEffects5
2021-03-20 23:06 [PR PATCH] PulseEffects5 paper42
2021-03-21 0:26 ` PulseEffects5 ericonr
@ 2021-03-22 21:11 ` ericonr
2021-03-22 21:52 ` [PR PATCH] [Updated] PulseEffects5 paper42
` (10 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: ericonr @ 2021-03-22 21:11 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 320 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/29638#issuecomment-804397964
Comment:
Could you please add an `update` file to the legacy package? That way we can pick up any security updates, if they happen (I believe the dev said they could do security releases).
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PR PATCH] [Updated] PulseEffects5
2021-03-20 23:06 [PR PATCH] PulseEffects5 paper42
2021-03-21 0:26 ` PulseEffects5 ericonr
2021-03-22 21:11 ` PulseEffects5 ericonr
@ 2021-03-22 21:52 ` paper42
2021-03-22 21:56 ` paper42
` (9 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: paper42 @ 2021-03-22 21:52 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1885 bytes --]
There is an updated pull request by paper42 against master on the void-packages repository
https://github.com/paper42/void-packages pulseeffects5
https://github.com/void-linux/void-packages/pull/29638
PulseEffects5
<!-- Mark items with [x] where applicable -->
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
PulseEffects 5 only supports PipeWire, so I made a new package `pulseeffects-legacy` which will stay on the PulseEffects 4. This approach is similar to what other distributions have done. I also added an install message to pulseeffects to let users know about this change.
related issue: #29006
A patch file from https://github.com/void-linux/void-packages/pull/29638.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pulseeffects5-29638.patch --]
[-- Type: text/x-diff, Size: 3985 bytes --]
From bd808fe0fb05ab1119794bfc8fb59802b4204fec Mon Sep 17 00:00:00 2001
From: Paper <paper@tilde.institute>
Date: Mon, 22 Mar 2021 22:49:03 +0100
Subject: [PATCH 1/2] New package: pulseeffects-legacy-4.8.5
---
srcpkgs/pulseeffects-legacy/template | 20 ++++++++++++++++++++
srcpkgs/pulseeffects-legacy/update | 1 +
2 files changed, 21 insertions(+)
create mode 100644 srcpkgs/pulseeffects-legacy/template
create mode 100644 srcpkgs/pulseeffects-legacy/update
diff --git a/srcpkgs/pulseeffects-legacy/template b/srcpkgs/pulseeffects-legacy/template
new file mode 100644
index 000000000000..ba73e829cb4c
--- /dev/null
+++ b/srcpkgs/pulseeffects-legacy/template
@@ -0,0 +1,20 @@
+# Template file for 'pulseeffects-legacy'
+pkgname=pulseeffects-legacy
+version=4.8.5
+revision=1
+wrksrc="pulseeffects-${version}"
+build_style=meson
+hostmakedepends="itstool pkg-config gettext"
+makedepends="boost-devel glib-devel gsettings-desktop-schemas-devel
+ gst-plugins-bad1-devel gtkmm-devel libebur128-devel lilv-devel
+ pulseaudio-devel python3-gobject-devel sratom-devel
+ libsndfile-devel"
+depends="calf gsettings-desktop-schemas gst-plugins-bad1
+ gst-plugins-good1 pulseaudio python3-gobject python3-scipy"
+short_desc="Sound effects for systems using PulseAudio (legacy)"
+maintainer="Orphaned <orphan@voidlinux.org>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/wwmm/pulseeffects"
+distfiles="https://github.com/wwmm/pulseeffects/archive/v${version}.tar.gz"
+checksum=df1c4c4a9811c62a549822dacde3a9e36233ba3ec58817ae52a236f6181a507c
+python_version=3
diff --git a/srcpkgs/pulseeffects-legacy/update b/srcpkgs/pulseeffects-legacy/update
new file mode 100644
index 000000000000..2638b2b10b6e
--- /dev/null
+++ b/srcpkgs/pulseeffects-legacy/update
@@ -0,0 +1 @@
+ignore="5.*"
From b3e1d8fde319efb204661579899aa423c054802f Mon Sep 17 00:00:00 2001
From: Paper <paper@tilde.institute>
Date: Sat, 20 Mar 2021 23:54:16 +0100
Subject: [PATCH 2/2] pulseeffects: update to 5.0.3
---
srcpkgs/pulseeffects/INSTALL.msg | 2 ++
srcpkgs/pulseeffects/template | 14 +++++++-------
2 files changed, 9 insertions(+), 7 deletions(-)
create mode 100644 srcpkgs/pulseeffects/INSTALL.msg
diff --git a/srcpkgs/pulseeffects/INSTALL.msg b/srcpkgs/pulseeffects/INSTALL.msg
new file mode 100644
index 000000000000..e564d056c163
--- /dev/null
+++ b/srcpkgs/pulseeffects/INSTALL.msg
@@ -0,0 +1,2 @@
+PulseEffects 5+ supports only PipeWire and drops support for PulseAudio.
+If you want to use PulseEffects with PulseAudio, install pulseeffects-legacy.
diff --git a/srcpkgs/pulseeffects/template b/srcpkgs/pulseeffects/template
index a06f3042d97f..e3e13e60636b 100644
--- a/srcpkgs/pulseeffects/template
+++ b/srcpkgs/pulseeffects/template
@@ -1,19 +1,19 @@
# Template file for 'pulseeffects'
pkgname=pulseeffects
-version=4.8.4
+version=5.0.3
revision=1
build_style=meson
hostmakedepends="itstool pkg-config gettext"
makedepends="boost-devel glib-devel gsettings-desktop-schemas-devel
gst-plugins-bad1-devel gtkmm-devel libebur128-devel lilv-devel
- pulseaudio-devel python3-gobject-devel sratom-devel
- libsndfile-devel"
+ pipewire-devel python3-gobject-devel sratom-devel zita-convolver-devel
+ libsndfile-devel libbs2b-devel"
depends="calf gsettings-desktop-schemas gst-plugins-bad1
- gst-plugins-good1 pulseaudio python3-gobject python3-scipy"
-short_desc="Sound effects for Pulseaudio applications"
+ gst-plugins-good1 pipewire python3-gobject python3-scipy zita-convolver"
+short_desc="Sound effects for systems using PipeWire"
maintainer="Orphaned <orphan@voidlinux.org>"
license="GPL-3.0-or-later"
homepage="https://github.com/wwmm/pulseeffects"
-distfiles="https://github.com/wwmm/pulseeffects/archive/${version}.tar.gz"
-checksum=12ba3205025d815a747b58636861594f7d1e43a578a5b0411f7794f4c12e5d86
+distfiles="https://github.com/wwmm/pulseeffects/archive/v${version}.tar.gz"
+checksum=2e14858918b54bee5f6e4898cc803ae2170b4d624407fef39e0831b6584c4a4f
python_version=3
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PR PATCH] [Updated] PulseEffects5
2021-03-20 23:06 [PR PATCH] PulseEffects5 paper42
` (2 preceding siblings ...)
2021-03-22 21:52 ` [PR PATCH] [Updated] PulseEffects5 paper42
@ 2021-03-22 21:56 ` paper42
2021-03-22 21:57 ` PulseEffects5 paper42
` (8 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: paper42 @ 2021-03-22 21:56 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1885 bytes --]
There is an updated pull request by paper42 against master on the void-packages repository
https://github.com/paper42/void-packages pulseeffects5
https://github.com/void-linux/void-packages/pull/29638
PulseEffects5
<!-- Mark items with [x] where applicable -->
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
PulseEffects 5 only supports PipeWire, so I made a new package `pulseeffects-legacy` which will stay on the PulseEffects 4. This approach is similar to what other distributions have done. I also added an install message to pulseeffects to let users know about this change.
related issue: #29006
A patch file from https://github.com/void-linux/void-packages/pull/29638.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pulseeffects5-29638.patch --]
[-- Type: text/x-diff, Size: 4012 bytes --]
From 8da4b43e3cdcc2366592d7278e847d7f8a7e0b76 Mon Sep 17 00:00:00 2001
From: Paper <paper@tilde.institute>
Date: Mon, 22 Mar 2021 22:49:03 +0100
Subject: [PATCH 1/2] New package: pulseeffects-legacy-4.8.5
---
srcpkgs/pulseeffects-legacy/template | 21 +++++++++++++++++++++
srcpkgs/pulseeffects-legacy/update | 1 +
2 files changed, 22 insertions(+)
create mode 100644 srcpkgs/pulseeffects-legacy/template
create mode 100644 srcpkgs/pulseeffects-legacy/update
diff --git a/srcpkgs/pulseeffects-legacy/template b/srcpkgs/pulseeffects-legacy/template
new file mode 100644
index 000000000000..c38c8ef2d9ef
--- /dev/null
+++ b/srcpkgs/pulseeffects-legacy/template
@@ -0,0 +1,21 @@
+# Template file for 'pulseeffects-legacy'
+pkgname=pulseeffects-legacy
+version=4.8.5
+revision=1
+wrksrc="pulseeffects-${version}"
+build_style=meson
+hostmakedepends="itstool pkg-config gettext"
+makedepends="boost-devel glib-devel gsettings-desktop-schemas-devel
+ gst-plugins-bad1-devel gtkmm-devel libebur128-devel lilv-devel
+ pulseaudio-devel python3-gobject-devel sratom-devel
+ libsndfile-devel"
+depends="calf gsettings-desktop-schemas gst-plugins-bad1
+ gst-plugins-good1 pulseaudio python3-gobject python3-scipy"
+short_desc="Sound effects for systems using PulseAudio (legacy)"
+maintainer="Orphaned <orphan@voidlinux.org>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/wwmm/pulseeffects"
+distfiles="https://github.com/wwmm/pulseeffects/archive/v${version}.tar.gz"
+checksum=df1c4c4a9811c62a549822dacde3a9e36233ba3ec58817ae52a236f6181a507c
+python_version=3
+conflicts="pulseeffects"
diff --git a/srcpkgs/pulseeffects-legacy/update b/srcpkgs/pulseeffects-legacy/update
new file mode 100644
index 000000000000..2638b2b10b6e
--- /dev/null
+++ b/srcpkgs/pulseeffects-legacy/update
@@ -0,0 +1 @@
+ignore="5.*"
From 3edff4546ca63a7b6f6328b4660e314682293544 Mon Sep 17 00:00:00 2001
From: Paper <paper@tilde.institute>
Date: Sat, 20 Mar 2021 23:54:16 +0100
Subject: [PATCH 2/2] pulseeffects: update to 5.0.3
---
srcpkgs/pulseeffects/INSTALL.msg | 2 ++
srcpkgs/pulseeffects/template | 14 +++++++-------
2 files changed, 9 insertions(+), 7 deletions(-)
create mode 100644 srcpkgs/pulseeffects/INSTALL.msg
diff --git a/srcpkgs/pulseeffects/INSTALL.msg b/srcpkgs/pulseeffects/INSTALL.msg
new file mode 100644
index 000000000000..e564d056c163
--- /dev/null
+++ b/srcpkgs/pulseeffects/INSTALL.msg
@@ -0,0 +1,2 @@
+PulseEffects 5+ supports only PipeWire and drops support for PulseAudio.
+If you want to use PulseEffects with PulseAudio, install pulseeffects-legacy.
diff --git a/srcpkgs/pulseeffects/template b/srcpkgs/pulseeffects/template
index a06f3042d97f..e3e13e60636b 100644
--- a/srcpkgs/pulseeffects/template
+++ b/srcpkgs/pulseeffects/template
@@ -1,19 +1,19 @@
# Template file for 'pulseeffects'
pkgname=pulseeffects
-version=4.8.4
+version=5.0.3
revision=1
build_style=meson
hostmakedepends="itstool pkg-config gettext"
makedepends="boost-devel glib-devel gsettings-desktop-schemas-devel
gst-plugins-bad1-devel gtkmm-devel libebur128-devel lilv-devel
- pulseaudio-devel python3-gobject-devel sratom-devel
- libsndfile-devel"
+ pipewire-devel python3-gobject-devel sratom-devel zita-convolver-devel
+ libsndfile-devel libbs2b-devel"
depends="calf gsettings-desktop-schemas gst-plugins-bad1
- gst-plugins-good1 pulseaudio python3-gobject python3-scipy"
-short_desc="Sound effects for Pulseaudio applications"
+ gst-plugins-good1 pipewire python3-gobject python3-scipy zita-convolver"
+short_desc="Sound effects for systems using PipeWire"
maintainer="Orphaned <orphan@voidlinux.org>"
license="GPL-3.0-or-later"
homepage="https://github.com/wwmm/pulseeffects"
-distfiles="https://github.com/wwmm/pulseeffects/archive/${version}.tar.gz"
-checksum=12ba3205025d815a747b58636861594f7d1e43a578a5b0411f7794f4c12e5d86
+distfiles="https://github.com/wwmm/pulseeffects/archive/v${version}.tar.gz"
+checksum=2e14858918b54bee5f6e4898cc803ae2170b4d624407fef39e0831b6584c4a4f
python_version=3
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: PulseEffects5
2021-03-20 23:06 [PR PATCH] PulseEffects5 paper42
` (3 preceding siblings ...)
2021-03-22 21:56 ` paper42
@ 2021-03-22 21:57 ` paper42
2021-04-03 17:34 ` PulseEffects5 GameWizard5000
` (7 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: paper42 @ 2021-03-22 21:57 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 207 bytes --]
New comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/29638#issuecomment-804422544
Comment:
thanks, I also made pulseeffects-legacy conflict with pulseeffects
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: PulseEffects5
2021-03-20 23:06 [PR PATCH] PulseEffects5 paper42
` (4 preceding siblings ...)
2021-03-22 21:57 ` PulseEffects5 paper42
@ 2021-04-03 17:34 ` GameWizard5000
2021-04-03 17:34 ` PulseEffects5 GameWizard5000
` (6 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: GameWizard5000 @ 2021-04-03 17:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 258 bytes --]
New comment by GameWizard5000 on void-packages repository
https://github.com/void-linux/void-packages/pull/29638#issuecomment-812898562
Comment:
It looks like it won't launch without `gstreamer1-pipewire`. So that should probably be added as a dependency.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: PulseEffects5
2021-03-20 23:06 [PR PATCH] PulseEffects5 paper42
` (5 preceding siblings ...)
2021-04-03 17:34 ` PulseEffects5 GameWizard5000
@ 2021-04-03 17:34 ` GameWizard5000
2021-04-04 23:44 ` PulseEffects5 ericonr
` (5 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: GameWizard5000 @ 2021-04-03 17:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 269 bytes --]
New comment by GameWizard5000 on void-packages repository
https://github.com/void-linux/void-packages/pull/29638#issuecomment-812898562
Comment:
It looks like pulseeffects5 won't launch without `gstreamer1-pipewire`. So that should probably be added as a dependency.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: PulseEffects5
2021-03-20 23:06 [PR PATCH] PulseEffects5 paper42
` (6 preceding siblings ...)
2021-04-03 17:34 ` PulseEffects5 GameWizard5000
@ 2021-04-04 23:44 ` ericonr
2021-04-04 23:44 ` PulseEffects5 ericonr
` (4 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: ericonr @ 2021-04-04 23:44 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 216 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/29638#issuecomment-813117746
Comment:
@GameWizard5000 thanks for find. Should be good to merge once that's fixed.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: PulseEffects5
2021-03-20 23:06 [PR PATCH] PulseEffects5 paper42
` (7 preceding siblings ...)
2021-04-04 23:44 ` PulseEffects5 ericonr
@ 2021-04-04 23:44 ` ericonr
2021-04-04 23:45 ` PulseEffects5 ericonr
` (3 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: ericonr @ 2021-04-04 23:44 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 220 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/29638#issuecomment-813117746
Comment:
@GameWizard5000 thanks for the find. Should be good to merge once that's fixed.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: PulseEffects5
2021-03-20 23:06 [PR PATCH] PulseEffects5 paper42
` (8 preceding siblings ...)
2021-04-04 23:44 ` PulseEffects5 ericonr
@ 2021-04-04 23:45 ` ericonr
2021-04-10 11:13 ` [PR PATCH] [Updated] PulseEffects5 paper42
` (2 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: ericonr @ 2021-04-04 23:45 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 273 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/29638#issuecomment-813117864
Comment:
@paper42 if you could mention in the commit for `legacy` that it's basically a copy of "old "`pulseeffects`, I think that'd be nice,
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PR PATCH] [Updated] PulseEffects5
2021-03-20 23:06 [PR PATCH] PulseEffects5 paper42
` (9 preceding siblings ...)
2021-04-04 23:45 ` PulseEffects5 ericonr
@ 2021-04-10 11:13 ` paper42
2021-04-10 11:15 ` PulseEffects5 paper42
2021-04-11 3:06 ` [PR PATCH] [Closed]: PulseEffects5 ericonr
12 siblings, 0 replies; 14+ messages in thread
From: paper42 @ 2021-04-10 11:13 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1885 bytes --]
There is an updated pull request by paper42 against master on the void-packages repository
https://github.com/paper42/void-packages pulseeffects5
https://github.com/void-linux/void-packages/pull/29638
PulseEffects5
<!-- Mark items with [x] where applicable -->
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
PulseEffects 5 only supports PipeWire, so I made a new package `pulseeffects-legacy` which will stay on the PulseEffects 4. This approach is similar to what other distributions have done. I also added an install message to pulseeffects to let users know about this change.
related issue: #29006
A patch file from https://github.com/void-linux/void-packages/pull/29638.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pulseeffects5-29638.patch --]
[-- Type: text/x-diff, Size: 4153 bytes --]
From 08d84ad51e9978fdb537c4060673746e7d284cf2 Mon Sep 17 00:00:00 2001
From: Paper <paper@tilde.institute>
Date: Mon, 22 Mar 2021 22:49:03 +0100
Subject: [PATCH 1/2] New package: pulseeffects-legacy-4.8.5
pulseeffects-legacy is a version of pulseeffects before 5.0.0 which still supports pulseaudio
---
srcpkgs/pulseeffects-legacy/template | 21 +++++++++++++++++++++
srcpkgs/pulseeffects-legacy/update | 1 +
2 files changed, 22 insertions(+)
create mode 100644 srcpkgs/pulseeffects-legacy/template
create mode 100644 srcpkgs/pulseeffects-legacy/update
diff --git a/srcpkgs/pulseeffects-legacy/template b/srcpkgs/pulseeffects-legacy/template
new file mode 100644
index 000000000000..c38c8ef2d9ef
--- /dev/null
+++ b/srcpkgs/pulseeffects-legacy/template
@@ -0,0 +1,21 @@
+# Template file for 'pulseeffects-legacy'
+pkgname=pulseeffects-legacy
+version=4.8.5
+revision=1
+wrksrc="pulseeffects-${version}"
+build_style=meson
+hostmakedepends="itstool pkg-config gettext"
+makedepends="boost-devel glib-devel gsettings-desktop-schemas-devel
+ gst-plugins-bad1-devel gtkmm-devel libebur128-devel lilv-devel
+ pulseaudio-devel python3-gobject-devel sratom-devel
+ libsndfile-devel"
+depends="calf gsettings-desktop-schemas gst-plugins-bad1
+ gst-plugins-good1 pulseaudio python3-gobject python3-scipy"
+short_desc="Sound effects for systems using PulseAudio (legacy)"
+maintainer="Orphaned <orphan@voidlinux.org>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/wwmm/pulseeffects"
+distfiles="https://github.com/wwmm/pulseeffects/archive/v${version}.tar.gz"
+checksum=df1c4c4a9811c62a549822dacde3a9e36233ba3ec58817ae52a236f6181a507c
+python_version=3
+conflicts="pulseeffects"
diff --git a/srcpkgs/pulseeffects-legacy/update b/srcpkgs/pulseeffects-legacy/update
new file mode 100644
index 000000000000..2638b2b10b6e
--- /dev/null
+++ b/srcpkgs/pulseeffects-legacy/update
@@ -0,0 +1 @@
+ignore="5.*"
From 611ca47dfde26e829491a21c7ea54f8e2215ddcc Mon Sep 17 00:00:00 2001
From: Paper <paper@tilde.institute>
Date: Sat, 20 Mar 2021 23:54:16 +0100
Subject: [PATCH 2/2] pulseeffects: update to 5.0.3
---
srcpkgs/pulseeffects/INSTALL.msg | 2 ++
srcpkgs/pulseeffects/template | 15 ++++++++-------
2 files changed, 10 insertions(+), 7 deletions(-)
create mode 100644 srcpkgs/pulseeffects/INSTALL.msg
diff --git a/srcpkgs/pulseeffects/INSTALL.msg b/srcpkgs/pulseeffects/INSTALL.msg
new file mode 100644
index 000000000000..74c17ca2a8c5
--- /dev/null
+++ b/srcpkgs/pulseeffects/INSTALL.msg
@@ -0,0 +1,2 @@
+PulseEffects version 5 and later only support PipeWire and drop support for PulseAudio.
+If you want to use PulseEffects with PulseAudio, install pulseeffects-legacy instead.
diff --git a/srcpkgs/pulseeffects/template b/srcpkgs/pulseeffects/template
index a06f3042d97f..3b94e3dc873b 100644
--- a/srcpkgs/pulseeffects/template
+++ b/srcpkgs/pulseeffects/template
@@ -1,19 +1,20 @@
# Template file for 'pulseeffects'
pkgname=pulseeffects
-version=4.8.4
+version=5.0.3
revision=1
build_style=meson
hostmakedepends="itstool pkg-config gettext"
makedepends="boost-devel glib-devel gsettings-desktop-schemas-devel
gst-plugins-bad1-devel gtkmm-devel libebur128-devel lilv-devel
- pulseaudio-devel python3-gobject-devel sratom-devel
- libsndfile-devel"
+ pipewire-devel python3-gobject-devel sratom-devel zita-convolver-devel
+ libsndfile-devel libbs2b-devel"
depends="calf gsettings-desktop-schemas gst-plugins-bad1
- gst-plugins-good1 pulseaudio python3-gobject python3-scipy"
-short_desc="Sound effects for Pulseaudio applications"
+ gst-plugins-good1 pipewire python3-gobject python3-scipy zita-convolver
+ gstreamer1-pipewire"
+short_desc="Sound effects for systems using PipeWire"
maintainer="Orphaned <orphan@voidlinux.org>"
license="GPL-3.0-or-later"
homepage="https://github.com/wwmm/pulseeffects"
-distfiles="https://github.com/wwmm/pulseeffects/archive/${version}.tar.gz"
-checksum=12ba3205025d815a747b58636861594f7d1e43a578a5b0411f7794f4c12e5d86
+distfiles="https://github.com/wwmm/pulseeffects/archive/v${version}.tar.gz"
+checksum=2e14858918b54bee5f6e4898cc803ae2170b4d624407fef39e0831b6584c4a4f
python_version=3
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: PulseEffects5
2021-03-20 23:06 [PR PATCH] PulseEffects5 paper42
` (10 preceding siblings ...)
2021-04-10 11:13 ` [PR PATCH] [Updated] PulseEffects5 paper42
@ 2021-04-10 11:15 ` paper42
2021-04-11 3:06 ` [PR PATCH] [Closed]: PulseEffects5 ericonr
12 siblings, 0 replies; 14+ messages in thread
From: paper42 @ 2021-04-10 11:15 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 293 bytes --]
New comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/29638#issuecomment-817119794
Comment:
@ericonr @GameWizard5000 thank you both for your finds, they should be fixed now. I also reworded INSTALL.msg a bit, so hopefully it's a bit better now.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PR PATCH] [Closed]: PulseEffects5
2021-03-20 23:06 [PR PATCH] PulseEffects5 paper42
` (11 preceding siblings ...)
2021-04-10 11:15 ` PulseEffects5 paper42
@ 2021-04-11 3:06 ` ericonr
12 siblings, 0 replies; 14+ messages in thread
From: ericonr @ 2021-04-11 3:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1723 bytes --]
There's a closed pull request on the void-packages repository
PulseEffects5
https://github.com/void-linux/void-packages/pull/29638
Description:
<!-- Mark items with [x] where applicable -->
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
PulseEffects 5 only supports PipeWire, so I made a new package `pulseeffects-legacy` which will stay on the PulseEffects 4. This approach is similar to what other distributions have done. I also added an install message to pulseeffects to let users know about this change.
related issue: #29006
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2021-04-11 3:06 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-20 23:06 [PR PATCH] PulseEffects5 paper42
2021-03-21 0:26 ` PulseEffects5 ericonr
2021-03-22 21:11 ` PulseEffects5 ericonr
2021-03-22 21:52 ` [PR PATCH] [Updated] PulseEffects5 paper42
2021-03-22 21:56 ` paper42
2021-03-22 21:57 ` PulseEffects5 paper42
2021-04-03 17:34 ` PulseEffects5 GameWizard5000
2021-04-03 17:34 ` PulseEffects5 GameWizard5000
2021-04-04 23:44 ` PulseEffects5 ericonr
2021-04-04 23:44 ` PulseEffects5 ericonr
2021-04-04 23:45 ` PulseEffects5 ericonr
2021-04-10 11:13 ` [PR PATCH] [Updated] PulseEffects5 paper42
2021-04-10 11:15 ` PulseEffects5 paper42
2021-04-11 3:06 ` [PR PATCH] [Closed]: PulseEffects5 ericonr
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).