From: pudiva <pudiva@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package: sane-airscan-0.99.24
Date: Mon, 22 Mar 2021 23:27:48 +0100 [thread overview]
Message-ID: <20210322222748.FCqEwTR-zXrZeOFMQw78jdfgvIAotXCK75FslO3CrHk@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-29627@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 836 bytes --]
New review comment by pudiva on void-packages repository
https://github.com/void-linux/void-packages/pull/29627#discussion_r599117070
Comment:
@ericonr, thanks for the suggestion! Indeed I could get around defining a custom `do_install()` by setting `$make_install_args="STRIP=-s"`...
However, Makefile uses `$(STRIP)` as options to `install`:
https://github.com/alexpevzner/sane-airscan/blob/master/Makefile#L118-L132
and defaults to `-s` (which instructs `install` to strip):
https://github.com/alexpevzner/sane-airscan/blob/master/Makefile#L30-L35
so, for cross-compilation, I think we would need to override `$(INSTALL)` with `target-linux-gnu-install` ~ which could be a nice addition to the gnu-makefile build style, as it already does many similar overrides for `CC`, `LD` and friends.
What do you think?
next prev parent reply other threads:[~2021-03-22 22:27 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-20 13:13 [PR PATCH] " pudiva
2021-03-20 13:15 ` [PR PATCH] [Updated] " pudiva
2021-03-20 13:35 ` ericonr
2021-03-22 7:54 ` oynqr
2021-03-22 14:57 ` [PR PATCH] [Updated] " pudiva
2021-03-22 15:11 ` pudiva
2021-03-22 15:56 ` [PR REVIEW] " ericonr
2021-03-22 15:58 ` ericonr
2021-03-22 22:27 ` pudiva [this message]
2021-03-22 22:28 ` [PR PATCH] [Updated] " pudiva
2021-03-22 22:34 ` pudiva
2021-03-22 22:52 ` pudiva
2021-03-25 14:42 ` pudiva
2021-03-25 16:56 ` [PR REVIEW] " pudiva
2021-03-25 20:59 ` ericonr
2021-03-25 21:00 ` ericonr
2021-03-25 21:01 ` [PR REVIEW] " ericonr
2021-03-25 21:01 ` ericonr
2021-03-25 21:02 ` ericonr
2021-03-25 22:08 ` pudiva
2021-03-25 22:09 ` pudiva
2021-03-25 22:11 ` [PR PATCH] [Updated] " pudiva
2021-03-25 22:25 ` [PR REVIEW] " pudiva
2021-03-26 1:03 ` ericonr
2021-03-26 1:06 ` ericonr
2021-03-26 1:06 ` ericonr
2021-03-26 1:37 ` [PR PATCH] [Updated] " pudiva
2021-03-26 1:37 ` [PR REVIEW] " pudiva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210322222748.FCqEwTR-zXrZeOFMQw78jdfgvIAotXCK75FslO3CrHk@z \
--to=pudiva@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).