Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] .github/workflows: add CI run to lock closed threads.
@ 2021-03-03  2:46 ericonr
  2021-03-03  7:29 ` fosslinux
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: ericonr @ 2021-03-03  2:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1966 bytes --]

There is a new pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages lock
https://github.com/void-linux/void-packages/pull/29190

.github/workflows: add CI run to lock closed threads.
Closed PRs and issues will be locked after 90 days of inactivity, to
avoid comments on old inactive threads and encourage people to create
new ones, which will receive the proper attention.

Inspired by hook from fish-shell:
https://github.com/fish-shell/fish-shell/blob/a36dbad3b82c36352c6cf9d4bbdc58c7bd46e18a/.github/workflows/lockthreads.yml

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/29190.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-lock-29190.patch --]
[-- Type: text/x-diff, Size: 1246 bytes --]

From 904e57d957d45e4c5fdff7f66777532a6aeee359 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Tue, 2 Mar 2021 23:44:30 -0300
Subject: [PATCH] .github/workflows: add CI run to lock closed threads.

Closed PRs and issues will be locked after 90 days of inactivity, to
avoid comments on old inactive threads and encourage people to create
new ones, which will receive the proper attention.

Inspired by hook from fish-shell:
https://github.com/fish-shell/fish-shell/blob/a36dbad3b82c36352c6cf9d4bbdc58c7bd46e18a/.github/workflows/lockthreads.yml
---
 .github/workflows/lockthreads.yml | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
 create mode 100644 .github/workflows/lockthreads.yml

diff --git a/.github/workflows/lockthreads.yml b/.github/workflows/lockthreads.yml
new file mode 100644
index 00000000000..209785d3014
--- /dev/null
+++ b/.github/workflows/lockthreads.yml
@@ -0,0 +1,15 @@
+name: 'Lock threads'
+
+on:
+  schedule:
+    - cron: '0 18 * * *'
+
+jobs:
+  lock:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: dessant/lock-threads@v2
+        with:
+          github-token: ${{ github.token }}
+          issue-lock-inactive-days: '90'
+          pr-lock-inactive-days: '90'

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: .github/workflows: add CI run to lock closed threads.
  2021-03-03  2:46 [PR PATCH] .github/workflows: add CI run to lock closed threads ericonr
@ 2021-03-03  7:29 ` fosslinux
  2021-03-24  3:13 ` [PR PATCH] [Updated] " ericonr
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: fosslinux @ 2021-03-03  7:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 523 bytes --]

New comment by fosslinux on void-packages repository

https://github.com/void-linux/void-packages/pull/29190#issuecomment-789503850

Comment:
I do not think this is a good idea for issues. (For PRs, I think this is a good idea). It does only occur rarely, but it does happen that an issue is attempted to be fixed, closed, the edge case the user is running into is fixed/the reporter has gone AWOL and infact the issue still exists. When a new issue is then created for the same problem the history is not easily apparent.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Updated] .github/workflows: add CI run to lock closed threads.
  2021-03-03  2:46 [PR PATCH] .github/workflows: add CI run to lock closed threads ericonr
  2021-03-03  7:29 ` fosslinux
@ 2021-03-24  3:13 ` ericonr
  2021-03-24  3:13 ` [PR PATCH] [Merged]: " ericonr
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2021-03-24  3:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1971 bytes --]

There is an updated pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages lock
https://github.com/void-linux/void-packages/pull/29190

.github/workflows: add CI run to lock closed threads.
Closed PRs and issues will be locked after 90 days of inactivity, to
avoid comments on old inactive threads and encourage people to create
new ones, which will receive the proper attention.

Inspired by hook from fish-shell:
https://github.com/fish-shell/fish-shell/blob/a36dbad3b82c36352c6cf9d4bbdc58c7bd46e18a/.github/workflows/lockthreads.yml

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/29190.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-lock-29190.patch --]
[-- Type: text/x-diff, Size: 1194 bytes --]

From cc96599d33eef71c0a3eedaa867ceb49c14d5c44 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Tue, 2 Mar 2021 23:44:30 -0300
Subject: [PATCH] .github/workflows: add CI run to lock closed threads.

Closed PRs will be locked after 90 days of inactivity, to avoid comments
on old inactive threads and encourage people to create new ones, which
will receive the proper attention.

Inspired by hook from fish-shell:
https://github.com/fish-shell/fish-shell/blob/a36dbad3b82c36352c6cf9d4bbdc58c7bd46e18a/.github/workflows/lockthreads.yml
---
 .github/workflows/lockthreads.yml | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
 create mode 100644 .github/workflows/lockthreads.yml

diff --git a/.github/workflows/lockthreads.yml b/.github/workflows/lockthreads.yml
new file mode 100644
index 000000000000..11e571abf68c
--- /dev/null
+++ b/.github/workflows/lockthreads.yml
@@ -0,0 +1,14 @@
+name: 'Lock threads'
+
+on:
+  schedule:
+    - cron: '0 18 * * *'
+
+jobs:
+  lock:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: dessant/lock-threads@v2
+        with:
+          github-token: ${{ github.token }}
+          pr-lock-inactive-days: '90'

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Merged]: .github/workflows: add CI run to lock closed threads.
  2021-03-03  2:46 [PR PATCH] .github/workflows: add CI run to lock closed threads ericonr
  2021-03-03  7:29 ` fosslinux
  2021-03-24  3:13 ` [PR PATCH] [Updated] " ericonr
@ 2021-03-24  3:13 ` ericonr
  2021-03-24 23:31 ` Chocimier
  2021-03-24 23:52 ` ericonr
  4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2021-03-24  3:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1818 bytes --]

There's a merged pull request on the void-packages repository

.github/workflows: add CI run to lock closed threads.
https://github.com/void-linux/void-packages/pull/29190

Description:
Closed PRs and issues will be locked after 90 days of inactivity, to
avoid comments on old inactive threads and encourage people to create
new ones, which will receive the proper attention.

Inspired by hook from fish-shell:
https://github.com/fish-shell/fish-shell/blob/a36dbad3b82c36352c6cf9d4bbdc58c7bd46e18a/.github/workflows/lockthreads.yml

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: .github/workflows: add CI run to lock closed threads.
  2021-03-03  2:46 [PR PATCH] .github/workflows: add CI run to lock closed threads ericonr
                   ` (2 preceding siblings ...)
  2021-03-24  3:13 ` [PR PATCH] [Merged]: " ericonr
@ 2021-03-24 23:31 ` Chocimier
  2021-03-24 23:52 ` ericonr
  4 siblings, 0 replies; 6+ messages in thread
From: Chocimier @ 2021-03-24 23:31 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 204 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/29190#issuecomment-806249925

Comment:
It locked issues inactive for year. Do we want such behavior?

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: .github/workflows: add CI run to lock closed threads.
  2021-03-03  2:46 [PR PATCH] .github/workflows: add CI run to lock closed threads ericonr
                   ` (3 preceding siblings ...)
  2021-03-24 23:31 ` Chocimier
@ 2021-03-24 23:52 ` ericonr
  4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2021-03-24 23:52 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 202 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29190#issuecomment-806256818

Comment:
@Chocimier can you give me an example? It's not intended, no.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-03-24 23:52 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-03  2:46 [PR PATCH] .github/workflows: add CI run to lock closed threads ericonr
2021-03-03  7:29 ` fosslinux
2021-03-24  3:13 ` [PR PATCH] [Updated] " ericonr
2021-03-24  3:13 ` [PR PATCH] [Merged]: " ericonr
2021-03-24 23:31 ` Chocimier
2021-03-24 23:52 ` ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).