Re: [PR PATCH] [Updated] mupen64plus: update to 2.5.9

[zlice <zlice@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 1033 bytes --]

There is an updated pull request by zlice against master on the void-packages repository

https://github.com/zlice/void-packages mupen64plus-update-to-2.5.9
https://github.com/void-linux/void-packages/pull/29692

mupen64plus: update to 2.5.9
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86-64, libc)

#### Comments
2.5 was wobbling walls and textures in Mario64
Not sure if `nopie` is an issue, first time I've had to add that.

2.5 was from 2015, 2.5.9 is from 2019

edit:
updated linting
no clue on gpl spdx specifics

A patch file from https://github.com/void-linux/void-packages/pull/29692.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mupen64plus-update-to-2.5.9-29692.patch --]
[-- Type: text/x-diff, Size: 1419 bytes --]

From 6f0061cdd5fb0303bce0c148d2ab8806d21e6f35 Mon Sep 17 00:00:00 2001
From: Corey Thomas <cthomas@oisf.net>
Date: Mon, 22 Mar 2021 23:02:10 -0400
Subject: [PATCH] mupen64plus: update to 2.5.9

---
 srcpkgs/mupen64plus/template | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/mupen64plus/template b/srcpkgs/mupen64plus/template
index 0323d321803c..f0e6fe2c4173 100644
--- a/srcpkgs/mupen64plus/template
+++ b/srcpkgs/mupen64plus/template
@@ -1,18 +1,19 @@
 # Template file for 'mupen64plus'
 pkgname=mupen64plus
-version=2.5
-revision=13
+version=2.5.9
+revision=1
+nocross="yes"
 wrksrc="mupen64plus-bundle-src-${version}"
-hostmakedepends="pkg-config which"
+hostmakedepends="pkg-config which nasm"
 makedepends="boost-devel SDL2-devel speexdsp-devel freetype-devel glu-devel libpng-devel libsamplerate-devel"
 depends="desktop-file-utils"
-short_desc="A Nintendo64 Emulator"
+short_desc="Nintendo64 Emulator"
 maintainer="Orphaned <orphan@voidlinux.org>"
-license="GPL-2"
+license="GPL-2.0-only"
 homepage="http://www.mupen64plus.org"
 distfiles="https://github.com/mupen64plus/mupen64plus-core/releases/download/${version}/${pkgname}-bundle-src-${version}.tar.gz"
-checksum=9c75b9d826f2d24666175f723a97369b3a6ee159b307f7cc876bbb4facdbba66
-archs="i686* x86_64*"
+checksum=d5243ddc00388ee2e538b3826a78a719dec2bd5da54ac6f3344fed861fb141a8
+nopie=yes
 
 CFLAGS="-fcommon"