Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] python3-pgzero: update to 1.2.1.
@ 2021-03-24 14:43 pbui
  2021-03-24 19:13 ` [PR REVIEW] " ericonr
                   ` (10 more replies)
  0 siblings, 11 replies; 12+ messages in thread
From: pbui @ 2021-03-24 14:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1859 bytes --]

There is a new pull request by pbui against master on the void-packages repository

https://github.com/pbui/void-packages python3-pgzero
https://github.com/void-linux/void-packages/pull/29720

python3-pgzero: update to 1.2.1.
Also update related dependency **python3-pygame** to 2.0.0.  This now uses **SDL2** rather than **SDL**.  The only package that depends on **python3-pygame** appears to be **pysolfc** and I have tested that it still runs with this update to **python3-pygame**.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/29720.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-pgzero-29720.patch --]
[-- Type: text/x-diff, Size: 3171 bytes --]

From e125b6e82ac0c8ea9a0da978f334fb0b2d74c526 Mon Sep 17 00:00:00 2001
From: Peter Bui <pbui@github.bx612.space>
Date: Wed, 24 Mar 2021 10:37:16 -0400
Subject: [PATCH 1/2] python3-pygame: update to 2.0.1.

---
 srcpkgs/python3-pygame/template | 17 ++++++-----------
 1 file changed, 6 insertions(+), 11 deletions(-)

diff --git a/srcpkgs/python3-pygame/template b/srcpkgs/python3-pygame/template
index c136b750713d..80ed8b637837 100644
--- a/srcpkgs/python3-pygame/template
+++ b/srcpkgs/python3-pygame/template
@@ -1,24 +1,19 @@
 # Template file for 'python3-pygame'
 pkgname=python3-pygame
-version=1.9.6
-revision=4
+version=2.0.1
+revision=1
 wrksrc="pygame-${version}"
 build_style=python3-module
 make_build_args="cython"
 hostmakedepends="pkg-config python3-setuptools python3-Cython
- SDL_mixer-devel SDL_image-devel SDL_ttf-devel libjpeg-turbo-devel portmidi-devel"
-makedepends="python3-devel SDL_mixer-devel SDL_image-devel
- SDL_ttf-devel libjpeg-turbo-devel portmidi-devel"
+ SDL2_mixer-devel SDL2_image-devel SDL2_ttf-devel libjpeg-turbo-devel portmidi-devel"
+makedepends="python3-devel SDL2_mixer-devel SDL2_image-devel
+ SDL2_ttf-devel libjpeg-turbo-devel portmidi-devel"
 short_desc="Collection of Python modules for writing games (Python3)"
 maintainer="Archaeme <normandy@firemail.cc>"
 license="LGPL-2.1-or-later"
 homepage="https://www.pygame.org/"
 distfiles="${PYPI_SITE}/p/pygame/pygame-${version}.tar.gz"
-checksum=301c6428c0880ecd4a9e3951b80e539c33863b6ff356a443db1758de4f297957
+checksum=8b1e7b63f47aafcdd8849933b206778747ef1802bd3d526aca45ed77141e4001
 
 export PORTMIDI_INC_PORTTIME=1
-
-pre_build() {
-	# Remove the C source to re-cythonize, which avoids some API changes
-	rm src_c/pypm.c src_c/_sdl2/{sdl2,audio,video}.c
-}

From 3751fa713bdcde804ec121539bb8d420f316d74b Mon Sep 17 00:00:00 2001
From: Peter Bui <pbui@github.bx612.space>
Date: Wed, 24 Mar 2021 10:37:19 -0400
Subject: [PATCH 2/2] python3-pgzero: update to 1.2.1.

---
 srcpkgs/python3-pgzero/template | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/python3-pgzero/template b/srcpkgs/python3-pgzero/template
index ee3e285ca08a..50f14df4159c 100644
--- a/srcpkgs/python3-pgzero/template
+++ b/srcpkgs/python3-pgzero/template
@@ -1,15 +1,19 @@
 # Template file for 'python3-pgzero'
 pkgname=python3-pgzero
-version=1.2
-revision=3
+version=1.2.1
+revision=1
 wrksrc="pgzero-${version}"
 build_style=python3-module
-pycompile_module="pgzero pgzrun.py"
 hostmakedepends="python3-setuptools"
-depends="python3-setuptools python3-pygame python3-numpy"
+depends="python3-setuptools python3-pygame>=2.0.0 python3-numpy"
+checkdepends="$depends python3-pytest"
 short_desc="Zero-boilerplate games programming framework based on Pygame (Python3)"
 maintainer="Peter Bui <pbui@github.bx612.space>"
 license="LGPL-3.0-or-later"
 homepage="https://pygame-zero.readthedocs.io/en/stable/"
 distfiles="${PYPI_SITE}/p/pgzero/pgzero-${version}.tar.gz"
-checksum=91e641d545c6235a24719dea0fd83c8429e92a8b5ab1756bef145128e8db9017
+checksum=8cadc020f028cbac3e0cbd3bb9311a1c045f1deedac7917ff433f986c38e6106
+
+do_check() {
+	: requires video device
+}

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PR REVIEW] python3-pgzero: update to 1.2.1.
  2021-03-24 14:43 [PR PATCH] python3-pgzero: update to 1.2.1 pbui
@ 2021-03-24 19:13 ` ericonr
  2021-03-24 20:47 ` [PR PATCH] [Updated] " pbui
                   ` (9 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: ericonr @ 2021-03-24 19:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 287 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29720#discussion_r600799461

Comment:
`make_check=no` or maybe `extended` instead of defining an empty function, but you can probably try wrapping the test command in `xvfb-run`?

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PR PATCH] [Updated] python3-pgzero: update to 1.2.1.
  2021-03-24 14:43 [PR PATCH] python3-pgzero: update to 1.2.1 pbui
  2021-03-24 19:13 ` [PR REVIEW] " ericonr
@ 2021-03-24 20:47 ` pbui
  2021-03-24 20:48 ` [PR REVIEW] " pbui
                   ` (8 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: pbui @ 2021-03-24 20:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1864 bytes --]

There is an updated pull request by pbui against master on the void-packages repository

https://github.com/pbui/void-packages python3-pgzero
https://github.com/void-linux/void-packages/pull/29720

python3-pgzero: update to 1.2.1.
Also update related dependency **python3-pygame** to 2.0.0.  This now uses **SDL2** rather than **SDL**.  The only package that depends on **python3-pygame** appears to be **pysolfc** and I have tested that it still runs with this update to **python3-pygame**.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/29720.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-pgzero-29720.patch --]
[-- Type: text/x-diff, Size: 3097 bytes --]

From e125b6e82ac0c8ea9a0da978f334fb0b2d74c526 Mon Sep 17 00:00:00 2001
From: Peter Bui <pbui@github.bx612.space>
Date: Wed, 24 Mar 2021 10:37:16 -0400
Subject: [PATCH 1/2] python3-pygame: update to 2.0.1.

---
 srcpkgs/python3-pygame/template | 17 ++++++-----------
 1 file changed, 6 insertions(+), 11 deletions(-)

diff --git a/srcpkgs/python3-pygame/template b/srcpkgs/python3-pygame/template
index c136b750713d..80ed8b637837 100644
--- a/srcpkgs/python3-pygame/template
+++ b/srcpkgs/python3-pygame/template
@@ -1,24 +1,19 @@
 # Template file for 'python3-pygame'
 pkgname=python3-pygame
-version=1.9.6
-revision=4
+version=2.0.1
+revision=1
 wrksrc="pygame-${version}"
 build_style=python3-module
 make_build_args="cython"
 hostmakedepends="pkg-config python3-setuptools python3-Cython
- SDL_mixer-devel SDL_image-devel SDL_ttf-devel libjpeg-turbo-devel portmidi-devel"
-makedepends="python3-devel SDL_mixer-devel SDL_image-devel
- SDL_ttf-devel libjpeg-turbo-devel portmidi-devel"
+ SDL2_mixer-devel SDL2_image-devel SDL2_ttf-devel libjpeg-turbo-devel portmidi-devel"
+makedepends="python3-devel SDL2_mixer-devel SDL2_image-devel
+ SDL2_ttf-devel libjpeg-turbo-devel portmidi-devel"
 short_desc="Collection of Python modules for writing games (Python3)"
 maintainer="Archaeme <normandy@firemail.cc>"
 license="LGPL-2.1-or-later"
 homepage="https://www.pygame.org/"
 distfiles="${PYPI_SITE}/p/pygame/pygame-${version}.tar.gz"
-checksum=301c6428c0880ecd4a9e3951b80e539c33863b6ff356a443db1758de4f297957
+checksum=8b1e7b63f47aafcdd8849933b206778747ef1802bd3d526aca45ed77141e4001
 
 export PORTMIDI_INC_PORTTIME=1
-
-pre_build() {
-	# Remove the C source to re-cythonize, which avoids some API changes
-	rm src_c/pypm.c src_c/_sdl2/{sdl2,audio,video}.c
-}

From c2fa47c917095ae5399a005d89f4606350a8dedf Mon Sep 17 00:00:00 2001
From: Peter Bui <pbui@github.bx612.space>
Date: Wed, 24 Mar 2021 10:37:19 -0400
Subject: [PATCH 2/2] python3-pgzero: update to 1.2.1.

---
 srcpkgs/python3-pgzero/template | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/python3-pgzero/template b/srcpkgs/python3-pgzero/template
index ee3e285ca08a..f0f97cb9bb04 100644
--- a/srcpkgs/python3-pgzero/template
+++ b/srcpkgs/python3-pgzero/template
@@ -1,15 +1,15 @@
 # Template file for 'python3-pgzero'
 pkgname=python3-pgzero
-version=1.2
-revision=3
+version=1.2.1
+revision=1
 wrksrc="pgzero-${version}"
 build_style=python3-module
-pycompile_module="pgzero pgzrun.py"
 hostmakedepends="python3-setuptools"
-depends="python3-setuptools python3-pygame python3-numpy"
+depends="python3-setuptools python3-pygame>=2.0.0 python3-numpy"
 short_desc="Zero-boilerplate games programming framework based on Pygame (Python3)"
 maintainer="Peter Bui <pbui@github.bx612.space>"
 license="LGPL-3.0-or-later"
 homepage="https://pygame-zero.readthedocs.io/en/stable/"
 distfiles="${PYPI_SITE}/p/pgzero/pgzero-${version}.tar.gz"
-checksum=91e641d545c6235a24719dea0fd83c8429e92a8b5ab1756bef145128e8db9017
+checksum=8cadc020f028cbac3e0cbd3bb9311a1c045f1deedac7917ff433f986c38e6106
+make_check=no

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PR REVIEW] python3-pgzero: update to 1.2.1.
  2021-03-24 14:43 [PR PATCH] python3-pgzero: update to 1.2.1 pbui
  2021-03-24 19:13 ` [PR REVIEW] " ericonr
  2021-03-24 20:47 ` [PR PATCH] [Updated] " pbui
@ 2021-03-24 20:48 ` pbui
  2021-03-24 21:20 ` ericonr
                   ` (7 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: pbui @ 2021-03-24 20:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 290 bytes --]

New review comment by pbui on void-packages repository

https://github.com/void-linux/void-packages/pull/29720#discussion_r600863578

Comment:
Ah, Ok.  I didn't know about `make_check` and have updated the template to use that.  I tried to use `xvfb-run`, but I could not get that to work.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PR REVIEW] python3-pgzero: update to 1.2.1.
  2021-03-24 14:43 [PR PATCH] python3-pgzero: update to 1.2.1 pbui
                   ` (2 preceding siblings ...)
  2021-03-24 20:48 ` [PR REVIEW] " pbui
@ 2021-03-24 21:20 ` ericonr
  2021-03-24 21:20 ` ericonr
                   ` (6 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: ericonr @ 2021-03-24 21:20 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 260 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29720#discussion_r600881467

Comment:
I don't think we need to specify the version here, since it will come in a single update to the dependency chain.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PR REVIEW] python3-pgzero: update to 1.2.1.
  2021-03-24 14:43 [PR PATCH] python3-pgzero: update to 1.2.1 pbui
                   ` (4 preceding siblings ...)
  2021-03-24 21:20 ` ericonr
@ 2021-03-24 21:20 ` ericonr
  2021-03-27 14:13 ` [PR PATCH] [Updated] " pbui
                   ` (4 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: ericonr @ 2021-03-24 21:20 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 224 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29720#discussion_r600881900

Comment:
Did they stop shipping these files or did re-generation stop being necessary?

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PR REVIEW] python3-pgzero: update to 1.2.1.
  2021-03-24 14:43 [PR PATCH] python3-pgzero: update to 1.2.1 pbui
                   ` (3 preceding siblings ...)
  2021-03-24 21:20 ` ericonr
@ 2021-03-24 21:20 ` ericonr
  2021-03-24 21:20 ` ericonr
                   ` (5 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: ericonr @ 2021-03-24 21:20 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 197 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29720#discussion_r600881595

Comment:
Do leave a comment as to why tests are disabled :)

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PR PATCH] [Updated] python3-pgzero: update to 1.2.1.
  2021-03-24 14:43 [PR PATCH] python3-pgzero: update to 1.2.1 pbui
                   ` (5 preceding siblings ...)
  2021-03-24 21:20 ` ericonr
@ 2021-03-27 14:13 ` pbui
  2021-03-27 14:13 ` [PR REVIEW] " pbui
                   ` (3 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: pbui @ 2021-03-27 14:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1864 bytes --]

There is an updated pull request by pbui against master on the void-packages repository

https://github.com/pbui/void-packages python3-pgzero
https://github.com/void-linux/void-packages/pull/29720

python3-pgzero: update to 1.2.1.
Also update related dependency **python3-pygame** to 2.0.0.  This now uses **SDL2** rather than **SDL**.  The only package that depends on **python3-pygame** appears to be **pysolfc** and I have tested that it still runs with this update to **python3-pygame**.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/29720.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-pgzero-29720.patch --]
[-- Type: text/x-diff, Size: 3073 bytes --]

From e125b6e82ac0c8ea9a0da978f334fb0b2d74c526 Mon Sep 17 00:00:00 2001
From: Peter Bui <pbui@github.bx612.space>
Date: Wed, 24 Mar 2021 10:37:16 -0400
Subject: [PATCH 1/2] python3-pygame: update to 2.0.1.

---
 srcpkgs/python3-pygame/template | 17 ++++++-----------
 1 file changed, 6 insertions(+), 11 deletions(-)

diff --git a/srcpkgs/python3-pygame/template b/srcpkgs/python3-pygame/template
index c136b750713d..80ed8b637837 100644
--- a/srcpkgs/python3-pygame/template
+++ b/srcpkgs/python3-pygame/template
@@ -1,24 +1,19 @@
 # Template file for 'python3-pygame'
 pkgname=python3-pygame
-version=1.9.6
-revision=4
+version=2.0.1
+revision=1
 wrksrc="pygame-${version}"
 build_style=python3-module
 make_build_args="cython"
 hostmakedepends="pkg-config python3-setuptools python3-Cython
- SDL_mixer-devel SDL_image-devel SDL_ttf-devel libjpeg-turbo-devel portmidi-devel"
-makedepends="python3-devel SDL_mixer-devel SDL_image-devel
- SDL_ttf-devel libjpeg-turbo-devel portmidi-devel"
+ SDL2_mixer-devel SDL2_image-devel SDL2_ttf-devel libjpeg-turbo-devel portmidi-devel"
+makedepends="python3-devel SDL2_mixer-devel SDL2_image-devel
+ SDL2_ttf-devel libjpeg-turbo-devel portmidi-devel"
 short_desc="Collection of Python modules for writing games (Python3)"
 maintainer="Archaeme <normandy@firemail.cc>"
 license="LGPL-2.1-or-later"
 homepage="https://www.pygame.org/"
 distfiles="${PYPI_SITE}/p/pygame/pygame-${version}.tar.gz"
-checksum=301c6428c0880ecd4a9e3951b80e539c33863b6ff356a443db1758de4f297957
+checksum=8b1e7b63f47aafcdd8849933b206778747ef1802bd3d526aca45ed77141e4001
 
 export PORTMIDI_INC_PORTTIME=1
-
-pre_build() {
-	# Remove the C source to re-cythonize, which avoids some API changes
-	rm src_c/pypm.c src_c/_sdl2/{sdl2,audio,video}.c
-}

From c3fcd3f8b22bcb0c1b603a1e1a19b5cf2963cb88 Mon Sep 17 00:00:00 2001
From: Peter Bui <pbui@github.bx612.space>
Date: Wed, 24 Mar 2021 10:37:19 -0400
Subject: [PATCH 2/2] python3-pgzero: update to 1.2.1.

---
 srcpkgs/python3-pgzero/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/python3-pgzero/template b/srcpkgs/python3-pgzero/template
index ee3e285ca08a..b9be3f993aff 100644
--- a/srcpkgs/python3-pgzero/template
+++ b/srcpkgs/python3-pgzero/template
@@ -1,10 +1,9 @@
 # Template file for 'python3-pgzero'
 pkgname=python3-pgzero
-version=1.2
-revision=3
+version=1.2.1
+revision=1
 wrksrc="pgzero-${version}"
 build_style=python3-module
-pycompile_module="pgzero pgzrun.py"
 hostmakedepends="python3-setuptools"
 depends="python3-setuptools python3-pygame python3-numpy"
 short_desc="Zero-boilerplate games programming framework based on Pygame (Python3)"
@@ -12,4 +11,5 @@ maintainer="Peter Bui <pbui@github.bx612.space>"
 license="LGPL-3.0-or-later"
 homepage="https://pygame-zero.readthedocs.io/en/stable/"
 distfiles="${PYPI_SITE}/p/pgzero/pgzero-${version}.tar.gz"
-checksum=91e641d545c6235a24719dea0fd83c8429e92a8b5ab1756bef145128e8db9017
+checksum=8cadc020f028cbac3e0cbd3bb9311a1c045f1deedac7917ff433f986c38e6106
+make_check=no # Tests require video device

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PR REVIEW] python3-pgzero: update to 1.2.1.
  2021-03-24 14:43 [PR PATCH] python3-pgzero: update to 1.2.1 pbui
                   ` (6 preceding siblings ...)
  2021-03-27 14:13 ` [PR PATCH] [Updated] " pbui
@ 2021-03-27 14:13 ` pbui
  2021-03-27 14:13 ` pbui
                   ` (2 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: pbui @ 2021-03-27 14:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 168 bytes --]

New review comment by pbui on void-packages repository

https://github.com/void-linux/void-packages/pull/29720#discussion_r602724154

Comment:
Ok, I have removed this.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PR REVIEW] python3-pgzero: update to 1.2.1.
  2021-03-24 14:43 [PR PATCH] python3-pgzero: update to 1.2.1 pbui
                   ` (7 preceding siblings ...)
  2021-03-27 14:13 ` [PR REVIEW] " pbui
@ 2021-03-27 14:13 ` pbui
  2021-03-27 14:14 ` pbui
  2021-04-04 23:26 ` [PR PATCH] [Closed]: " ericonr
  10 siblings, 0 replies; 12+ messages in thread
From: pbui @ 2021-03-27 14:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 149 bytes --]

New review comment by pbui on void-packages repository

https://github.com/void-linux/void-packages/pull/29720#discussion_r602724187

Comment:
Done!

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PR REVIEW] python3-pgzero: update to 1.2.1.
  2021-03-24 14:43 [PR PATCH] python3-pgzero: update to 1.2.1 pbui
                   ` (8 preceding siblings ...)
  2021-03-27 14:13 ` pbui
@ 2021-03-27 14:14 ` pbui
  2021-04-04 23:26 ` [PR PATCH] [Closed]: " ericonr
  10 siblings, 0 replies; 12+ messages in thread
From: pbui @ 2021-03-27 14:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 297 bytes --]

New review comment by pbui on void-packages repository

https://github.com/void-linux/void-packages/pull/29720#discussion_r602724233

Comment:
I believe the re-generation is no longer necessary.  I checked the ArchLinux package and they do not have this there and it appears to work without this.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PR PATCH] [Closed]: python3-pgzero: update to 1.2.1.
  2021-03-24 14:43 [PR PATCH] python3-pgzero: update to 1.2.1 pbui
                   ` (9 preceding siblings ...)
  2021-03-27 14:14 ` pbui
@ 2021-04-04 23:26 ` ericonr
  10 siblings, 0 replies; 12+ messages in thread
From: ericonr @ 2021-04-04 23:26 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1707 bytes --]

There's a closed pull request on the void-packages repository

python3-pgzero: update to 1.2.1.
https://github.com/void-linux/void-packages/pull/29720

Description:
Also update related dependency **python3-pygame** to 2.0.0.  This now uses **SDL2** rather than **SDL**.  The only package that depends on **python3-pygame** appears to be **pysolfc** and I have tested that it still runs with this update to **python3-pygame**.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2021-04-04 23:26 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-24 14:43 [PR PATCH] python3-pgzero: update to 1.2.1 pbui
2021-03-24 19:13 ` [PR REVIEW] " ericonr
2021-03-24 20:47 ` [PR PATCH] [Updated] " pbui
2021-03-24 20:48 ` [PR REVIEW] " pbui
2021-03-24 21:20 ` ericonr
2021-03-24 21:20 ` ericonr
2021-03-24 21:20 ` ericonr
2021-03-27 14:13 ` [PR PATCH] [Updated] " pbui
2021-03-27 14:13 ` [PR REVIEW] " pbui
2021-03-27 14:13 ` pbui
2021-03-27 14:14 ` pbui
2021-04-04 23:26 ` [PR PATCH] [Closed]: " ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).