From: heliocat <heliocat@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] asciinema: fix license
Date: Fri, 26 Mar 2021 02:43:45 +0100 [thread overview]
Message-ID: <20210326014345.svCdXD31ZglDX2eZDgRRRKxwNK1ftX4VLlW0t1ijcWA@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-29742@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 359 bytes --]
New review comment by heliocat on void-packages repository
https://github.com/void-linux/void-packages/pull/29742#discussion_r601957489
Comment:
Yeah, it's dumb, but without it the test blows up as it tries to pip install something. I'm not sure which is the less bad route, install pip and keep it in-line with what upstream expects, or fix it in a patch.
next prev parent reply other threads:[~2021-03-26 1:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 7:31 [PR PATCH] " heliocat
2021-03-25 7:35 ` [PR PATCH] [Updated] " heliocat
2021-03-25 8:02 ` Piraty
2021-03-25 8:03 ` [PR REVIEW] " Piraty
2021-03-25 17:45 ` heliocat
2021-03-25 17:45 ` heliocat
2021-03-25 17:47 ` [PR PATCH] [Updated] " heliocat
2021-03-25 19:00 ` [PR REVIEW] " Piraty
2021-03-25 19:19 ` [PR PATCH] [Updated] " heliocat
2021-03-25 19:29 ` [PR PATCH] [Closed]: " heliocat
2021-03-25 22:30 ` [PR REVIEW] " abenson
2021-03-26 1:12 ` ericonr
2021-03-26 1:12 ` ericonr
2021-03-26 1:43 ` heliocat [this message]
2021-03-26 1:54 ` [PR PATCH] [Updated] " heliocat
2021-03-26 1:55 ` [PR REVIEW] " heliocat
2021-03-29 19:42 ` Piraty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210326014345.svCdXD31ZglDX2eZDgRRRKxwNK1ftX4VLlW0t1ijcWA@z \
--to=heliocat@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).