From: ailiop-git <ailiop-git@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package: pmacct-1.7.6
Date: Mon, 29 Mar 2021 16:54:58 +0200 [thread overview]
Message-ID: <20210329145458.9RwPeaX_OkEhbzVZrgBDxEQt266JFjtCt013CSH_hOw@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-29853@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 650 bytes --]
New review comment by ailiop-git on void-packages repository
https://github.com/void-linux/void-packages/pull/29853#discussion_r603364018
Comment:
> Why does it need `autoconf` and `automake`, given that it's using the `gnu-configure` build style, so at least `configure` has already been generated?
Because the makefile under src/external_libs calls autogen.sh for libcdada among other things, and generally expects to generate everything for libcdada. Indeed this shouldn't be necessary as `configure` is already generated for it, but I didn't want to mess with the makefile right now, this needs to be properly fixed in the upstream project.
next prev parent reply other threads:[~2021-03-29 14:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-29 14:22 [PR PATCH] " ailiop-git
2021-03-29 14:28 ` [PR REVIEW] " ericonr
2021-03-29 14:54 ` ailiop-git [this message]
2022-05-15 2:13 ` github-actions
2022-05-29 2:13 ` [PR PATCH] [Closed]: " github-actions
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210329145458.9RwPeaX_OkEhbzVZrgBDxEQt266JFjtCt013CSH_hOw@z \
--to=ailiop-git@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).