Github messages for voidlinux
 help / color / mirror / Atom feed
From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: bird: update to 2.0.8
Date: Mon, 29 Mar 2021 20:43:06 +0200	[thread overview]
Message-ID: <20210329184306.vjs7iM_NRUq_JTlBPxRwwcq-FgrU3tQgmF7uvEHI-No@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-29839@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1001 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29839#issuecomment-809620671

Comment:
Actually, please add this patch:

```
diff --git a/lib/printf_test.c b/lib/printf_test.c
index 47ea905..2ec5814 100644
--- a/lib/printf_test.c
+++ b/lib/printf_test.c
@@ -22,6 +22,7 @@ static int
 t_simple(void)
 {
   char buf[256];
+  const char *errormsg;
   memset(buf, 0xa5, 256);
 
   BSPRINTF(0, "", buf, "", NULL);
@@ -32,11 +33,12 @@ t_simple(void)
   BSPRINTF(1, "@", buf, "@", 64);
   BSPRINTF(1, "\xff", buf, "%c", 0xff);
 
-  errno = 5;
-  BSPRINTF(18, "Input/output error", buf, "%m");
+  errormsg = strerror(EIO);
+  errno = EIO;
+  BSPRINTF(strlen(errormsg), errormsg, buf, "%m");
   errno = 0;
 
-  BSPRINTF(18, "Input/output error", buf, "%M", 5);
+  BSPRINTF(strlen(errormsg), errormsg, buf, "%M", EIO);
 
   BSPRINTF(11, "TeSt%StRiNg", buf, "%s", "TeSt%StRiNg");
 
```

And please look into upstreaming it :)

  parent reply	other threads:[~2021-03-29 18:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-28 23:46 [PR PATCH] " klarasm
2021-03-29  0:54 ` klarasm
2021-03-29  1:29 ` ericonr
2021-03-29 18:23 ` ericonr
2021-03-29 18:36 ` ericonr
2021-03-29 18:43 ` ericonr [this message]
2021-03-29 19:12 ` [PR PATCH] [Updated] " klarasm
2021-03-29 19:22 ` klarasm
2021-03-29 19:58 ` [PR PATCH] [Merged]: " ericonr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210329184306.vjs7iM_NRUq_JTlBPxRwwcq-FgrU3tQgmF7uvEHI-No@z \
    --to=ericonr@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).