Re: icewm: update to 2.3.1.

Re: icewm: update to 2.3.1.

[glaulher]

[-- Attachment #1: Type: text/plain, Size: 261 bytes --]

New comment by glaulher on void-packages repository

https://github.com/void-linux/void-packages/pull/29998#issuecomment-813072575

Comment:
hello, it is necessary put export on the front to work.

example:
export CMAKE_GENERATOR="Unix Makefiles"

thanks.

Re: icewm: update to 2.3.1.

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 232 bytes --]

New comment by mobinmob on void-packages repository

https://github.com/void-linux/void-packages/pull/29998#issuecomment-813083637

Comment:
@glaulher Do you mean for the xlint to stop complaining? I will test that ASAP, thank you.

Re: [PR PATCH] [Updated] icewm: update to 2.3.1.

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 1844 bytes --]

There is an updated pull request by mobinmob against master on the void-packages repository

https://github.com/mobinmob/void-packages icewm
https://github.com/void-linux/void-packages/pull/29998

icewm: update to 2.3.1.
CMAKE_GENERATOR and make_cmd are adjusted to create and use a makefile and make.

```
Linting srcpkgs/icewm/template...
srcpkgs/icewm/template:25: custom variables should use _ prefix: CMAKE_GENERATOR="Unix Makefiles"
```
`xlint` is wrong here.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [X] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/29998.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-icewm-29998.patch --]
[-- Type: text/x-diff, Size: 1350 bytes --]

From 60b3f2eef02fd4745f1f072f9cf367b1f8862f99 Mon Sep 17 00:00:00 2001
From: mobinmob <mobinmob@disroot.org>
Date: Sun, 4 Apr 2021 19:49:46 +0300
Subject: [PATCH] icewm: update to 2.3.1.

---
 srcpkgs/icewm/template | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/icewm/template b/srcpkgs/icewm/template
index 1eaf2c37ce20..6b893aa533f8 100644
--- a/srcpkgs/icewm/template
+++ b/srcpkgs/icewm/template
@@ -1,8 +1,9 @@
 # Template file for 'icewm'
 pkgname=icewm
-version=2.2.1
+version=2.3.1
 revision=1
 build_style=cmake
+make_cmd=make
 configure_args="-DENABLE_LTO=ON -DCONFIG_LIBRSVG=ON -DENABLE_ALSA=ON
  -DCONFIG_XPM=ON -DCONFIG_LIBJPEG=ON -DCFGDIR=/etc/icewm"
 hostmakedepends="asciidoc gettext-devel libtool mkfontdir perl
@@ -16,10 +17,13 @@ maintainer="Glaulher <glaulher.developer@gmail.com>"
 license="GPL-2.0-or-later"
 homepage="https://ice-wm.org/"
 distfiles="https://github.com/ice-wm/icewm/archive/${version}.tar.gz"
-checksum=199a37a395e8788b4c2eeb73c46248654d785b2862b89bb5b01709eb33968dc8
+checksum=b44136a519fc2c5b8077879d1d13f2375646ff1580f3db54dd418dfc3b98e5fe
 # broken tests
 make_check=no
 
+# Ninja build files generation fails
+export CMAKE_GENERATOR="Unix Makefiles"
+
 # No c++ warnings for 'One Defintion Rules' and make sure LTO goes ok
 CXXFLAGS="-Wno-odr -fno-strict-aliasing"
 

Re: [PR PATCH] [Merged]: icewm: update to 2.3.1.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 1688 bytes --]

There's a merged pull request on the void-packages repository

icewm: update to 2.3.1.
https://github.com/void-linux/void-packages/pull/29998

Description:
CMAKE_GENERATOR and make_cmd are adjusted to create and use a makefile and make.

```
Linting srcpkgs/icewm/template...
srcpkgs/icewm/template:25: custom variables should use _ prefix: CMAKE_GENERATOR="Unix Makefiles"
```
`xlint` is wrong here.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [X] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

Re: icewm: update to 2.3.1.

[glaulher]

[-- Attachment #1: Type: text/plain, Size: 264 bytes --]

New comment by glaulher on void-packages repository

https://github.com/void-linux/void-packages/pull/29998#issuecomment-813072575

Comment:
hello, it is necessary to put export on the front to work.

example:
export CMAKE_GENERATOR="Unix Makefiles"

thanks.