[PR PATCH] uim: disable non-utf-8 anthy backend

[PR PATCH] uim: disable non-utf-8 anthy backend

[Gorggg]

[-- Attachment #1: Type: text/plain, Size: 2480 bytes --]

There is a new pull request by Gorggg against master on the void-packages repository

https://github.com/Gorggg/void-packages master
https://github.com/void-linux/void-packages/pull/29981

uim: disable non-utf-8 anthy backend
After the recent upgrade of anthy to 0.4 in [https://github.com/void-linux/void-packages/commit/700c49292eccc0cd96372e45027e2a929229e060](https://github.com/void-linux/void-packages/commit/700c49292eccc0cd96372e45027e2a929229e060), the anthy input method in uim will no longer work with the anthy available in the repository, instead requiring the anthy-utf8 input method to interface and convert kanji correctly. In order to prevent broken configurations, this change disables the build of the old anthy input method.

In order to avoid installing the new build of uim-anthy when the old anthy is present, I set uim-anthy to conflict with older versions of anthy that use EUC-JP instead of UTF-8. If there is a better way of ensuring this is not installed in a way that introduces incompatibility, I would very much like to know.

Thank you for reading this and for any reply.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/29981.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-29981.patch --]
[-- Type: text/x-diff, Size: 1685 bytes --]

From dfc4f246aaca38d9e903e88e4048b65229ec69f2 Mon Sep 17 00:00:00 2001
From: George Matsumura <gmmatsumura01@bvsd.org>
Date: Sat, 3 Apr 2021 03:22:39 -0600
Subject: [PATCH] uim: disable non-utf-8 anthy backend

The version of anthy (0.4) that is now in the repository will not
work correctly with uim's conventional anthy input method, failing
to convert kanji. It will only with the anthy-utf-8 input method,
which accounts for the substitution of the EUC-JP encoding with
UTF-8 in newer anthy versions. In order to prevent broken
configurations, this change disables the build of the old anthy
input method.
---
 srcpkgs/uim/template | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/uim/template b/srcpkgs/uim/template
index 12df0eddb067..3d3c33087fe8 100644
--- a/srcpkgs/uim/template
+++ b/srcpkgs/uim/template
@@ -1,12 +1,12 @@
 # Template file for 'uim'
 pkgname=uim
 version=1.8.8
-revision=4
+revision=5
 build_style=gnu-configure
 build_helper=qmake
 configure_args="--enable-pref --enable-fep --with-gtk2 --with-gtk3
- --with-libgcroots=installed
- --with-qt5 --with-qt5-immodule --with-x --with-anthy-utf8 --with-skk"
+ --with-libgcroots=installed --with-qt5 --with-qt5-immodule --with-x
+ --with-anthy-utf8 --without-anthy --with-skk"
 hostmakedepends="pkg-config intltool qt5-host-tools qt5-qmake automake
  libtool gettext-devel"
 makedepends="gtk+-devel gtk+3-devel qt5-devel ncurses-devel anthy-devel
@@ -61,6 +61,7 @@ uim-qt_package() {
 
 uim-anthy_package() {
 	short_desc+=" - Anthy IME"
+	conflicts="anthy-9100h_1 anthy-9100h_2"
 	pkg_install() {
 		vmove "usr/lib/uim/plugin/libuim-anthy*.so"
 		vmove "usr/share/uim/anthy*.scm"

Re: uim: disable non-utf-8 anthy backend

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 227 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29981#issuecomment-812931490

Comment:
This looks reasoanble to me, though I don't use any of the related software.

@sgn ?

Re: uim: disable non-utf-8 anthy backend

[sgn]

[-- Attachment #1: Type: text/plain, Size: 432 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/29981#issuecomment-813054981

Comment:
Hm, I would count broken `euc-JP` supports as regression. But, I'm not sure if anyone still uses euc-JP, nowaday.
I guess you're one of them? Let me see if I could restore euc-JP support.

I don't think the conflict is necessary, `libanthy` dependency will conflict with `anthy-9100*` anyway.

Re: uim: disable non-utf-8 anthy backend

[Gorggg]

[-- Attachment #1: Type: text/plain, Size: 641 bytes --]

New comment by Gorggg on void-packages repository

https://github.com/void-linux/void-packages/pull/29981#issuecomment-813089544

Comment:
@sgn 

I'm sorry, I was unclear. It isn't the EUC-JP support that is broken. In fact, my change removed EUC-JP support. The problem is that the newer versions of anthy output UTF-8, whereas the anthy backend to uim takes EUC-JP, preventing the correct conversion of kanji. Instead, the anthy-utf8 backend must be used with newer versions of anthy. That is why this change disables the backend meant to interface with old (EUC-JP) anthy.

I can remove the conflict, thank you for pointing that out.

Re: [PR PATCH] [Updated] uim: disable non-utf-8 anthy backend

[Gorggg]

[-- Attachment #1: Type: text/plain, Size: 2485 bytes --]

There is an updated pull request by Gorggg against master on the void-packages repository

https://github.com/Gorggg/void-packages master
https://github.com/void-linux/void-packages/pull/29981

uim: disable non-utf-8 anthy backend
After the recent upgrade of anthy to 0.4 in [https://github.com/void-linux/void-packages/commit/700c49292eccc0cd96372e45027e2a929229e060](https://github.com/void-linux/void-packages/commit/700c49292eccc0cd96372e45027e2a929229e060), the anthy input method in uim will no longer work with the anthy available in the repository, instead requiring the anthy-utf8 input method to interface and convert kanji correctly. In order to prevent broken configurations, this change disables the build of the old anthy input method.

In order to avoid installing the new build of uim-anthy when the old anthy is present, I set uim-anthy to conflict with older versions of anthy that use EUC-JP instead of UTF-8. If there is a better way of ensuring this is not installed in a way that introduces incompatibility, I would very much like to know.

Thank you for reading this and for any reply.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/29981.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-29981.patch --]
[-- Type: text/x-diff, Size: 1450 bytes --]

From 0e361ecf35b5b2d22907273428dd61941cb33776 Mon Sep 17 00:00:00 2001
From: George Matsumura <gmmatsumura01@bvsd.org>
Date: Sat, 3 Apr 2021 03:22:39 -0600
Subject: [PATCH] uim: disable non-utf-8 anthy backend

The version of anthy (0.4) that is now in the repository will not
work correctly with uim's conventional anthy input method, failing
to convert kanji. It will only with the anthy-utf-8 input method,
which accounts for the substitution of the EUC-JP encoding with
UTF-8 in newer anthy versions. In order to prevent broken
configurations, this change disables the build of the old anthy
input method.
---
 srcpkgs/uim/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/uim/template b/srcpkgs/uim/template
index 12df0eddb067..df686e2a3acf 100644
--- a/srcpkgs/uim/template
+++ b/srcpkgs/uim/template
@@ -1,12 +1,12 @@
 # Template file for 'uim'
 pkgname=uim
 version=1.8.8
-revision=4
+revision=5
 build_style=gnu-configure
 build_helper=qmake
 configure_args="--enable-pref --enable-fep --with-gtk2 --with-gtk3
- --with-libgcroots=installed
- --with-qt5 --with-qt5-immodule --with-x --with-anthy-utf8 --with-skk"
+ --with-libgcroots=installed --with-qt5 --with-qt5-immodule --with-x
+ --with-anthy-utf8 --without-anthy --with-skk"
 hostmakedepends="pkg-config intltool qt5-host-tools qt5-qmake automake
  libtool gettext-devel"
 makedepends="gtk+-devel gtk+3-devel qt5-devel ncurses-devel anthy-devel

Re: uim: disable non-utf-8 anthy backend

[Gorggg]

[-- Attachment #1: Type: text/plain, Size: 641 bytes --]

New comment by Gorggg on void-packages repository

https://github.com/void-linux/void-packages/pull/29981#issuecomment-813089544

Comment:
@sgn 

I'm sorry, I was unclear. It isn't the EUC-JP support that is broken. In fact, my change removes EUC-JP support. The problem is that the newer versions of anthy output UTF-8, whereas the anthy backend to uim takes EUC-JP, preventing the correct conversion of kanji. Instead, the anthy-utf8 backend must be used with newer versions of anthy. That is why this change disables the backend meant to interface with old (EUC-JP) anthy.

I can remove the conflict, thank you for pointing that out.

Re: uim: disable non-utf-8 anthy backend

[sgn]

[-- Attachment #1: Type: text/plain, Size: 1413 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/29981#issuecomment-813129721

Comment:
> @sgn
> 
> I'm sorry, I was unclear.

Sorry, It was me the one was unclear.

> It isn't the EUC-JP support that is broken. In fact, my change removes EUC-JP support. The problem is that the newer versions of anthy output UTF-8, whereas the anthy backend to uim takes EUC-JP, preventing the correct conversion of kanji. Instead, the anthy-utf8 backend must be used with newer versions of anthy. That is why this change disables the backend meant to interface with old (EUC-JP) anthy.

I understood your arguments.
However, removing euc-jp looks like to arbitrary to me.
Debian had also [removed euc-jp supports for a while][1] then [restore euc-jp support][2] because [bug #953616][bug]

Quoted from https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=9536161

> - If you have customized enabled-im-list on "stretch" system (in
>  ~/.uim.d/customs/custom-global.scm) with uim-pref-gtk or other tools,
>  uim sticks to use anthy instead of anthy-utf8 and fails kanji-conversion
>  on upgraded "buster" system.


[1]: https://salsa.debian.org/debian/uim/-/commit/d678ee362b87bfcb512d9275b4eadcc5932a3e10
[2]: https://salsa.debian.org/debian/uim/-/commit/265f012072277cc7c67abf4fda232d9a933e7d41
[bug]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=953616

Re: uim: disable non-utf-8 anthy backend

[sgn]

[-- Attachment #1: Type: text/plain, Size: 1414 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/29981#issuecomment-813129721

Comment:
> @sgn
> 
> I'm sorry, I was unclear.

Sorry, It was me the one was unclear.

> It isn't the EUC-JP support that is broken. In fact, my change removes EUC-JP support. The problem is that the newer versions of anthy output UTF-8, whereas the anthy backend to uim takes EUC-JP, preventing the correct conversion of kanji. Instead, the anthy-utf8 backend must be used with newer versions of anthy. That is why this change disables the backend meant to interface with old (EUC-JP) anthy.

I understood your arguments.
However, removing euc-jp looks like too arbitrary to me.
Debian had also [removed euc-jp supports for a while][1] then [restore euc-jp support][2] because [bug #953616][bug]

Quoted from https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=9536161

> - If you have customized enabled-im-list on "stretch" system (in
>  ~/.uim.d/customs/custom-global.scm) with uim-pref-gtk or other tools,
>  uim sticks to use anthy instead of anthy-utf8 and fails kanji-conversion
>  on upgraded "buster" system.


[1]: https://salsa.debian.org/debian/uim/-/commit/d678ee362b87bfcb512d9275b4eadcc5932a3e10
[2]: https://salsa.debian.org/debian/uim/-/commit/265f012072277cc7c67abf4fda232d9a933e7d41
[bug]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=953616

Re: uim: disable non-utf-8 anthy backend

[sgn]

[-- Attachment #1: Type: text/plain, Size: 1408 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/29981#issuecomment-813129721

Comment:
> @sgn
> 
> I'm sorry, I was unclear.

Sorry, It was me the one was unclear.

> It isn't the EUC-JP support that is broken. In fact, my change removes EUC-JP support. The problem is that the newer versions of anthy output UTF-8, whereas the anthy backend to uim takes EUC-JP, preventing the correct conversion of kanji. Instead, the anthy-utf8 backend must be used with newer versions of anthy. That is why this change disables the backend meant to interface with old (EUC-JP) anthy.

I understood your arguments.
However, removing euc-jp looks like too arbitrary to me.
Debian had also [removed euc-jp supports for a while][1] then [restore anthy][2] because of [bug #953616][bug]

Quoted from https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=9536161

> - If you have customized enabled-im-list on "stretch" system (in
>  ~/.uim.d/customs/custom-global.scm) with uim-pref-gtk or other tools,
>  uim sticks to use anthy instead of anthy-utf8 and fails kanji-conversion
>  on upgraded "buster" system.


[1]: https://salsa.debian.org/debian/uim/-/commit/d678ee362b87bfcb512d9275b4eadcc5932a3e10
[2]: https://salsa.debian.org/debian/uim/-/commit/265f012072277cc7c67abf4fda232d9a933e7d41
[bug]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=953616

Re: uim: disable non-utf-8 anthy backend

[Gorggg]

[-- Attachment #1: Type: text/plain, Size: 847 bytes --]

New comment by Gorggg on void-packages repository

https://github.com/void-linux/void-packages/pull/29981#issuecomment-813142815

Comment:
@sgn 

> 
> Quoted from https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=9536161
> 
> > 
> > If you have customized enabled-im-list on "stretch" system (in
> > ~/.uim.d/customs/custom-global.scm) with uim-pref-gtk or other tools,
> > uim sticks to use anthy instead of anthy-utf8 and fails kanji-conversion
> > on upgraded "buster" system.

This sounds like exactly the issue I had. I had added the conventional anthy backend (which used euc-jp) to the custom im list. When I upgraded, kanji conversion failed because uim was still using the old backend even when anthy was upgraded to a UTF-8 version. That was what prompted me to submit this fix.

Thank you for your time in addressing this.

Re: uim: disable non-utf-8 anthy backend

[Gorggg]

[-- Attachment #1: Type: text/plain, Size: 847 bytes --]

New comment by Gorggg on void-packages repository

https://github.com/void-linux/void-packages/pull/29981#issuecomment-813142815

Comment:
@sgn 

> 
> Quoted from https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=9536161
> 
> > 
> > If you have customized enabled-im-list on "stretch" system (in
> > ~/.uim.d/customs/custom-global.scm) with uim-pref-gtk or other tools,
> > uim sticks to use anthy instead of anthy-utf8 and fails kanji-conversion
> > on upgraded "buster" system.

This sounds like exactly the issue I had. I had added the conventional anthy backend (which used EUC-JP) to the custom im list. When I upgraded, kanji conversion failed because uim was still using the old backend even when anthy was upgraded to a UTF-8 version. That was what prompted me to submit this fix.

Thank you for your time in addressing this.

Re: uim: disable non-utf-8 anthy backend

[Gorggg]

[-- Attachment #1: Type: text/plain, Size: 1048 bytes --]

New comment by Gorggg on void-packages repository

https://github.com/void-linux/void-packages/pull/29981#issuecomment-813142815

Comment:
@sgn 

> 
> Quoted from https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=9536161
> 
> > 
> > If you have customized enabled-im-list on "stretch" system (in
> > ~/.uim.d/customs/custom-global.scm) with uim-pref-gtk or other tools,
> > uim sticks to use anthy instead of anthy-utf8 and fails kanji-conversion
> > on upgraded "buster" system.

This sounds like exactly the issue I had. I had added the conventional anthy backend (which used EUC-JP) to the custom im list. When I upgraded, kanji conversion failed because uim was still using the old backend even when anthy was upgraded to a UTF-8 version. That was what prompted me to submit this fix.

I guess this change is a bit selfish for my particular case, it was just very difficult to figure out why kanji input was suddenly no longer working and I wanted to spare other people that trouble.

Thank you for your time in addressing this.

Re: uim: disable non-utf-8 anthy backend

[Gorggg]

[-- Attachment #1: Type: text/plain, Size: 1249 bytes --]

New comment by Gorggg on void-packages repository

https://github.com/void-linux/void-packages/pull/29981#issuecomment-813142815

Comment:
@sgn 

> 
> Quoted from https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=9536161
> 
> > 
> > If you have customized enabled-im-list on "stretch" system (in
> > ~/.uim.d/customs/custom-global.scm) with uim-pref-gtk or other tools,
> > uim sticks to use anthy instead of anthy-utf8 and fails kanji-conversion
> > on upgraded "buster" system.

This sounds like exactly the issue I had. I had added the conventional anthy backend (which used EUC-JP) to the custom im list. When I upgraded, kanji conversion failed because uim was still using the old backend even when anthy was upgraded to a UTF-8 version. That was what prompted me to submit this fix.

I guess this change is a bit selfish for my particular case, it was just very difficult to figure out why kanji input was suddenly no longer working and I wanted to spare other people that trouble. I was hoping that not working with the EUC-JP version of anthy would not be a problem, since an EUC-JP version is no longer in the repositories, but if otherwise I wouldn't want to break other setups.

Thank you for your time in addressing this.

Re: uim: disable non-utf-8 anthy backend

[sgn]

[-- Attachment #1: Type: text/plain, Size: 214 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/29981#issuecomment-814077063

Comment:
I think we should ship a message/readme for this package? Would it be better?

Re: uim: disable non-utf-8 anthy backend

[Gorggg]

[-- Attachment #1: Type: text/plain, Size: 422 bytes --]

New comment by Gorggg on void-packages repository

https://github.com/void-linux/void-packages/pull/29981#issuecomment-814239479

Comment:
@sgn 

In that case, I would think the patch would properly be applied to the anthy package rather than this one, as it is the upgrade of anthy from version 9100h to 0.4 which would change the encoding, not any particular change in uim. I can try to create that if you would like.

Re: uim: disable non-utf-8 anthy backend

[sgn]

[-- Attachment #1: Type: text/plain, Size: 316 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/29981#issuecomment-814512959

Comment:
Other Anthy based IME works fine, so I think it's irrelevant to them. uim would need a rev-bump soon for other reasons. I think it would make sense to put it in uim-anthy instead.

Re: uim: disable non-utf-8 anthy backend

[sgn]

[-- Attachment #1: Type: text/plain, Size: 1407 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/29981#issuecomment-813129721

Comment:
> @sgn
> 
> I'm sorry, I was unclear.

Sorry, It was me the one was unclear.

> It isn't the EUC-JP support that is broken. In fact, my change removes EUC-JP support. The problem is that the newer versions of anthy output UTF-8, whereas the anthy backend to uim takes EUC-JP, preventing the correct conversion of kanji. Instead, the anthy-utf8 backend must be used with newer versions of anthy. That is why this change disables the backend meant to interface with old (EUC-JP) anthy.

I understood your arguments.
However, removing euc-jp looks like too arbitrary to me.
Debian had also [removed euc-jp supports for a while][1] then [restore anthy][2] because of [bug #953616][bug]

Quoted from https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=953616

> - If you have customized enabled-im-list on "stretch" system (in
>  ~/.uim.d/customs/custom-global.scm) with uim-pref-gtk or other tools,
>  uim sticks to use anthy instead of anthy-utf8 and fails kanji-conversion
>  on upgraded "buster" system.


[1]: https://salsa.debian.org/debian/uim/-/commit/d678ee362b87bfcb512d9275b4eadcc5932a3e10
[2]: https://salsa.debian.org/debian/uim/-/commit/265f012072277cc7c67abf4fda232d9a933e7d41
[bug]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=953616

Re: [PR PATCH] [Closed]: uim: disable non-utf-8 anthy backend

[sgn]

[-- Attachment #1: Type: text/plain, Size: 2332 bytes --]

There's a closed pull request on the void-packages repository

uim: disable non-utf-8 anthy backend
https://github.com/void-linux/void-packages/pull/29981

Description:
After the recent upgrade of anthy to 0.4 in [https://github.com/void-linux/void-packages/commit/700c49292eccc0cd96372e45027e2a929229e060](https://github.com/void-linux/void-packages/commit/700c49292eccc0cd96372e45027e2a929229e060), the anthy input method in uim will no longer work with the anthy available in the repository, instead requiring the anthy-utf8 input method to interface and convert kanji correctly. In order to prevent broken configurations, this change disables the build of the old anthy input method.

In order to avoid installing the new build of uim-anthy when the old anthy is present, I set uim-anthy to conflict with older versions of anthy that use EUC-JP instead of UTF-8. If there is a better way of ensuring this is not installed in a way that introduces incompatibility, I would very much like to know.

Thank you for reading this and for any reply.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->