[PR PATCH] exa: update to 0.10.0

[PR PATCH] exa: update to 0.10.0

[FollieHiyuki]

[-- Attachment #1: Type: text/plain, Size: 1780 bytes --]

There is a new pull request by FollieHiyuki against master on the void-packages repository

https://github.com/FollieHiyuki/void-packages exa-update
https://github.com/void-linux/void-packages/pull/30005

exa: update to 0.10.0
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

Upstream uses markdown for the man pages and convert them into plain text with `pandoc`. I don't know a convenient way to install them.
Another option is to pull the pre-compiled man pages from their release.


A patch file from https://github.com/void-linux/void-packages/pull/30005.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-exa-update-30005.patch --]
[-- Type: text/x-diff, Size: 1379 bytes --]

From eeb16ad39bea7435bcb6f6062558209d23b20d82 Mon Sep 17 00:00:00 2001
From: FollieHiyuki <folliekazetani@protonmail.com>
Date: Sun, 4 Apr 2021 23:31:03 +0300
Subject: [PATCH] exa: update to 0.10.0

---
 srcpkgs/exa/template | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/srcpkgs/exa/template b/srcpkgs/exa/template
index 5ea748de3627..9b7c9af356ed 100644
--- a/srcpkgs/exa/template
+++ b/srcpkgs/exa/template
@@ -1,21 +1,20 @@
 # Template file for 'exa'
 pkgname=exa
-version=0.9.0
-revision=2
+version=0.10.0
+revision=1
 build_style=cargo
-hostmakedepends="pkg-config"
+hostmakedepends="pkg-config libgit2-devel"
 makedepends="libgit2-devel"
 short_desc="Modern replacement for ls"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="MIT"
 homepage="https://the.exa.website/"
 distfiles="https://github.com/ogham/exa/archive/v${version}.tar.gz"
-checksum=@facbe3b234f403e1e1919f28f009f1733a0fbbbb11f0bc2ba89ac3eba11bc5e8
+checksum=27420f7b805941988399d63f388be4f6077eee94a505bf01c2fb0e7d15cbf78d
 
 post_install() {
-	vman contrib/man/exa.1
-	vcompletion contrib/completions.bash bash
-	vcompletion contrib/completions.fish fish
-	vcompletion contrib/completions.zsh zsh
+	vcompletion completions/completions.bash bash
+	vcompletion completions/completions.fish fish
+	vcompletion completions/completions.zsh zsh
 	vlicense LICENCE
 }

Re: [PR PATCH] [Updated] exa: update to 0.10.0

[FollieHiyuki]

[-- Attachment #1: Type: text/plain, Size: 1785 bytes --]

There is an updated pull request by FollieHiyuki against master on the void-packages repository

https://github.com/FollieHiyuki/void-packages exa-update
https://github.com/void-linux/void-packages/pull/30005

exa: update to 0.10.0
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

Upstream uses markdown for the man pages and convert them into plain text with `pandoc`. I don't know a convenient way to install them.
Another option is to pull the pre-compiled man pages from their release.


A patch file from https://github.com/void-linux/void-packages/pull/30005.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-exa-update-30005.patch --]
[-- Type: text/x-diff, Size: 1735 bytes --]

From d118911a184423f5676e7be7769192dd1c577397 Mon Sep 17 00:00:00 2001
From: FollieHiyuki <folliekazetani@protonmail.com>
Date: Sun, 4 Apr 2021 23:31:03 +0300
Subject: [PATCH] exa: update to 0.10.0; adopt

---
 srcpkgs/exa/template | 23 +++++++++++++----------
 1 file changed, 13 insertions(+), 10 deletions(-)

diff --git a/srcpkgs/exa/template b/srcpkgs/exa/template
index 5ea748de3627..b34c5126a90c 100644
--- a/srcpkgs/exa/template
+++ b/srcpkgs/exa/template
@@ -1,21 +1,24 @@
 # Template file for 'exa'
 pkgname=exa
-version=0.9.0
-revision=2
+version=0.10.0
+revision=1
 build_style=cargo
-hostmakedepends="pkg-config"
+hostmakedepends="pkg-config libgit2-devel"
 makedepends="libgit2-devel"
 short_desc="Modern replacement for ls"
-maintainer="Orphaned <orphan@voidlinux.org>"
+maintainer="FollieHiyuki <folliekazetani@protonmail.com>"
 license="MIT"
 homepage="https://the.exa.website/"
-distfiles="https://github.com/ogham/exa/archive/v${version}.tar.gz"
-checksum=@facbe3b234f403e1e1919f28f009f1733a0fbbbb11f0bc2ba89ac3eba11bc5e8
+distfiles="https://github.com/ogham/exa/archive/v${version}.tar.gz
+ https://github.com/ogham/exa/releases/download/v${version}/exa-accoutrements-v${version}.zip"
+checksum="27420f7b805941988399d63f388be4f6077eee94a505bf01c2fb0e7d15cbf78d
+ c1ab340af63e64bc3fd854c03f6161aa240a533e928688036a7d4544aecabc05"
 
 post_install() {
-	vman contrib/man/exa.1
-	vcompletion contrib/completions.bash bash
-	vcompletion contrib/completions.fish fish
-	vcompletion contrib/completions.zsh zsh
+	vman ../man/exa.1
+	vman ../man/exa_colors.5
+	vcompletion completions/completions.bash bash
+	vcompletion completions/completions.fish fish
+	vcompletion completions/completions.zsh zsh
 	vlicense LICENCE
 }

Re: [PR REVIEW] exa: update to 0.10.0

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 398 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/30005#discussion_r606864167

Comment:
The only issue is that this means we have a leftover directory when the package is cleaned up.

You can move it inside the wrksrc in `post_extract` doing: `mv ../exa-accoutrements-v$version accoutrements` and then `vinstall` later with the new path.

Re: [PR REVIEW] exa: update to 0.10.0

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 251 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/30005#discussion_r606864045

Comment:
Did they forget to remove completions from the normal repo? It's in the `accoutrements` tarball as well.

Re: [PR REVIEW] exa: update to 0.10.0

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 234 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/30005#discussion_r606864008

Comment:
I much prefer this over generating them at build time (especially when it uses pandoc).

Re: [PR REVIEW] exa: update to 0.10.0

[FollieHiyuki]

[-- Attachment #1: Type: text/plain, Size: 303 bytes --]

New review comment by FollieHiyuki on void-packages repository

https://github.com/void-linux/void-packages/pull/30005#discussion_r606865533

Comment:
I think the `accoutrements` tarball is just the compiled man pages and the completion copied over. So better use what is already inside the normal repo

Re: [PR PATCH] [Updated] exa: update to 0.10.0

[FollieHiyuki]

[-- Attachment #1: Type: text/plain, Size: 1785 bytes --]

There is an updated pull request by FollieHiyuki against master on the void-packages repository

https://github.com/FollieHiyuki/void-packages exa-update
https://github.com/void-linux/void-packages/pull/30005

exa: update to 0.10.0
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

Upstream uses markdown for the man pages and convert them into plain text with `pandoc`. I don't know a convenient way to install them.
Another option is to pull the pre-compiled man pages from their release.


A patch file from https://github.com/void-linux/void-packages/pull/30005.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-exa-update-30005.patch --]
[-- Type: text/x-diff, Size: 1873 bytes --]

From 68445221a8271b7301a4ad7dab44e24013c8a651 Mon Sep 17 00:00:00 2001
From: FollieHiyuki <folliekazetani@protonmail.com>
Date: Sun, 4 Apr 2021 23:31:03 +0300
Subject: [PATCH] exa: update to 0.10.0; adopt

---
 srcpkgs/exa/template | 29 +++++++++++++++++++----------
 1 file changed, 19 insertions(+), 10 deletions(-)

diff --git a/srcpkgs/exa/template b/srcpkgs/exa/template
index 5ea748de3627..ea3ad487fa43 100644
--- a/srcpkgs/exa/template
+++ b/srcpkgs/exa/template
@@ -1,21 +1,30 @@
 # Template file for 'exa'
 pkgname=exa
-version=0.9.0
-revision=2
+version=0.10.0
+revision=1
 build_style=cargo
-hostmakedepends="pkg-config"
+hostmakedepends="pkg-config libgit2-devel"
 makedepends="libgit2-devel"
 short_desc="Modern replacement for ls"
-maintainer="Orphaned <orphan@voidlinux.org>"
+maintainer="FollieHiyuki <folliekazetani@protonmail.com>"
 license="MIT"
 homepage="https://the.exa.website/"
-distfiles="https://github.com/ogham/exa/archive/v${version}.tar.gz"
-checksum=@facbe3b234f403e1e1919f28f009f1733a0fbbbb11f0bc2ba89ac3eba11bc5e8
+distfiles="https://github.com/ogham/exa/archive/v${version}.tar.gz
+ https://github.com/ogham/exa/releases/download/v${version}/exa-accoutrements-v${version}.zip"
+checksum="27420f7b805941988399d63f388be4f6077eee94a505bf01c2fb0e7d15cbf78d
+ c1ab340af63e64bc3fd854c03f6161aa240a533e928688036a7d4544aecabc05"
+
+post_extract() {
+	mkdir -p accoutrements
+	mv ../man accoutrements/
+	mv ../completions accoutrements/
+}
 
 post_install() {
-	vman contrib/man/exa.1
-	vcompletion contrib/completions.bash bash
-	vcompletion contrib/completions.fish fish
-	vcompletion contrib/completions.zsh zsh
+	vman accoutrements/man/exa.1
+	vman accoutrements/man/exa_colors.5
+	vcompletion completions/completions.bash bash
+	vcompletion completions/completions.fish fish
+	vcompletion completions/completions.zsh zsh
 	vlicense LICENCE
 }

Re: [PR REVIEW] exa: update to 0.10.0

[FollieHiyuki]

[-- Attachment #1: Type: text/plain, Size: 156 bytes --]

New review comment by FollieHiyuki on void-packages repository

https://github.com/void-linux/void-packages/pull/30005#discussion_r606866386

Comment:
Done

Re: [PR PATCH] [Merged]: exa: update to 0.10.0

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 1616 bytes --]

There's a merged pull request on the void-packages repository

exa: update to 0.10.0
https://github.com/void-linux/void-packages/pull/30005

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

Upstream uses markdown for the man pages and convert them into plain text with `pandoc`. I don't know a convenient way to install them.
Another option is to pull the pre-compiled man pages from their release.