Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] corkscrew: fix license, fix homepage
@ 2021-03-26 18:04 heliocat
  2021-03-26 23:43 ` [PR REVIEW] " sgn
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: heliocat @ 2021-03-26 18:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1602 bytes --]

There is a new pull request by heliocat against master on the void-packages repository

https://github.com/heliocat/void-packages corkscrew
https://github.com/void-linux/void-packages/pull/29764

corkscrew: fix license, fix homepage
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/29764.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-corkscrew-29764.patch --]
[-- Type: text/x-diff, Size: 1332 bytes --]

From 8fbdb0d2a10e98add028486b71cb742e8df16314 Mon Sep 17 00:00:00 2001
From: Colin Booth <colin@heliocat.net>
Date: Fri, 26 Mar 2021 11:00:42 -0700
Subject: [PATCH] corkscrew: fix license, fix homepage

---
 srcpkgs/corkscrew/template | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/corkscrew/template b/srcpkgs/corkscrew/template
index a7c4327bc7da..39321f2f72c4 100644
--- a/srcpkgs/corkscrew/template
+++ b/srcpkgs/corkscrew/template
@@ -1,12 +1,16 @@
 # Template file for 'corkscrew'
 pkgname=corkscrew
 version=2.0
-revision=1
+revision=2
 build_style=gnu-configure
+hostmakedepends="automake"
 short_desc="Corkscrew is a tool for tunneling SSH through HTTP proxies"
 maintainer="pulux <pulux@pf4sh.de>"
-license="GPL-2"
-homepage="http://www.agroman.net/corkscrew/"
-#distfiles="http://agroman.net/corkscrew/$pkgname-$version.tar.gz"
-distfiles="https://ftp.heanet.ie/mirrors/OpenBSD/distfiles/corkscrew-${version}.tar.gz"
-checksum=0d0fcbb41cba4a81c4ab494459472086f377f9edb78a2e2238ed19b58956b0be
+license="GPL-2.0-or-later"
+homepage="https://github.com/bryanpkc/corkscrew"
+distfiles="https://github.com/bryanpkc/corkscrew/archive/refs/tags/v${version}.tar.gz"
+checksum=09d70daaa3145070a1e463dbab6ae1cbc62449b1e09c94e158f6017e7c79c9f6
+
+pre_configure() {
+	autoreconf -fi
+}

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR REVIEW] corkscrew: fix license, fix homepage
  2021-03-26 18:04 [PR PATCH] corkscrew: fix license, fix homepage heliocat
@ 2021-03-26 23:43 ` sgn
  2021-03-27  5:36 ` heliocat
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: sgn @ 2021-03-26 23:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 169 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/29764#discussion_r602633819

Comment:
Why do we need autoreconf?

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR REVIEW] corkscrew: fix license, fix homepage
  2021-03-26 18:04 [PR PATCH] corkscrew: fix license, fix homepage heliocat
  2021-03-26 23:43 ` [PR REVIEW] " sgn
@ 2021-03-27  5:36 ` heliocat
  2021-03-27  5:38 ` heliocat
  2021-04-04 23:26 ` [PR PATCH] [Closed]: corkscrew: fix license, fix homepage, fix build ericonr
  3 siblings, 0 replies; 5+ messages in thread
From: heliocat @ 2021-03-27  5:36 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 224 bytes --]

New review comment by heliocat on void-packages repository

https://github.com/void-linux/void-packages/pull/29764#discussion_r602674016

Comment:
Because without autoreconf the configure script isn't available and it dies.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR REVIEW] corkscrew: fix license, fix homepage
  2021-03-26 18:04 [PR PATCH] corkscrew: fix license, fix homepage heliocat
  2021-03-26 23:43 ` [PR REVIEW] " sgn
  2021-03-27  5:36 ` heliocat
@ 2021-03-27  5:38 ` heliocat
  2021-04-04 23:26 ` [PR PATCH] [Closed]: corkscrew: fix license, fix homepage, fix build ericonr
  3 siblings, 0 replies; 5+ messages in thread
From: heliocat @ 2021-03-27  5:38 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 319 bytes --]

New review comment by heliocat on void-packages repository

https://github.com/void-linux/void-packages/pull/29764#discussion_r602674016

Comment:
Because without autoreconf the configure script isn't available and it dies. I have a feeling that when it was built last five years ago the build defaults were different.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR PATCH] [Closed]: corkscrew: fix license, fix homepage, fix build
  2021-03-26 18:04 [PR PATCH] corkscrew: fix license, fix homepage heliocat
                   ` (2 preceding siblings ...)
  2021-03-27  5:38 ` heliocat
@ 2021-04-04 23:26 ` ericonr
  3 siblings, 0 replies; 5+ messages in thread
From: ericonr @ 2021-04-04 23:26 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1447 bytes --]

There's a closed pull request on the void-packages repository

corkscrew: fix license, fix homepage, fix build
https://github.com/void-linux/void-packages/pull/29764

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-04-04 23:26 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-26 18:04 [PR PATCH] corkscrew: fix license, fix homepage heliocat
2021-03-26 23:43 ` [PR REVIEW] " sgn
2021-03-27  5:36 ` heliocat
2021-03-27  5:38 ` heliocat
2021-04-04 23:26 ` [PR PATCH] [Closed]: corkscrew: fix license, fix homepage, fix build ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).