Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] mupen64plus: update to 2.5.9
@ 2021-03-23  3:07 zlice
  2021-03-23  3:21 ` [PR PATCH] [Updated] " zlice
                   ` (9 more replies)
  0 siblings, 10 replies; 11+ messages in thread
From: zlice @ 2021-03-23  3:07 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 971 bytes --]

There is a new pull request by zlice against master on the void-packages repository

https://github.com/zlice/void-packages mupen64plus-update-to-2.5.9
https://github.com/void-linux/void-packages/pull/29692

mupen64plus: update to 2.5.9
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86-64, libc)

#### Comments
2.5 was wobbling walls and textures in Mario64
Not sure if `nopie` is an issue, first time I've had to add that.

2.5 was from 2015, 2.5.9 is from 2019

A patch file from https://github.com/void-linux/void-packages/pull/29692.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mupen64plus-update-to-2.5.9-29692.patch --]
[-- Type: text/x-diff, Size: 1414 bytes --]

From 18b0c6e77f9c350447ed04faebc78d672b3b9192 Mon Sep 17 00:00:00 2001
From: Corey Thomas <cthomas@oisf.net>
Date: Mon, 22 Mar 2021 23:02:10 -0400
Subject: [PATCH] mupen64plus: update to 2.5.9

---
 srcpkgs/mupen64plus/template | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/mupen64plus/template b/srcpkgs/mupen64plus/template
index 0323d321803c..35e0ccc76529 100644
--- a/srcpkgs/mupen64plus/template
+++ b/srcpkgs/mupen64plus/template
@@ -1,18 +1,19 @@
 # Template file for 'mupen64plus'
 pkgname=mupen64plus
-version=2.5
-revision=13
+version=2.5.9
+revision=1
 wrksrc="mupen64plus-bundle-src-${version}"
 hostmakedepends="pkg-config which"
-makedepends="boost-devel SDL2-devel speexdsp-devel freetype-devel glu-devel libpng-devel libsamplerate-devel"
+makedepends="boost-devel SDL2-devel speexdsp-devel freetype-devel glu-devel libpng-devel libsamplerate-devel nasm"
 depends="desktop-file-utils"
 short_desc="A Nintendo64 Emulator"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2"
 homepage="http://www.mupen64plus.org"
 distfiles="https://github.com/mupen64plus/mupen64plus-core/releases/download/${version}/${pkgname}-bundle-src-${version}.tar.gz"
-checksum=9c75b9d826f2d24666175f723a97369b3a6ee159b307f7cc876bbb4facdbba66
+checksum=d5243ddc00388ee2e538b3826a78a719dec2bd5da54ac6f3344fed861fb141a8
 archs="i686* x86_64*"
+nopie=yes
 
 CFLAGS="-fcommon"
 

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR PATCH] [Updated] mupen64plus: update to 2.5.9
  2021-03-23  3:07 [PR PATCH] mupen64plus: update to 2.5.9 zlice
@ 2021-03-23  3:21 ` zlice
  2021-03-23  3:24 ` zlice
                   ` (8 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: zlice @ 2021-03-23  3:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 976 bytes --]

There is an updated pull request by zlice against master on the void-packages repository

https://github.com/zlice/void-packages mupen64plus-update-to-2.5.9
https://github.com/void-linux/void-packages/pull/29692

mupen64plus: update to 2.5.9
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86-64, libc)

#### Comments
2.5 was wobbling walls and textures in Mario64
Not sure if `nopie` is an issue, first time I've had to add that.

2.5 was from 2015, 2.5.9 is from 2019

A patch file from https://github.com/void-linux/void-packages/pull/29692.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mupen64plus-update-to-2.5.9-29692.patch --]
[-- Type: text/x-diff, Size: 1477 bytes --]

From b61afaff350a66733071046c232f2286b8a0abea Mon Sep 17 00:00:00 2001
From: Corey Thomas <cthomas@oisf.net>
Date: Mon, 22 Mar 2021 23:02:10 -0400
Subject: [PATCH] mupen64plus: update to 2.5.9

---
 srcpkgs/mupen64plus/template | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/mupen64plus/template b/srcpkgs/mupen64plus/template
index 0323d321803c..a46f33c8de1e 100644
--- a/srcpkgs/mupen64plus/template
+++ b/srcpkgs/mupen64plus/template
@@ -1,18 +1,19 @@
 # Template file for 'mupen64plus'
 pkgname=mupen64plus
-version=2.5
-revision=13
+version=2.5.9
+revision=1
 wrksrc="mupen64plus-bundle-src-${version}"
 hostmakedepends="pkg-config which"
-makedepends="boost-devel SDL2-devel speexdsp-devel freetype-devel glu-devel libpng-devel libsamplerate-devel"
+makedepends="boost-devel SDL2-devel speexdsp-devel freetype-devel glu-devel libpng-devel libsamplerate-devel nasm"
 depends="desktop-file-utils"
-short_desc="A Nintendo64 Emulator"
+short_desc="Nintendo64 Emulator"
 maintainer="Orphaned <orphan@voidlinux.org>"
-license="GPL-2"
+license="GPL-2.0-only"
 homepage="http://www.mupen64plus.org"
 distfiles="https://github.com/mupen64plus/mupen64plus-core/releases/download/${version}/${pkgname}-bundle-src-${version}.tar.gz"
-checksum=9c75b9d826f2d24666175f723a97369b3a6ee159b307f7cc876bbb4facdbba66
 archs="i686* x86_64*"
+checksum=d5243ddc00388ee2e538b3826a78a719dec2bd5da54ac6f3344fed861fb141a8
+nopie=yes
 
 CFLAGS="-fcommon"
 

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR PATCH] [Updated] mupen64plus: update to 2.5.9
  2021-03-23  3:07 [PR PATCH] mupen64plus: update to 2.5.9 zlice
  2021-03-23  3:21 ` [PR PATCH] [Updated] " zlice
@ 2021-03-23  3:24 ` zlice
  2021-03-23  3:25 ` zlice
                   ` (7 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: zlice @ 2021-03-23  3:24 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1033 bytes --]

There is an updated pull request by zlice against master on the void-packages repository

https://github.com/zlice/void-packages mupen64plus-update-to-2.5.9
https://github.com/void-linux/void-packages/pull/29692

mupen64plus: update to 2.5.9
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86-64, libc)

#### Comments
2.5 was wobbling walls and textures in Mario64
Not sure if `nopie` is an issue, first time I've had to add that.

2.5 was from 2015, 2.5.9 is from 2019

edit:
updated linting
no clue on gpl spdx specifics

A patch file from https://github.com/void-linux/void-packages/pull/29692.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mupen64plus-update-to-2.5.9-29692.patch --]
[-- Type: text/x-diff, Size: 1609 bytes --]

From 3f5a8919cd6a287e11aa22e2a75e35dbfd5d9a22 Mon Sep 17 00:00:00 2001
From: Corey Thomas <cthomas@oisf.net>
Date: Mon, 22 Mar 2021 23:02:10 -0400
Subject: [PATCH] mupen64plus: update to 2.5.9

---
 srcpkgs/mupen64plus/template | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/mupen64plus/template b/srcpkgs/mupen64plus/template
index 0323d321803c..4cee6ad843f9 100644
--- a/srcpkgs/mupen64plus/template
+++ b/srcpkgs/mupen64plus/template
@@ -1,18 +1,19 @@
 # Template file for 'mupen64plus'
 pkgname=mupen64plus
-version=2.5
-revision=13
+version=2.5.9
+revision=1
 wrksrc="mupen64plus-bundle-src-${version}"
 hostmakedepends="pkg-config which"
-makedepends="boost-devel SDL2-devel speexdsp-devel freetype-devel glu-devel libpng-devel libsamplerate-devel"
+makedepends="boost-devel SDL2-devel speexdsp-devel freetype-devel glu-devel libpng-devel libsamplerate-devel nasm"
 depends="desktop-file-utils"
-short_desc="A Nintendo64 Emulator"
+short_desc="Nintendo64 Emulator"
 maintainer="Orphaned <orphan@voidlinux.org>"
-license="GPL-2"
+license="GPL-2.0-only"
 homepage="http://www.mupen64plus.org"
-distfiles="https://github.com/mupen64plus/mupen64plus-core/releases/download/${version}/${pkgname}-bundle-src-${version}.tar.gz"
-checksum=9c75b9d826f2d24666175f723a97369b3a6ee159b307f7cc876bbb4facdbba66
 archs="i686* x86_64*"
+distfiles="https://github.com/mupen64plus/mupen64plus-core/releases/download/${version}/${pkgname}-bundle-src-${version}.tar.gz"
+checksum=d5243ddc00388ee2e538b3826a78a719dec2bd5da54ac6f3344fed861fb141a8
+nopie=yes
 
 CFLAGS="-fcommon"
 

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR PATCH] [Updated] mupen64plus: update to 2.5.9
  2021-03-23  3:07 [PR PATCH] mupen64plus: update to 2.5.9 zlice
  2021-03-23  3:21 ` [PR PATCH] [Updated] " zlice
  2021-03-23  3:24 ` zlice
@ 2021-03-23  3:25 ` zlice
  2021-03-23  3:27 ` zlice
                   ` (6 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: zlice @ 2021-03-23  3:25 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1033 bytes --]

There is an updated pull request by zlice against master on the void-packages repository

https://github.com/zlice/void-packages mupen64plus-update-to-2.5.9
https://github.com/void-linux/void-packages/pull/29692

mupen64plus: update to 2.5.9
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86-64, libc)

#### Comments
2.5 was wobbling walls and textures in Mario64
Not sure if `nopie` is an issue, first time I've had to add that.

2.5 was from 2015, 2.5.9 is from 2019

edit:
updated linting
no clue on gpl spdx specifics

A patch file from https://github.com/void-linux/void-packages/pull/29692.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mupen64plus-update-to-2.5.9-29692.patch --]
[-- Type: text/x-diff, Size: 1502 bytes --]

From d3ebcfb6b8926f3e8453ec111b0d46d3001105ff Mon Sep 17 00:00:00 2001
From: Corey Thomas <cthomas@oisf.net>
Date: Mon, 22 Mar 2021 23:02:10 -0400
Subject: [PATCH] mupen64plus: update to 2.5.9

---
 srcpkgs/mupen64plus/template | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/mupen64plus/template b/srcpkgs/mupen64plus/template
index 0323d321803c..115c6e65b2c6 100644
--- a/srcpkgs/mupen64plus/template
+++ b/srcpkgs/mupen64plus/template
@@ -1,18 +1,19 @@
 # Template file for 'mupen64plus'
 pkgname=mupen64plus
-version=2.5
-revision=13
+version=2.5.9
+revision=1
 wrksrc="mupen64plus-bundle-src-${version}"
 hostmakedepends="pkg-config which"
-makedepends="boost-devel SDL2-devel speexdsp-devel freetype-devel glu-devel libpng-devel libsamplerate-devel"
+makedepends="boost-devel SDL2-devel speexdsp-devel freetype-devel glu-devel libpng-devel libsamplerate-devel nasm"
 depends="desktop-file-utils"
-short_desc="A Nintendo64 Emulator"
+short_desc="Nintendo64 Emulator"
 maintainer="Orphaned <orphan@voidlinux.org>"
-license="GPL-2"
+license="GPL-2.0-only"
+archs="i686* x86_64*"
 homepage="http://www.mupen64plus.org"
 distfiles="https://github.com/mupen64plus/mupen64plus-core/releases/download/${version}/${pkgname}-bundle-src-${version}.tar.gz"
-checksum=9c75b9d826f2d24666175f723a97369b3a6ee159b307f7cc876bbb4facdbba66
-archs="i686* x86_64*"
+checksum=d5243ddc00388ee2e538b3826a78a719dec2bd5da54ac6f3344fed861fb141a8
+nopie=yes
 
 CFLAGS="-fcommon"
 

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR PATCH] [Updated] mupen64plus: update to 2.5.9
  2021-03-23  3:07 [PR PATCH] mupen64plus: update to 2.5.9 zlice
                   ` (2 preceding siblings ...)
  2021-03-23  3:25 ` zlice
@ 2021-03-23  3:27 ` zlice
  2021-03-24  3:23 ` [PR REVIEW] " ericonr
                   ` (5 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: zlice @ 2021-03-23  3:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1033 bytes --]

There is an updated pull request by zlice against master on the void-packages repository

https://github.com/zlice/void-packages mupen64plus-update-to-2.5.9
https://github.com/void-linux/void-packages/pull/29692

mupen64plus: update to 2.5.9
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86-64, libc)

#### Comments
2.5 was wobbling walls and textures in Mario64
Not sure if `nopie` is an issue, first time I've had to add that.

2.5 was from 2015, 2.5.9 is from 2019

edit:
updated linting
no clue on gpl spdx specifics

A patch file from https://github.com/void-linux/void-packages/pull/29692.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mupen64plus-update-to-2.5.9-29692.patch --]
[-- Type: text/x-diff, Size: 1502 bytes --]

From 4665ee5de4dbce1db79ab0fcb8989cb0499a10f5 Mon Sep 17 00:00:00 2001
From: Corey Thomas <cthomas@oisf.net>
Date: Mon, 22 Mar 2021 23:02:10 -0400
Subject: [PATCH] mupen64plus: update to 2.5.9

---
 srcpkgs/mupen64plus/template | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/mupen64plus/template b/srcpkgs/mupen64plus/template
index 0323d321803c..7002b7f0e2f9 100644
--- a/srcpkgs/mupen64plus/template
+++ b/srcpkgs/mupen64plus/template
@@ -1,18 +1,19 @@
 # Template file for 'mupen64plus'
 pkgname=mupen64plus
-version=2.5
-revision=13
+version=2.5.9
+revision=1
+archs="i686* x86_64*"
 wrksrc="mupen64plus-bundle-src-${version}"
 hostmakedepends="pkg-config which"
-makedepends="boost-devel SDL2-devel speexdsp-devel freetype-devel glu-devel libpng-devel libsamplerate-devel"
+makedepends="boost-devel SDL2-devel speexdsp-devel freetype-devel glu-devel libpng-devel libsamplerate-devel nasm"
 depends="desktop-file-utils"
-short_desc="A Nintendo64 Emulator"
+short_desc="Nintendo64 Emulator"
 maintainer="Orphaned <orphan@voidlinux.org>"
-license="GPL-2"
+license="GPL-2.0-only"
 homepage="http://www.mupen64plus.org"
 distfiles="https://github.com/mupen64plus/mupen64plus-core/releases/download/${version}/${pkgname}-bundle-src-${version}.tar.gz"
-checksum=9c75b9d826f2d24666175f723a97369b3a6ee159b307f7cc876bbb4facdbba66
-archs="i686* x86_64*"
+checksum=d5243ddc00388ee2e538b3826a78a719dec2bd5da54ac6f3344fed861fb141a8
+nopie=yes
 
 CFLAGS="-fcommon"
 

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR REVIEW] mupen64plus: update to 2.5.9
  2021-03-23  3:07 [PR PATCH] mupen64plus: update to 2.5.9 zlice
                   ` (3 preceding siblings ...)
  2021-03-23  3:27 ` zlice
@ 2021-03-24  3:23 ` ericonr
  2021-03-24 12:25 ` [PR PATCH] [Updated] " zlice
                   ` (4 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2021-03-24  3:23 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 184 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29692#discussion_r600132917

Comment:
You want `nasm` in `hostmakedepends`.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR PATCH] [Updated] mupen64plus: update to 2.5.9
  2021-03-23  3:07 [PR PATCH] mupen64plus: update to 2.5.9 zlice
                   ` (4 preceding siblings ...)
  2021-03-24  3:23 ` [PR REVIEW] " ericonr
@ 2021-03-24 12:25 ` zlice
  2021-03-24 15:27 ` ericonr
                   ` (3 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: zlice @ 2021-03-24 12:25 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1033 bytes --]

There is an updated pull request by zlice against master on the void-packages repository

https://github.com/zlice/void-packages mupen64plus-update-to-2.5.9
https://github.com/void-linux/void-packages/pull/29692

mupen64plus: update to 2.5.9
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86-64, libc)

#### Comments
2.5 was wobbling walls and textures in Mario64
Not sure if `nopie` is an issue, first time I've had to add that.

2.5 was from 2015, 2.5.9 is from 2019

edit:
updated linting
no clue on gpl spdx specifics

A patch file from https://github.com/void-linux/void-packages/pull/29692.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mupen64plus-update-to-2.5.9-29692.patch --]
[-- Type: text/x-diff, Size: 1427 bytes --]

From 3d8e12702d91099c9ec754f52f611ddb8f44c674 Mon Sep 17 00:00:00 2001
From: Corey Thomas <cthomas@oisf.net>
Date: Mon, 22 Mar 2021 23:02:10 -0400
Subject: [PATCH] mupen64plus: update to 2.5.9

---
 srcpkgs/mupen64plus/template | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/mupen64plus/template b/srcpkgs/mupen64plus/template
index 0323d321803c..5816f59058d7 100644
--- a/srcpkgs/mupen64plus/template
+++ b/srcpkgs/mupen64plus/template
@@ -1,18 +1,19 @@
 # Template file for 'mupen64plus'
 pkgname=mupen64plus
-version=2.5
-revision=13
+version=2.5.9
+revision=1
+archs="i686* x86_64*"
 wrksrc="mupen64plus-bundle-src-${version}"
-hostmakedepends="pkg-config which"
+hostmakedepends="pkg-config which nasm"
 makedepends="boost-devel SDL2-devel speexdsp-devel freetype-devel glu-devel libpng-devel libsamplerate-devel"
 depends="desktop-file-utils"
-short_desc="A Nintendo64 Emulator"
+short_desc="Nintendo64 Emulator"
 maintainer="Orphaned <orphan@voidlinux.org>"
-license="GPL-2"
+license="GPL-2.0-only"
 homepage="http://www.mupen64plus.org"
 distfiles="https://github.com/mupen64plus/mupen64plus-core/releases/download/${version}/${pkgname}-bundle-src-${version}.tar.gz"
-checksum=9c75b9d826f2d24666175f723a97369b3a6ee159b307f7cc876bbb4facdbba66
-archs="i686* x86_64*"
+checksum=d5243ddc00388ee2e538b3826a78a719dec2bd5da54ac6f3344fed861fb141a8
+nopie=yes
 
 CFLAGS="-fcommon"
 

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: mupen64plus: update to 2.5.9
  2021-03-23  3:07 [PR PATCH] mupen64plus: update to 2.5.9 zlice
                   ` (5 preceding siblings ...)
  2021-03-24 12:25 ` [PR PATCH] [Updated] " zlice
@ 2021-03-24 15:27 ` ericonr
  2021-03-24 15:28 ` [PR REVIEW] " ericonr
                   ` (2 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2021-03-24 15:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 217 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29692#issuecomment-805921524

Comment:
This is still a pre-release, interestingly. Even Arch is still using 2.5 :o 

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR REVIEW] mupen64plus: update to 2.5.9
  2021-03-23  3:07 [PR PATCH] mupen64plus: update to 2.5.9 zlice
                   ` (6 preceding siblings ...)
  2021-03-24 15:27 ` ericonr
@ 2021-03-24 15:28 ` ericonr
  2021-03-24 15:34 ` [PR PATCH] [Updated] " zlice
  2021-04-04 23:26 ` [PR PATCH] [Closed]: " ericonr
  9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2021-03-24 15:28 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 237 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29692#discussion_r600592630

Comment:
Please use `nocross=yes` instead of `archs=...`, I can look into fixing it properly later.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR PATCH] [Updated] mupen64plus: update to 2.5.9
  2021-03-23  3:07 [PR PATCH] mupen64plus: update to 2.5.9 zlice
                   ` (7 preceding siblings ...)
  2021-03-24 15:28 ` [PR REVIEW] " ericonr
@ 2021-03-24 15:34 ` zlice
  2021-04-04 23:26 ` [PR PATCH] [Closed]: " ericonr
  9 siblings, 0 replies; 11+ messages in thread
From: zlice @ 2021-03-24 15:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1033 bytes --]

There is an updated pull request by zlice against master on the void-packages repository

https://github.com/zlice/void-packages mupen64plus-update-to-2.5.9
https://github.com/void-linux/void-packages/pull/29692

mupen64plus: update to 2.5.9
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86-64, libc)

#### Comments
2.5 was wobbling walls and textures in Mario64
Not sure if `nopie` is an issue, first time I've had to add that.

2.5 was from 2015, 2.5.9 is from 2019

edit:
updated linting
no clue on gpl spdx specifics

A patch file from https://github.com/void-linux/void-packages/pull/29692.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mupen64plus-update-to-2.5.9-29692.patch --]
[-- Type: text/x-diff, Size: 1419 bytes --]

From 6f0061cdd5fb0303bce0c148d2ab8806d21e6f35 Mon Sep 17 00:00:00 2001
From: Corey Thomas <cthomas@oisf.net>
Date: Mon, 22 Mar 2021 23:02:10 -0400
Subject: [PATCH] mupen64plus: update to 2.5.9

---
 srcpkgs/mupen64plus/template | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/mupen64plus/template b/srcpkgs/mupen64plus/template
index 0323d321803c..f0e6fe2c4173 100644
--- a/srcpkgs/mupen64plus/template
+++ b/srcpkgs/mupen64plus/template
@@ -1,18 +1,19 @@
 # Template file for 'mupen64plus'
 pkgname=mupen64plus
-version=2.5
-revision=13
+version=2.5.9
+revision=1
+nocross="yes"
 wrksrc="mupen64plus-bundle-src-${version}"
-hostmakedepends="pkg-config which"
+hostmakedepends="pkg-config which nasm"
 makedepends="boost-devel SDL2-devel speexdsp-devel freetype-devel glu-devel libpng-devel libsamplerate-devel"
 depends="desktop-file-utils"
-short_desc="A Nintendo64 Emulator"
+short_desc="Nintendo64 Emulator"
 maintainer="Orphaned <orphan@voidlinux.org>"
-license="GPL-2"
+license="GPL-2.0-only"
 homepage="http://www.mupen64plus.org"
 distfiles="https://github.com/mupen64plus/mupen64plus-core/releases/download/${version}/${pkgname}-bundle-src-${version}.tar.gz"
-checksum=9c75b9d826f2d24666175f723a97369b3a6ee159b307f7cc876bbb4facdbba66
-archs="i686* x86_64*"
+checksum=d5243ddc00388ee2e538b3826a78a719dec2bd5da54ac6f3344fed861fb141a8
+nopie=yes
 
 CFLAGS="-fcommon"
 

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR PATCH] [Closed]: mupen64plus: update to 2.5.9
  2021-03-23  3:07 [PR PATCH] mupen64plus: update to 2.5.9 zlice
                   ` (8 preceding siblings ...)
  2021-03-24 15:34 ` [PR PATCH] [Updated] " zlice
@ 2021-04-04 23:26 ` ericonr
  9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2021-04-04 23:26 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 861 bytes --]

There's a closed pull request on the void-packages repository

mupen64plus: update to 2.5.9
https://github.com/void-linux/void-packages/pull/29692

Description:
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86-64, libc)

#### Comments
2.5 was wobbling walls and textures in Mario64
Not sure if `nopie` is an issue, first time I've had to add that.

2.5 was from 2015, 2.5.9 is from 2019

edit:
updated linting
no clue on gpl spdx specifics

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2021-04-04 23:26 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-23  3:07 [PR PATCH] mupen64plus: update to 2.5.9 zlice
2021-03-23  3:21 ` [PR PATCH] [Updated] " zlice
2021-03-23  3:24 ` zlice
2021-03-23  3:25 ` zlice
2021-03-23  3:27 ` zlice
2021-03-24  3:23 ` [PR REVIEW] " ericonr
2021-03-24 12:25 ` [PR PATCH] [Updated] " zlice
2021-03-24 15:27 ` ericonr
2021-03-24 15:28 ` [PR REVIEW] " ericonr
2021-03-24 15:34 ` [PR PATCH] [Updated] " zlice
2021-04-04 23:26 ` [PR PATCH] [Closed]: " ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).