From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] libmypaint: update to 1.6.1
Date: Mon, 05 Apr 2021 14:50:41 +0200 [thread overview]
Message-ID: <20210405125041.YWQXOFqkF1J9v4yVTuS4_f6r---Mdnwr8oyRM7WC93w@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-29972@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 449 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/29972#discussion_r607071154
Comment:
Ok, these are *new* files. At least they don't seem to exist in the current version of the package.
In that case, it should be made a build option and `build_options_default="gir"` should only be set for the native build. This way, it's clear that the cross builds are lacking introspection support.
next prev parent reply other threads:[~2021-04-05 12:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-03 10:19 [PR PATCH] " biopsin
2021-04-03 12:02 ` biopsin
2021-04-03 13:17 ` ericonr
2021-04-05 5:04 ` [PR PATCH] [Updated] " biopsin
2021-04-05 5:15 ` biopsin
2021-04-05 5:43 ` [PR PATCH] [Updated] " biopsin
2021-04-05 12:50 ` ericonr [this message]
2021-04-05 12:52 ` [PR REVIEW] " ericonr
2021-04-05 13:27 ` biopsin
2021-04-05 13:30 ` ericonr
2021-04-05 17:32 ` [PR PATCH] [Updated] " biopsin
2021-04-06 12:51 ` ericonr
2021-04-06 12:52 ` ericonr
2021-04-06 12:59 ` [PR PATCH] [Merged]: " ericonr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210405125041.YWQXOFqkF1J9v4yVTuS4_f6r---Mdnwr8oyRM7WC93w@z \
--to=ericonr@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).