From: Chocimier <Chocimier@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package: pnpm-5.8.0
Date: Tue, 06 Apr 2021 20:30:14 +0200 [thread overview]
Message-ID: <20210406183014.NbsEXIT7-2ARihGOevSXocLdXFXOmzn6Gxr46CxMEag@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-25315@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 262 bytes --]
New review comment by Chocimier on void-packages repository
https://github.com/void-linux/void-packages/pull/25315#discussion_r608078254
Comment:
This isn't accurate, wrksrc is used as cwd of do_install, even if archive isn't extracted, please remove comment.
next prev parent reply other threads:[~2021-04-06 18:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-03 15:45 [PR PATCH] " reback00
2021-04-05 0:56 ` kwshi
2021-04-05 1:19 ` [PR REVIEW] " ericonr
2021-04-06 18:30 ` Chocimier [this message]
2021-04-06 18:30 ` Chocimier
2021-04-06 18:30 ` Chocimier
2021-04-11 17:27 ` [PR PATCH] [Updated] " reback00
2021-04-11 17:43 ` [PR REVIEW] New package: pnpm-6.0.1 reback00
2021-04-11 17:43 ` reback00
2021-04-11 17:44 ` reback00
2021-04-11 17:47 ` reback00
2021-04-11 17:49 ` reback00
2021-04-12 4:44 ` [PR PATCH] [Updated] " reback00
2021-04-12 4:48 ` [PR REVIEW] " reback00
2021-04-12 17:05 ` [PR PATCH] [Merged]: " Chocimier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210406183014.NbsEXIT7-2ARihGOevSXocLdXFXOmzn6Gxr46CxMEag@z \
--to=chocimier@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).