Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] fzf: update to 0.27.0
@ 2021-04-06 16:51 FollieHiyuki
  2021-04-06 17:21 ` ericonr
                   ` (9 more replies)
  0 siblings, 10 replies; 11+ messages in thread
From: FollieHiyuki @ 2021-04-06 16:51 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1656 bytes --]

There is a new pull request by FollieHiyuki against master on the void-packages repository

https://github.com/FollieHiyuki/void-packages fzf-update
https://github.com/void-linux/void-packages/pull/30050

fzf: update to 0.27.0
Add fzf-tmux man page and more vim doc.
Change the installed files to a new location

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/30050.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fzf-update-30050.patch --]
[-- Type: text/x-diff, Size: 2035 bytes --]

From 0fb47c855d01b5494597ed9b74ab7ed38b42da63 Mon Sep 17 00:00:00 2001
From: FollieHiyuki <folliekazetani@protonmail.com>
Date: Tue, 6 Apr 2021 19:49:47 +0300
Subject: [PATCH] fzf: update to 0.27.0

Add fzf-tmux man page and more vim doc.
Change the installed files to a new location
---
 srcpkgs/fzf/template | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

diff --git a/srcpkgs/fzf/template b/srcpkgs/fzf/template
index a3c30e7a3895..472a759dfd3d 100644
--- a/srcpkgs/fzf/template
+++ b/srcpkgs/fzf/template
@@ -1,6 +1,6 @@
 # Template file for 'fzf'
 pkgname=fzf
-version=0.26.0
+version=0.27.0
 revision=1
 build_style=go
 go_import_path="github.com/junegunn/fzf"
@@ -12,20 +12,23 @@ license="MIT"
 homepage="https://github.com/junegunn/fzf"
 changelog="https://raw.githubusercontent.com/junegunn/fzf/master/CHANGELOG.md"
 distfiles="https://github.com/junegunn/fzf/archive/${version}.tar.gz"
-checksum=a8dc01f16b3bf453fdc9e9a2cd0ca39db7a1b44386517bb7859805b053aa7810
+checksum=265c569f3b0c3c210b45831b80d4fba260c5956f3ebf88d2c5c8f9f6d759e388
 
 post_install() {
 	cd ${wrksrc}
 	vbin bin/fzf-tmux
 	vman man/man1/fzf.1
+	vman man/man1/fzf-tmux.1
 	vlicense LICENSE
 
-	sed -i -e 's#source ~/\.fzf\.bash; ##' shell/key-bindings.bash
 	vinstall plugin/fzf.vim 644 usr/share/vim/vimfiles/plugin
 	vinstall plugin/fzf.vim 644 usr/share/nvim/runtime/plugin
-	vinstall shell/completion.bash 644 usr/share/doc/fzf
-	vinstall shell/completion.zsh 644 usr/share/doc/fzf
-	vinstall shell/key-bindings.zsh 644 usr/share/doc/fzf
-	vinstall shell/key-bindings.bash 644 usr/share/doc/fzf
-	vinstall shell/key-bindings.fish 644 usr/share/doc/fzf
+	vinstall doc/fzf.txt 644 usr/share/vim/vimfiles/doc
+	vinstall doc/fzf.txt 644 usr/share/nvim/runtime/doc
+
+	vinstall shell/completion.bash 644 usr/share/fzf
+	vinstall shell/completion.zsh 644 usr/share/fzf
+	vinstall shell/key-bindings.zsh 644 usr/share/fzf
+	vinstall shell/key-bindings.bash 644 usr/share/fzf
+	vinstall shell/key-bindings.fish 644 usr/share/fzf
 }

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: fzf: update to 0.27.0
  2021-04-06 16:51 [PR PATCH] fzf: update to 0.27.0 FollieHiyuki
@ 2021-04-06 17:21 ` ericonr
  2021-04-06 17:23 ` FollieHiyuki
                   ` (8 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2021-04-06 17:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 261 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/30050#issuecomment-814293847

Comment:
Is changing the install location worth it? Someone symlink from that location will have broken symlinks after an update.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: fzf: update to 0.27.0
  2021-04-06 16:51 [PR PATCH] fzf: update to 0.27.0 FollieHiyuki
  2021-04-06 17:21 ` ericonr
@ 2021-04-06 17:23 ` FollieHiyuki
  2021-04-07 14:28 ` [PR PATCH] [Updated] " FollieHiyuki
                   ` (7 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: FollieHiyuki @ 2021-04-06 17:23 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 303 bytes --]

New comment by FollieHiyuki on void-packages repository

https://github.com/void-linux/void-packages/pull/30050#issuecomment-814295753

Comment:
Not really :) I just feel like we should not put random things inside `/usr/share/doc`.
If symlink problem is concerned we can have a INSTALL.msg. Probably?

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR PATCH] [Updated] fzf: update to 0.27.0
  2021-04-06 16:51 [PR PATCH] fzf: update to 0.27.0 FollieHiyuki
  2021-04-06 17:21 ` ericonr
  2021-04-06 17:23 ` FollieHiyuki
@ 2021-04-07 14:28 ` FollieHiyuki
  2021-04-09  9:22 ` [PR PATCH] [Updated] fzf: clean post_install() FollieHiyuki
                   ` (6 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: FollieHiyuki @ 2021-04-07 14:28 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1661 bytes --]

There is an updated pull request by FollieHiyuki against master on the void-packages repository

https://github.com/FollieHiyuki/void-packages fzf-update
https://github.com/void-linux/void-packages/pull/30050

fzf: update to 0.27.0
Add fzf-tmux man page and more vim doc.
Change the installed files to a new location

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/30050.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fzf-update-30050.patch --]
[-- Type: text/x-diff, Size: 1693 bytes --]

From da2f973e77be09b1eec084d9d6a0de84e6703694 Mon Sep 17 00:00:00 2001
From: FollieHiyuki <folliekazetani@protonmail.com>
Date: Tue, 6 Apr 2021 19:49:47 +0300
Subject: [PATCH] fzf: clean up post_install()

Add fzf-tmux man page and vim doc.
Change the installed files to a new location.
---
 srcpkgs/fzf/template | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/fzf/template b/srcpkgs/fzf/template
index cbd5d39dd152..be870c513465 100644
--- a/srcpkgs/fzf/template
+++ b/srcpkgs/fzf/template
@@ -1,7 +1,7 @@
 # Template file for 'fzf'
 pkgname=fzf
 version=0.27.0
-revision=1
+revision=2
 build_style=go
 go_import_path="github.com/junegunn/fzf"
 hostmakedepends="git"
@@ -18,14 +18,17 @@ post_install() {
 	cd ${wrksrc}
 	vbin bin/fzf-tmux
 	vman man/man1/fzf.1
+	vman man/man1/fzf-tmux.1
 	vlicense LICENSE
 
-	sed -i -e 's#source ~/\.fzf\.bash; ##' shell/key-bindings.bash
 	vinstall plugin/fzf.vim 644 usr/share/vim/vimfiles/plugin
 	vinstall plugin/fzf.vim 644 usr/share/nvim/runtime/plugin
-	vinstall shell/completion.bash 644 usr/share/doc/fzf
-	vinstall shell/completion.zsh 644 usr/share/doc/fzf
-	vinstall shell/key-bindings.zsh 644 usr/share/doc/fzf
-	vinstall shell/key-bindings.bash 644 usr/share/doc/fzf
-	vinstall shell/key-bindings.fish 644 usr/share/doc/fzf
+	vinstall doc/fzf.txt 644 usr/share/vim/vimfiles/doc
+	vinstall doc/fzf.txt 644 usr/share/nvim/runtime/doc
+
+	vinstall shell/completion.bash 644 usr/share/fzf
+	vinstall shell/completion.zsh 644 usr/share/fzf
+	vinstall shell/key-bindings.zsh 644 usr/share/fzf
+	vinstall shell/key-bindings.bash 644 usr/share/fzf
+	vinstall shell/key-bindings.fish 644 usr/share/fzf
 }

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR PATCH] [Updated] fzf: clean post_install()
  2021-04-06 16:51 [PR PATCH] fzf: update to 0.27.0 FollieHiyuki
                   ` (2 preceding siblings ...)
  2021-04-07 14:28 ` [PR PATCH] [Updated] " FollieHiyuki
@ 2021-04-09  9:22 ` FollieHiyuki
  2021-04-17 12:00 ` [PR REVIEW] " TeddyDD
                   ` (5 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: FollieHiyuki @ 2021-04-09  9:22 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1665 bytes --]

There is an updated pull request by FollieHiyuki against master on the void-packages repository

https://github.com/FollieHiyuki/void-packages fzf-update
https://github.com/void-linux/void-packages/pull/30050

fzf: clean post_install()
Add fzf-tmux man page and more vim doc.
Change the installed files to a new location

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/30050.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fzf-update-30050.patch --]
[-- Type: text/x-diff, Size: 2107 bytes --]

From e98ea86c039bfe830676f0cb9d8a4a967e4de169 Mon Sep 17 00:00:00 2001
From: FollieHiyuki <folliekazetani@protonmail.com>
Date: Tue, 6 Apr 2021 19:49:47 +0300
Subject: [PATCH] fzf: clean up post_install()

Add fzf-tmux man page and vim doc.
Change the installed shell files to a new location.
---
 srcpkgs/fzf/INSTALL.msg |  2 ++
 srcpkgs/fzf/template    | 17 ++++++++++-------
 2 files changed, 12 insertions(+), 7 deletions(-)
 create mode 100644 srcpkgs/fzf/INSTALL.msg

diff --git a/srcpkgs/fzf/INSTALL.msg b/srcpkgs/fzf/INSTALL.msg
new file mode 100644
index 000000000000..0ef00d85f86d
--- /dev/null
+++ b/srcpkgs/fzf/INSTALL.msg
@@ -0,0 +1,2 @@
+The shell functions, key bindings of fzf are now moved to /usr/share/fzf/.
+If you have symlinks to the old location please change them accordingly.
diff --git a/srcpkgs/fzf/template b/srcpkgs/fzf/template
index cbd5d39dd152..be870c513465 100644
--- a/srcpkgs/fzf/template
+++ b/srcpkgs/fzf/template
@@ -1,7 +1,7 @@
 # Template file for 'fzf'
 pkgname=fzf
 version=0.27.0
-revision=1
+revision=2
 build_style=go
 go_import_path="github.com/junegunn/fzf"
 hostmakedepends="git"
@@ -18,14 +18,17 @@ post_install() {
 	cd ${wrksrc}
 	vbin bin/fzf-tmux
 	vman man/man1/fzf.1
+	vman man/man1/fzf-tmux.1
 	vlicense LICENSE
 
-	sed -i -e 's#source ~/\.fzf\.bash; ##' shell/key-bindings.bash
 	vinstall plugin/fzf.vim 644 usr/share/vim/vimfiles/plugin
 	vinstall plugin/fzf.vim 644 usr/share/nvim/runtime/plugin
-	vinstall shell/completion.bash 644 usr/share/doc/fzf
-	vinstall shell/completion.zsh 644 usr/share/doc/fzf
-	vinstall shell/key-bindings.zsh 644 usr/share/doc/fzf
-	vinstall shell/key-bindings.bash 644 usr/share/doc/fzf
-	vinstall shell/key-bindings.fish 644 usr/share/doc/fzf
+	vinstall doc/fzf.txt 644 usr/share/vim/vimfiles/doc
+	vinstall doc/fzf.txt 644 usr/share/nvim/runtime/doc
+
+	vinstall shell/completion.bash 644 usr/share/fzf
+	vinstall shell/completion.zsh 644 usr/share/fzf
+	vinstall shell/key-bindings.zsh 644 usr/share/fzf
+	vinstall shell/key-bindings.bash 644 usr/share/fzf
+	vinstall shell/key-bindings.fish 644 usr/share/fzf
 }

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR REVIEW] fzf: clean post_install()
  2021-04-06 16:51 [PR PATCH] fzf: update to 0.27.0 FollieHiyuki
                   ` (3 preceding siblings ...)
  2021-04-09  9:22 ` [PR PATCH] [Updated] fzf: clean post_install() FollieHiyuki
@ 2021-04-17 12:00 ` TeddyDD
  2021-04-17 12:00 ` TeddyDD
                   ` (4 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: TeddyDD @ 2021-04-17 12:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 154 bytes --]

New review comment by TeddyDD on void-packages repository

https://github.com/void-linux/void-packages/pull/30050#discussion_r615246771

Comment:
vsconf?

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR REVIEW] fzf: clean post_install()
  2021-04-06 16:51 [PR PATCH] fzf: update to 0.27.0 FollieHiyuki
                   ` (5 preceding siblings ...)
  2021-04-17 12:00 ` TeddyDD
@ 2021-04-17 12:00 ` TeddyDD
  2021-04-17 15:34 ` FollieHiyuki
                   ` (2 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: TeddyDD @ 2021-04-17 12:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 209 bytes --]

New review comment by TeddyDD on void-packages repository

https://github.com/void-linux/void-packages/pull/30050#discussion_r615246564

Comment:
This should be probably installed with vcompletion :thinking: 

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR REVIEW] fzf: clean post_install()
  2021-04-06 16:51 [PR PATCH] fzf: update to 0.27.0 FollieHiyuki
                   ` (4 preceding siblings ...)
  2021-04-17 12:00 ` [PR REVIEW] " TeddyDD
@ 2021-04-17 12:00 ` TeddyDD
  2021-04-17 12:00 ` TeddyDD
                   ` (3 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: TeddyDD @ 2021-04-17 12:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 152 bytes --]

New review comment by TeddyDD on void-packages repository

https://github.com/void-linux/void-packages/pull/30050#discussion_r615246752

Comment:
vdoc?

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR REVIEW] fzf: clean post_install()
  2021-04-06 16:51 [PR PATCH] fzf: update to 0.27.0 FollieHiyuki
                   ` (6 preceding siblings ...)
  2021-04-17 12:00 ` TeddyDD
@ 2021-04-17 15:34 ` FollieHiyuki
  2021-04-17 15:35 ` FollieHiyuki
  2021-04-17 15:40 ` FollieHiyuki
  9 siblings, 0 replies; 11+ messages in thread
From: FollieHiyuki @ 2021-04-17 15:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 281 bytes --]

New review comment by FollieHiyuki on void-packages repository

https://github.com/void-linux/void-packages/pull/30050#discussion_r615268551

Comment:
I use ** quite a lot and i find it annoying whenever I accidentally trigger its completion of `fzf`.
So yeah should be optional.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR REVIEW] fzf: clean post_install()
  2021-04-06 16:51 [PR PATCH] fzf: update to 0.27.0 FollieHiyuki
                   ` (7 preceding siblings ...)
  2021-04-17 15:34 ` FollieHiyuki
@ 2021-04-17 15:35 ` FollieHiyuki
  2021-04-17 15:40 ` FollieHiyuki
  9 siblings, 0 replies; 11+ messages in thread
From: FollieHiyuki @ 2021-04-17 15:35 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 208 bytes --]

New review comment by FollieHiyuki on void-packages repository

https://github.com/void-linux/void-packages/pull/30050#discussion_r615268700

Comment:
This is vim plugin doc for `fzf.vim`. It has to be there

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR REVIEW] fzf: clean post_install()
  2021-04-06 16:51 [PR PATCH] fzf: update to 0.27.0 FollieHiyuki
                   ` (8 preceding siblings ...)
  2021-04-17 15:35 ` FollieHiyuki
@ 2021-04-17 15:40 ` FollieHiyuki
  9 siblings, 0 replies; 11+ messages in thread
From: FollieHiyuki @ 2021-04-17 15:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 230 bytes --]

New review comment by FollieHiyuki on void-packages repository

https://github.com/void-linux/void-packages/pull/30050#discussion_r615269249

Comment:
That is an option. But these files don't feel like configuration for me though

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2021-04-17 15:40 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-06 16:51 [PR PATCH] fzf: update to 0.27.0 FollieHiyuki
2021-04-06 17:21 ` ericonr
2021-04-06 17:23 ` FollieHiyuki
2021-04-07 14:28 ` [PR PATCH] [Updated] " FollieHiyuki
2021-04-09  9:22 ` [PR PATCH] [Updated] fzf: clean post_install() FollieHiyuki
2021-04-17 12:00 ` [PR REVIEW] " TeddyDD
2021-04-17 12:00 ` TeddyDD
2021-04-17 12:00 ` TeddyDD
2021-04-17 15:34 ` FollieHiyuki
2021-04-17 15:35 ` FollieHiyuki
2021-04-17 15:40 ` FollieHiyuki

Github messages for voidlinux

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.vuxu.org/voidlinux-github

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 voidlinux-github voidlinux-github/ http://inbox.vuxu.org/voidlinux-github \
		voidlinux-github@inbox.vuxu.org
	public-inbox-index voidlinux-github

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.github.voidlinux


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git