Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] docker-cli: fix completion file name
@ 2021-04-07 11:18 FollieHiyuki
  2021-04-07 11:22 ` [PR PATCH] [Updated] " FollieHiyuki
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: FollieHiyuki @ 2021-04-07 11:18 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1606 bytes --]

There is a new pull request by FollieHiyuki against master on the void-packages repository

https://github.com/FollieHiyuki/void-packages docker-completion
https://github.com/void-linux/void-packages/pull/30064

docker-cli: fix completion file name
Fixes #30056

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/30064.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-docker-completion-30064.patch --]
[-- Type: text/x-diff, Size: 909 bytes --]

From ae1ee37b5004a6fce6bf5ffe8e72c66c71a61cc0 Mon Sep 17 00:00:00 2001
From: FollieHiyuki <folliekazetani@protonmail.com>
Date: Wed, 7 Apr 2021 14:16:43 +0300
Subject: [PATCH] docker-cli: fix completion file name

Fixes #30056
---
 srcpkgs/docker-cli/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/docker-cli/template b/srcpkgs/docker-cli/template
index 88db6440de5e..aab98fc4587b 100644
--- a/srcpkgs/docker-cli/template
+++ b/srcpkgs/docker-cli/template
@@ -24,9 +24,9 @@ pre_build() {
 }
 
 post_install() {
-	vcompletion contrib/completion/fish/docker.fish fish
-	vcompletion contrib/completion/zsh/_docker zsh
-	vcompletion contrib/completion/bash/docker bash
+	vcompletion contrib/completion/fish/docker.fish fish docker
+	vcompletion contrib/completion/zsh/_docker zsh docker
+	vcompletion contrib/completion/bash/docker bash docker
 }
 
 docker_package() {

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PR PATCH] [Updated] docker-cli: fix completion file name
  2021-04-07 11:18 [PR PATCH] docker-cli: fix completion file name FollieHiyuki
@ 2021-04-07 11:22 ` FollieHiyuki
  2021-04-07 18:07 ` ericonr
  2021-04-07 18:08 ` [PR PATCH] [Merged]: " ericonr
  2 siblings, 0 replies; 4+ messages in thread
From: FollieHiyuki @ 2021-04-07 11:22 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1611 bytes --]

There is an updated pull request by FollieHiyuki against master on the void-packages repository

https://github.com/FollieHiyuki/void-packages docker-completion
https://github.com/void-linux/void-packages/pull/30064

docker-cli: fix completion file name
Fixes #30056

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/30064.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-docker-completion-30064.patch --]
[-- Type: text/x-diff, Size: 909 bytes --]

From ae1ee37b5004a6fce6bf5ffe8e72c66c71a61cc0 Mon Sep 17 00:00:00 2001
From: FollieHiyuki <folliekazetani@protonmail.com>
Date: Wed, 7 Apr 2021 14:16:43 +0300
Subject: [PATCH] docker-cli: fix completion file name

Fixes #30056
---
 srcpkgs/docker-cli/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/docker-cli/template b/srcpkgs/docker-cli/template
index 88db6440de5e..aab98fc4587b 100644
--- a/srcpkgs/docker-cli/template
+++ b/srcpkgs/docker-cli/template
@@ -24,9 +24,9 @@ pre_build() {
 }
 
 post_install() {
-	vcompletion contrib/completion/fish/docker.fish fish
-	vcompletion contrib/completion/zsh/_docker zsh
-	vcompletion contrib/completion/bash/docker bash
+	vcompletion contrib/completion/fish/docker.fish fish docker
+	vcompletion contrib/completion/zsh/_docker zsh docker
+	vcompletion contrib/completion/bash/docker bash docker
 }
 
 docker_package() {

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: docker-cli: fix completion file name
  2021-04-07 11:18 [PR PATCH] docker-cli: fix completion file name FollieHiyuki
  2021-04-07 11:22 ` [PR PATCH] [Updated] " FollieHiyuki
@ 2021-04-07 18:07 ` ericonr
  2021-04-07 18:08 ` [PR PATCH] [Merged]: " ericonr
  2 siblings, 0 replies; 4+ messages in thread
From: ericonr @ 2021-04-07 18:07 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 159 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/30064#issuecomment-815117016

Comment:
Nice find, thanks!

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PR PATCH] [Merged]: docker-cli: fix completion file name
  2021-04-07 11:18 [PR PATCH] docker-cli: fix completion file name FollieHiyuki
  2021-04-07 11:22 ` [PR PATCH] [Updated] " FollieHiyuki
  2021-04-07 18:07 ` ericonr
@ 2021-04-07 18:08 ` ericonr
  2 siblings, 0 replies; 4+ messages in thread
From: ericonr @ 2021-04-07 18:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1435 bytes --]

There's a merged pull request on the void-packages repository

docker-cli: fix completion file name
https://github.com/void-linux/void-packages/pull/30064

Description:
Fixes #30056

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-04-07 18:08 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-07 11:18 [PR PATCH] docker-cli: fix completion file name FollieHiyuki
2021-04-07 11:22 ` [PR PATCH] [Updated] " FollieHiyuki
2021-04-07 18:07 ` ericonr
2021-04-07 18:08 ` [PR PATCH] [Merged]: " ericonr

Github messages for voidlinux

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.vuxu.org/voidlinux-github

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 voidlinux-github voidlinux-github/ http://inbox.vuxu.org/voidlinux-github \
		voidlinux-github@inbox.vuxu.org
	public-inbox-index voidlinux-github

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.github.voidlinux


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git