Github messages for voidlinux
 help / color / mirror / Atom feed
From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] Manual: add 80 column line break suggestion.
Date: Wed, 07 Apr 2021 21:53:46 +0200	[thread overview]
Message-ID: <20210407195346.rq6FyqueniHp8BaAFEd7Ut41l0EyRqIxSA0ruW_17aY@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-29897@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 2300 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29897#discussion_r609021872

Comment:
I can't find `xupdate`...

This would mean that the following packages are "incorrect", and we'd have to agree that they are better off with raw `version` fields:

```
srcpkgs/EmptyEpsilon/template:version="${_ver_major}.${_ver_minor}.${_ver_patch}"
srcpkgs/ImageMagick/template:version="${_majorver}.${_patchver}"
srcpkgs/ImageMagick6/template:version="${_majorver}.${_patchver}"
srcpkgs/cross-x86_64-w64-mingw32/template:version=$_mingw_version
srcpkgs/dialog/template:version="${_distver}.${_date}"
srcpkgs/dmraid/template:version="${_distver}.${_patchver}"
srcpkgs/ftgl/template:version="${_distver}${_distrcver}"
srcpkgs/gcc-multilib/template:version=${_majorver}.1pre1
srcpkgs/gcc/template:version=${_patchver}pre1
srcpkgs/gcc6/template:version=${_minorver}.0
srcpkgs/google-chrome/template:version="${_chromeVersion}.${_chromeRevision}"
srcpkgs/hfsprogs/template:version="${_distver}.linux${_patchver}"
srcpkgs/j/template:version=${_vmaj}.${_vmin}
srcpkgs/libax25/template:version="${_distver}${_patchver}"
srcpkgs/libedit/template:version="${_datever}.${_distver}"
srcpkgs/libpurple-facebook/template:version=${_version}.${_rev}
srcpkgs/libreadline8/template:version="${_dist_ver}.${_patch_ver}"
srcpkgs/libtcd/template:version=${_distver}.${_distrev}
srcpkgs/lynx/template:version="${_distver}.${_patchver}"
srcpkgs/man-pages-posix/template:version="${_distver}${_revver}"
srcpkgs/mcwm/template:version="${_distver}.${_patchver}"
srcpkgs/openjdk10-bootstrap/template:version="10.0.2p${_jdk_build}"
srcpkgs/openjdk11/template:version="${_java_ver}.${_java_min_ver}.${_java_sec_ver}+${_jdk_update}"
srcpkgs/openjdk7-bootstrap/template:version="${_java_ver}u${_jdk_update}b${_jdk_build}"
srcpkgs/openjdk8/template:version="${_java_ver}u${_jdk_update}b${_jdk_build}"
srcpkgs/openjdk9-bootstrap/template:version="9.0.4p${_jdk_build}"
srcpkgs/pcc/template:version=${_distver}.${_snapshot}
srcpkgs/python3-apsw/template:version=${_distver}${_patchver}
srcpkgs/simutron/template:version=1.0.1.${_rev}
srcpkgs/tcc/template:version=${_distver}.${_voidver}
srcpkgs/x264/template:version="${_snap_date}.${_snap_rev}"
```

  parent reply	other threads:[~2021-04-07 19:53 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-31  3:21 [PR PATCH] [WIP] " ericonr
2021-03-31 11:33 ` [PR REVIEW] " sgn
2021-03-31 16:56 ` Chocimier
2021-03-31 16:56 ` Chocimier
2021-03-31 16:56 ` Chocimier
2021-04-07 19:21 ` [PR PATCH] [Updated] " ericonr
2021-04-07 19:22 ` [PR REVIEW] " ericonr
2021-04-07 19:22 ` ericonr
2021-04-07 19:22 ` [PR PATCH] [Updated] " ericonr
2021-04-07 19:44 ` [PR REVIEW] " Chocimier
2021-04-07 19:44 ` Chocimier
2021-04-07 19:44 ` Chocimier
2021-04-07 19:53 ` ericonr [this message]
2021-04-07 19:54 ` ericonr
2021-04-07 20:23 ` [PR PATCH] [Updated] " ericonr
2021-04-07 20:34 ` ericonr
2021-04-07 20:37 ` ericonr
2021-04-07 20:37 ` [PR PATCH] [Merged]: " ericonr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210407195346.rq6FyqueniHp8BaAFEd7Ut41l0EyRqIxSA0ruW_17aY@z \
    --to=ericonr@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).