Github messages for voidlinux
 help / color / mirror / Atom feed
From: Chocimier <Chocimier@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: New packages: libadwaita-qt adwaita-qt-devel
Date: Sat, 10 Apr 2021 12:17:30 +0200	[thread overview]
Message-ID: <20210410101730.WZfcV6M1C0KokUEpkSXgVoxPpyAjtiVIERtE07uu_IY@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-30117@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1413 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/30117#issuecomment-817112889

Comment:
Dependencies are wrong, change like below. Please also rename commit to "adwaita-qt: split libadwaita-qt and adwaita-qt-devel". Otherwise ok.

``` diff
--- a/srcpkgs/adwaita-qt/template
+++ b/srcpkgs/adwaita-qt/template
@@ -5,7 +5,6 @@ revision=2
 build_style=cmake
 hostmakedepends="qt5-host-tools qt5-qmake"
 makedepends="qt5-devel qt5-x11extras-devel"
-depends="libadwaita-qt"
 short_desc="Style to bend Qt applications to look like they belong into GNOME Shell"
 maintainer="Piotr Wójcik <chocimier@tlen.pl>"
 license="GPL-2.0-or-later"
@@ -14,7 +13,6 @@ distfiles="https://github.com/FedoraQt/adwaita-qt/archive/${version}.tar.gz"
 checksum=0673586fe37469eb826be821b3f2c12f055e99a6ca0a8377cfa06b123543ae56
 
 libadwaita-qt_package() {
-       depends="${makedepends} ${sourcepkg}>=${version}_${revision}"
        short_desc+=" - shared libraries"
        pkg_install() {
                vmove "usr/lib/*.so.*"
@@ -22,7 +20,7 @@ libadwaita-qt_package() {
 }
 
 adwaita-qt-devel_package() {
-       depends="${makedepends} ${sourcepkg}>=${version}_${revision}"
+       depends="${makedepends} libadwaita-qt>=${version}_${revision}"
        short_desc+=" - development files"
        pkg_install() {
                vmove usr/include
```

  reply	other threads:[~2021-04-10 10:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-10  5:13 [PR PATCH] " phossil
2021-04-10 10:17 ` Chocimier [this message]
2021-04-10 11:35 ` paper42
2021-04-10 11:51 ` Chocimier
2021-04-10 12:34 ` paper42
2021-04-10 19:44 ` [PR PATCH] [Updated] adwaita-qt: split libadwaita-qt and adwaita-qt-devel phossil
2021-04-12 15:41 ` Chocimier
2022-05-17  2:15 ` github-actions
2022-06-01  2:14 ` [PR PATCH] [Closed]: " github-actions

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210410101730.WZfcV6M1C0KokUEpkSXgVoxPpyAjtiVIERtE07uu_IY@z \
    --to=chocimier@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).