Github messages for voidlinux
 help / color / mirror / Atom feed
From: ailiop-git <ailiop-git@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Closed]: glibc: restore debug symbols
Date: Tue, 13 Apr 2021 21:37:12 +0200	[thread overview]
Message-ID: <20210413193712.Qd3-T5SqlhEKSRnG-stMgdstvqBm9lD5i-g6-gOxfP4@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-30216@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1936 bytes --]

There's a closed pull request on the void-packages repository

glibc: restore debug symbols
https://github.com/void-linux/void-packages/pull/30216

Description:
commit b5a52cc50a13 ("glibc: do not strip shlibs to make valgrind work
ootb.") had added the main glibc shared libraries in the nostrip list so
that valgrind could work out of the box. As mentioned in that commit
message, this had the side-effect of making the glibc-dbg package lack
the debug symbols for all those libraries.

Restore all glibc debug symbol generation by removing all those shared
libraries from the nostrip list, so that symbolic debugging of glibc is
made possible.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


      parent reply	other threads:[~2021-04-13 19:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-13 18:42 [PR PATCH] " ailiop-git
2021-04-13 18:45 ` ericonr
2021-04-13 19:36 ` ailiop-git
2021-04-13 19:37 ` ailiop-git [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210413193712.Qd3-T5SqlhEKSRnG-stMgdstvqBm9lD5i-g6-gOxfP4@z \
    --to=ailiop-git@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).