From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package: ipp-usb-0.9.17
Date: Sun, 18 Apr 2021 06:30:00 +0200 [thread overview]
Message-ID: <20210418043000.AhcQaEDRzxcWBb7pJBQEp7ILY43tzSvmhHrhrPcE2iA@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-28945@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 411 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/28945#discussion_r615339641
Comment:
@oynqr please make the changes to the udev rule a patch to https://github.com/OpenPrinting/ipp-usb/blob/master/systemd-udev/71-ipp-usb.rules , so we can adapt to changes they make instead of having to remember to check.
Once that's done should be good to merge.
prev parent reply other threads:[~2021-04-18 4:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-20 22:36 [PR PATCH] " oynqr
2021-02-21 0:50 ` [PR REVIEW] " ericonr
2021-02-21 0:50 ` ericonr
2021-02-21 2:44 ` CameronNemo
2021-02-21 9:34 ` [PR PATCH] [Updated] " oynqr
2021-02-21 9:39 ` [PR REVIEW] " oynqr
2021-02-21 9:40 ` oynqr
2021-02-21 9:51 ` oynqr
2021-02-21 11:26 ` oynqr
2021-02-25 19:32 ` [PR PATCH] [Updated] " oynqr
2021-03-01 14:46 ` oynqr
2021-03-01 16:06 ` ericonr
2021-03-10 9:26 ` [PR REVIEW] " oynqr
2021-03-15 21:20 ` [PR PATCH] [Updated] " oynqr
2021-03-22 8:25 ` oynqr
2021-03-22 17:57 ` [PR REVIEW] " oynqr
2021-03-22 18:03 ` [PR PATCH] [Updated] " oynqr
2021-04-18 4:29 ` [PR REVIEW] " ericonr
2021-04-18 4:30 ` ericonr [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210418043000.AhcQaEDRzxcWBb7pJBQEp7ILY43tzSvmhHrhrPcE2iA@z \
--to=ericonr@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).