Github messages for voidlinux
 help / color / mirror / Atom feed
From: st3r4g <st3r4g@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: wlroots: update to 0.13.0.
Date: Sun, 18 Apr 2021 21:01:16 +0200	[thread overview]
Message-ID: <20210418190116.HHVWJiX1gfyPpftgno-06Ef65-D-bgNbTOAxUn89_0E@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-30076@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1676 bytes --]

New comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/30076#issuecomment-822010209

Comment:
could you add xdg-desktop-portal-wlr-0.3 here too? It has just been released.
~~Looks like it runtime depends on `slurp` now.~~ EDIT: ok maybe not:
> - default: xdpw will try to use the first chooser found in the list of hardcoded choosers
(slurp, wofi, bemenu) and will fallback to an arbitrary output if none of those were found.

That didn't quite work for me:
```
2021/04/18 18:15:24 [INFO] - wlroots: capturable output: Unknown model: 0x05DF: id: 39 name: eDP-1
2021/04/18 18:15:24 [INFO] - wlroots: capturable output: Samsung Electric Company model: S22F350: id: 40 name: HDMI-A-2
2021/04/18 18:15:24 [DEBUG] - wlroots: output chooser called
2021/04/18 18:15:24 [DEBUG] - wlroots: output chooser called
/bin/sh: 1: slurp: not found
[DEBUG] - wlroots: output chooser canceled
2021/04/18 18:15:24 [ERROR] - wlroots: no output found
```
Also, I have `bemenu` installed, so it should have selected that...
Yeah looks like something is off in the logic that finds if one command succeeded.
This seems to fix it:
```
diff --git a/src/screencast/wlr_screencast.c b/src/screencast/wlr_screencast.c
index 45bea73..a3b0637 100644
--- a/src/screencast/wlr_screencast.c
+++ b/src/screencast/wlr_screencast.c
@@ -406,7 +406,7 @@ static bool wlr_output_chooser(struct xdpw_output_chooser *chooser,
 
        if (!wait_chooser(pid)) {
                close(chooser_out[0]);
-               goto end;
+               return false;
        }
 
        FILE *f = fdopen(chooser_out[0], "r");
```
I'll tell upstream.

  parent reply	other threads:[~2021-04-18 19:01 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-07 20:02 [PR PATCH] " ifreund
2021-04-07 20:07 ` ericonr
2021-04-07 20:42 ` [PR PATCH] [Updated] " ifreund
2021-04-07 21:14 ` jbeich
2021-04-07 22:24 ` ifreund
2021-04-08  2:28 ` ericonr
2021-04-09 18:44 ` st3r4g
2021-04-10 17:56 ` [PR PATCH] [Updated] " ifreund
2021-04-18 10:18 ` ifreund
2021-04-18 10:32 ` ifreund
2021-04-18 11:01 ` ifreund
2021-04-18 15:31 ` st3r4g
2021-04-18 15:45 ` st3r4g
2021-04-18 15:48 ` st3r4g
2021-04-18 16:22 ` st3r4g
2021-04-18 16:24 ` st3r4g
2021-04-18 16:42 ` st3r4g
2021-04-18 17:47 ` st3r4g
2021-04-18 19:01 ` st3r4g [this message]
2021-04-18 22:07 ` [PR PATCH] [Updated] " ifreund
2021-04-18 22:08 ` ifreund
2021-04-18 22:11 ` st3r4g
2021-04-18 22:12 ` [PR PATCH] [Updated] " ifreund
2021-04-18 22:49 ` ifreund
2021-04-18 22:53 ` ifreund
2021-04-18 23:23 ` ifreund
2021-04-20  4:27 ` ericonr
2021-04-20  4:28 ` ericonr
2021-04-20  4:28 ` [PR PATCH] [Merged]: " ericonr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210418190116.HHVWJiX1gfyPpftgno-06Ef65-D-bgNbTOAxUn89_0E@z \
    --to=st3r4g@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).