Github messages for voidlinux
 help / color / mirror / Atom feed
From: bugcrazy <bugcrazy@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] devilutionX: update to 1.2.1
Date: Wed, 21 Apr 2021 23:01:51 +0200	[thread overview]
Message-ID: <20210421210151.jvzjTfxr4GDCWcQwlMFKjSFmgBiP6R-ymnYXoxy0kUM@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-30400@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1597 bytes --]

There is an updated pull request by bugcrazy against master on the void-packages repository

https://github.com/bugcrazy/void-packages patch-6
https://github.com/void-linux/void-packages/pull/30400

devilutionX: update to 1.2.1
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/30400.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-6-30400.patch --]
[-- Type: text/x-diff, Size: 2465 bytes --]

From 0858b10593973e371a38e6418b00f98551addd6c Mon Sep 17 00:00:00 2001
From: bugcrazy <39757967+bugcrazy@users.noreply.github.com>
Date: Tue, 20 Apr 2021 22:54:21 -0300
Subject: [PATCH 1/2] devilutionX: update to 1.2.1

---
 srcpkgs/devilutionX/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/devilutionX/template b/srcpkgs/devilutionX/template
index dfef90b4f407..732cd6e31edd 100644
--- a/srcpkgs/devilutionX/template
+++ b/srcpkgs/devilutionX/template
@@ -1,16 +1,16 @@
 # Template file for 'devilutionX'
 pkgname=devilutionX
-version=1.1.0
+version=1.2.1
 revision=1
 build_style=cmake
-configure_args="-DBINARY_RELEASE=ON -DTTF_FONT_PATH=\"/usr/share/fonts/truetype/CharisSILB.ttf\""
+configure_args="-DVERSION_NUM=1.2.1 -DBINARY_RELEASE=ON -DTTF_FONT_PATH=\"/usr/share/fonts/truetype/CharisSILB.ttf\""
 makedepends="SDL2-devel SDL2_ttf-devel SDL2_mixer-devel libsodium-devel"
 short_desc="Diablo I engine for modern operating systems"
 maintainer="MarcoAPC <marcoaureliopc@gmail.com>"
 license="Unlicense"
 homepage="https://github.com/diasurgical/devilutionX"
 distfiles="https://github.com/diasurgical/devilutionX/archive/${version}.tar.gz"
-checksum=395ec298df5383abe60550d45adba5e5811984589ccb1e504891b267b3c467c1
+checksum=002dcbd4d4a5bdf8db1a3ec01139e5bfbed46d6a1caa32b17c9f2df161ad3521
 nocross="https://build.voidlinux.org/builders/aarch64-musl_builder/builds/25453/steps/shell_3/logs/stdio"
 
 post_install() {

From 18446e4e13738fe0f7277da375169fecde81752e Mon Sep 17 00:00:00 2001
From: bugcrazy <39757967+bugcrazy@users.noreply.github.com>
Date: Wed, 21 Apr 2021 18:01:48 -0300
Subject: [PATCH 2/2] Applied suggested changes

---
 srcpkgs/devilutionX/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/devilutionX/template b/srcpkgs/devilutionX/template
index 732cd6e31edd..4b5282b210c6 100644
--- a/srcpkgs/devilutionX/template
+++ b/srcpkgs/devilutionX/template
@@ -3,7 +3,7 @@ pkgname=devilutionX
 version=1.2.1
 revision=1
 build_style=cmake
-configure_args="-DVERSION_NUM=1.2.1 -DBINARY_RELEASE=ON -DTTF_FONT_PATH=\"/usr/share/fonts/truetype/CharisSILB.ttf\""
+configure_args="-DVERSION_NUM=$version -DBINARY_RELEASE=ON -DTTF_FONT_PATH=\"/usr/share/fonts/truetype/CharisSILB.ttf\""
 makedepends="SDL2-devel SDL2_ttf-devel SDL2_mixer-devel libsodium-devel"
 short_desc="Diablo I engine for modern operating systems"
 maintainer="MarcoAPC <marcoaureliopc@gmail.com>"

  parent reply	other threads:[~2021-04-21 21:01 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-21  2:07 [PR PATCH] " bugcrazy
2021-04-21 16:49 ` [PR REVIEW] " ericonr
2021-04-21 17:33 ` Chocimier
2021-04-21 21:01 ` bugcrazy [this message]
2021-04-21 21:03 ` [PR REVIEW] " bugcrazy
2021-04-21 21:09 ` ericonr
2021-04-21 21:10 ` ericonr
2021-04-22  4:34 ` [PR PATCH] [Updated] " bugcrazy
2021-04-22  6:09 ` bugcrazy
2021-04-22  6:17 ` [PR REVIEW] " bugcrazy
2021-04-22  6:20 ` bugcrazy
2021-04-22 13:37 ` [PR REVIEW] " ericonr
2021-04-22 23:59 ` [PR PATCH] [Updated] " bugcrazy
2021-04-23  0:03 ` bugcrazy
2021-04-23  0:05 ` [PR REVIEW] " bugcrazy
2021-04-23  0:16 ` [PR PATCH] [Merged]: " ericonr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210421210151.jvzjTfxr4GDCWcQwlMFKjSFmgBiP6R-ymnYXoxy0kUM@z \
    --to=bugcrazy@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).